+9

src/applications/config/check/PhabricatorExtraConfigSetupCheck.php

reviewed

··· 171 171 'Phabricator no longer supports global customization of monospaced '. 172 172 'fonts.'); 173 173 174 174 + $public_mail_reason = pht( 175 175 + 'Inbound mail addresses are now configured for each application '. 176 176 + 'in the Applications tool.'); 177 177 + 174 178 $ancient_config += array( 175 179 'phid.external-loaders' => 176 180 pht( ··· 256 260 'search.engine-selector' => pht( 257 261 'Phabricator now automatically discovers available search engines '. 258 262 'at runtime.'), 263 263 + 264 264 + 'metamta.files.public-create-email' => $public_mail_reason, 265 265 + 'metamta.maniphest.public-create-email' => $public_mail_reason, 266 266 + 'metamta.maniphest.default-public-author' => $public_mail_reason, 267 267 + 'metamta.paste.public-create-email' => $public_mail_reason, 259 268 ); 260 269 261 270 return $ancient_config;

-14

src/applications/files/config/PhabricatorFilesConfigOptions.php

reviewed

··· 157 157 "must also configure S3 access keys in the 'Amazon Web Services' ". 158 158 "group.")), 159 159 $this->newOption( 160 160 - 'metamta.files.public-create-email', 161 161 - 'string', 162 162 - null) 163 163 - ->setLocked(true) 164 164 - ->setLockedMessage(pht( 165 165 - 'This configuration is deprecated. See description for details.')) 166 166 - ->setSummary(pht('DEPRECATED - Allow uploaded files via email.')) 167 167 - ->setDescription( 168 168 - pht( 169 169 - 'This config has been deprecated in favor of [[ '. 170 170 - '/applications/view/PhabricatorFilesApplication/ | '. 171 171 - 'application settings ]], which allow for multiple email '. 172 172 - 'addresses and other functionality.')), 173 173 - $this->newOption( 174 160 'metamta.files.subject-prefix', 175 161 'string', 176 162 '[File]')

-51

src/applications/maniphest/config/PhabricatorManiphestConfigOptions.php

reviewed

··· 297 297 '[Maniphest]') 298 298 ->setDescription(pht('Subject prefix for Maniphest mail.')), 299 299 $this->newOption( 300 300 - 'metamta.maniphest.public-create-email', 301 301 - 'string', 302 302 - null) 303 303 - ->setLocked(true) 304 304 - ->setLockedMessage(pht( 305 305 - 'This configuration is deprecated. See description for details.')) 306 306 - ->setSummary(pht('DEPRECATED - Allow filing bugs via email.')) 307 307 - ->setDescription( 308 308 - pht( 309 309 - 'This config has been deprecated in favor of [[ '. 310 310 - '/applications/view/PhabricatorManiphestApplication/ | '. 311 311 - 'application settings ]], which allow for multiple email '. 312 312 - 'addresses and other functionality.'."\n\n". 313 313 - 'You can configure an email address like '. 314 314 - '"bugs@phabricator.example.com" which will automatically create '. 315 315 - 'Maniphest tasks when users send email to it. This relies on the '. 316 316 - '"From" address to authenticate users, so it is is not completely '. 317 317 - 'secure. To set this up, enter a complete email address like '. 318 318 - '"bugs@phabricator.example.com" and then configure mail to that '. 319 319 - 'address so it routed to Phabricator (if you\'ve already '. 320 320 - 'configured reply handlers, you\'re probably already done). See '. 321 321 - '"Configuring Inbound Email" in the documentation for more '. 322 322 - 'information.')), 323 323 - $this->newOption( 324 324 - 'metamta.maniphest.default-public-author', 325 325 - 'string', 326 326 - null) 327 327 - ->setLocked(true) 328 328 - ->setLockedMessage(pht( 329 329 - 'This configuration is deprecated. See description for details.')) 330 330 - ->setSummary(pht( 331 331 - 'DEPRECATED - Username anonymous bugs are filed under.')) 332 332 - ->setDescription( 333 333 - pht( 334 334 - 'This config has been deprecated in favor of [[ '. 335 335 - '/applications/view/PhabricatorManiphestApplication/ | '. 336 336 - 'application settings ]], which allow for multiple email '. 337 337 - 'addresses each with its own default author, and other '. 338 338 - 'functionality.'."\n\n". 339 339 - 'If you enable `metamta.maniphest.public-create-email` and create '. 340 340 - 'an email address like "bugs@phabricator.example.com", it will '. 341 341 - 'default to rejecting mail which doesn\'t come from a known user. '. 342 342 - 'However, you might want to let anyone send email to this '. 343 343 - 'address; to do so, set a default author here (a Phabricator '. 344 344 - 'username). A typical use of this might be to create a "System '. 345 345 - 'Agent" user called "bugs" and use that name here. If you specify '. 346 346 - 'a valid username, mail will always be accepted and used to '. 347 347 - 'create a task, even if the sender is not a system user. The '. 348 348 - 'original email address will be stored in an `From Email` field '. 349 349 - 'on the task.')), 350 350 - $this->newOption( 351 300 'maniphest.priorities.unbreak-now', 352 301 'int', 353 302 100)

+1 -14

src/applications/maniphest/controller/ManiphestTaskEditController.php

reviewed

··· 684 684 'tokenizerID' => $project_tokenizer_id, 685 685 )); 686 686 687 687 - $description_control = new PhabricatorRemarkupControl(); 688 688 - // "Upsell" creating tasks via email in create flows if the instance is 689 689 - // configured for this awesomeness. 690 690 - $email_create = PhabricatorEnv::getEnvConfig( 691 691 - 'metamta.maniphest.public-create-email'); 692 692 - if (!$task->getID() && $email_create) { 693 693 - $email_hint = pht( 694 694 - 'You can also create tasks by sending an email to: %s', 695 695 - phutil_tag('tt', array(), $email_create)); 696 696 - $description_control->setCaption($email_hint); 697 697 - } 698 698 - 699 699 - $description_control 687 687 + $description_control = id(new PhabricatorRemarkupControl()) 700 688 ->setLabel(pht('Description')) 701 689 ->setName('description') 702 690 ->setID('description-textarea') ··· 705 693 706 694 $form 707 695 ->appendChild($description_control); 708 708 - 709 696 710 697 if ($request->isAjax()) { 711 698 $dialog = id(new AphrontDialogView())

-14

src/applications/paste/config/PhabricatorPasteConfigOptions.php

reviewed

··· 22 22 public function getOptions() { 23 23 return array( 24 24 $this->newOption( 25 25 - 'metamta.paste.public-create-email', 26 26 - 'string', 27 27 - null) 28 28 - ->setLocked(true) 29 29 - ->setLockedMessage(pht( 30 30 - 'This configuration is deprecated. See description for details.')) 31 31 - ->setSummary(pht('DEPRECATED - Allow creating pastes via email.')) 32 32 - ->setDescription( 33 33 - pht( 34 34 - 'This config has been deprecated in favor of [[ '. 35 35 - '/applications/view/PhabricatorPasteApplication/ | '. 36 36 - 'application settings ]], which allow for multiple email '. 37 37 - 'addresses and other functionality.')), 38 38 - $this->newOption( 39 25 'metamta.paste.subject-prefix', 40 26 'string', 41 27 '[Paste]')