@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix an issue with AuthProviderConfig handles
Summary: Fixes T11156. These were never correct, but also never actually used until I made timelines load object handles unconditionally in D16111.
Test Plan: Viewed an auth provider with transactions, no more fatal.
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T11156
Differential Revision: https://secure.phabricator.com/D16128
+4
-2
+4
-2
src/applications/auth/phid/PhabricatorAuthAuthProviderPHIDType.php
+4
-2
src/applications/auth/phid/PhabricatorAuthAuthProviderPHIDType.php
···
30
30
array $objects) {
31
31
32
32
foreach ($handles as $phid => $handle) {
33
-
$provider = $objects[$phid];
33
+
$provider = $objects[$phid]->getProvider();
34
34
35
-
$handle->setName($provider->getProviderName());
35
+
if ($provider) {
36
+
$handle->setName($provider->getProviderName());
37
+
}
36
38
}
37
39
}
38
40