@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Add some trivial Herald related PhpDoc comments
Summary: Self-explanatory.
Test Plan: Read and play with code.
Reviewers: O1 Blessed Committers, valerio.bozzolan
Reviewed By: O1 Blessed Committers, valerio.bozzolan
Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno
Differential Revision: https://we.phorge.it/D25884
+22
+3
src/applications/herald/action/HeraldAction.php
+3
src/applications/herald/action/HeraldAction.php
+16
src/applications/herald/engine/HeraldEffect.php
+16
src/applications/herald/engine/HeraldEffect.php
···
13
13
return $this;
14
14
}
15
15
16
+
/**
17
+
* @return string PHID of the object that Herald is applied on
18
+
*/
16
19
public function getObjectPHID() {
17
20
return $this->objectPHID;
18
21
}
···
22
25
return $this;
23
26
}
24
27
28
+
/**
29
+
* @return string ACTIONCONST of the HeraldAction
30
+
*/
25
31
public function getAction() {
26
32
return $this->action;
27
33
}
···
31
37
return $this;
32
38
}
33
39
40
+
/**
41
+
* @return array|null
42
+
*/
34
43
public function getTarget() {
35
44
return $this->target;
36
45
}
···
40
49
return $this;
41
50
}
42
51
52
+
/**
53
+
* @return HeraldRule
54
+
*/
43
55
public function getRule() {
44
56
return $this->rule;
45
57
}
···
49
61
return $this;
50
62
}
51
63
64
+
/**
65
+
* @return string Reason why Herald effect was applied, for example
66
+
* "Conditions were met for H123 RuleName"
67
+
*/
52
68
public function getReason() {
53
69
return $this->reason;
54
70
}
+3
src/applications/herald/storage/HeraldRule.php
+3
src/applications/herald/storage/HeraldRule.php