@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Render Phame templates in the expected order
Summary: Currently, content runs before header. Instead, run header, content, footer. This makes it easier to use `header.php` for includes, for Phacility.
Test Plan: Made Phacility blog work better, see next diff.
Reviewers: chad
Reviewed By: chad
Subscribers: epriestley
Differential Revision: https://secure.phabricator.com/D10067
+7
-2
+7
-2
src/applications/phame/skins/PhameBasicTemplateBlogSkin.php
+7
-2
src/applications/phame/skins/PhameBasicTemplateBlogSkin.php
···
41
41
$this->cssResources = phutil_implode_html("\n", $this->cssResources);
42
42
43
43
$request = $this->getRequest();
44
+
45
+
// Render page parts in order so the templates execute in order, if we're
46
+
// using templates.
47
+
$header = $this->renderHeader();
44
48
$content = $this->renderContent($request);
49
+
$footer = $this->renderFooter();
45
50
46
51
if (!$content) {
47
52
$content = $this->render404Page();
48
53
}
49
54
50
55
$content = array(
51
-
$this->renderHeader(),
56
+
$header,
52
57
$content,
53
-
$this->renderFooter(),
58
+
$footer,
54
59
);
55
60
56
61
$response = new AphrontWebpageResponse();