recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Allow "Wait for Message" to be unset on build plans

Summary: Fixes T11910. I spent a couple of minutes looking for the root cause without much luck, but this will all be obsoleted by an eventual upgrade to `EditEngine` anyway.

Test Plan: Set and unset "Wait for Message", which now worked.

Reviewers: chad, avivey

Reviewed By: avivey

Subscribers: PHID-OPKG-gm6ozazyms6q6i22gyam

Maniphest Tasks: T11910

Differential Revision: https://secure.phabricator.com/D16919

epriestley faf42cbe add20783

+3 -2
+1 -1
src/applications/harbormaster/customfield/HarbormasterBuildStepCoreCustomField.php
··· 43 43 'the result for this step. After the result is recorded, the build '. 44 44 'plan will resume.'), 45 45 'options' => array( 46 - '' => pht('Continue Build Normally'), 46 + 'continue' => pht('Continue Build Normally'), 47 47 'wait' => pht('Wait For Message'), 48 48 ), 49 49 );
+2 -1
src/applications/harbormaster/step/HarbormasterBuildStepImplementation.php
··· 237 237 return false; 238 238 } 239 239 240 - return (bool)$target->getDetail('builtin.wait-for-message'); 240 + $wait = $target->getDetail('builtin.wait-for-message'); 241 + return ($wait == 'wait'); 241 242 } 242 243 243 244 protected function shouldAbort(