@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix some overlooked profile menu construction callsites
Summary: Depends on D20384. Ref T13275. A bunch of this code got converted but I missed some callsites that aren't reached directly from the menu.
Test Plan:
- Visited each controller, saw actual pages instead of menu construction fatals.
- Grepped for `getProfileMenu()`.
Reviewers: amckinley
Reviewed By: amckinley
Maniphest Tasks: T13275
Differential Revision: https://secure.phabricator.com/D20385
+18
-9
+3
-2
src/applications/people/controller/PhabricatorPeopleProfileEditController.php
+3
-2
src/applications/people/controller/PhabricatorPeopleProfileEditController.php
···
83
83
$crumbs->addTextCrumb(pht('Edit Profile'));
84
84
$crumbs->setBorder(true);
85
85
86
-
$nav = $this->getProfileMenu();
87
-
$nav->selectFilter(PhabricatorPeopleProfileMenuEngine::ITEM_MANAGE);
86
+
$nav = $this->newNavigation(
87
+
$user,
88
+
PhabricatorPeopleProfileMenuEngine::ITEM_MANAGE);
88
89
89
90
$header = id(new PHUIHeaderView())
90
91
->setHeader(pht('Edit Profile: %s', $user->getFullName()))
+3
-2
src/applications/people/controller/PhabricatorPeopleProfilePictureController.php
+3
-2
src/applications/people/controller/PhabricatorPeopleProfilePictureController.php
···
266
266
$crumbs->addTextCrumb(pht('Edit Profile Picture'));
267
267
$crumbs->setBorder(true);
268
268
269
-
$nav = $this->getProfileMenu();
270
-
$nav->selectFilter(PhabricatorPeopleProfileMenuEngine::ITEM_MANAGE);
269
+
$nav = $this->newNavigation(
270
+
$user,
271
+
PhabricatorPeopleProfileMenuEngine::ITEM_MANAGE);
271
272
272
273
$header = $this->buildProfileHeader();
273
274
+3
-1
src/applications/project/controller/PhabricatorProjectBoardBackgroundController.php
+3
-1
src/applications/project/controller/PhabricatorProjectBoardBackgroundController.php
+3
-1
src/applications/project/controller/PhabricatorProjectBoardManageController.php
+3
-1
src/applications/project/controller/PhabricatorProjectBoardManageController.php
···
38
38
$crumbs->addTextCrumb(pht('Manage'));
39
39
$crumbs->setBorder(true);
40
40
41
-
$nav = $this->getProfileMenu();
41
+
$nav = $this->newNavigation(
42
+
$board,
43
+
PhabricatorProject::ITEM_WORKBOARD);
42
44
$columns_list = $this->buildColumnsList($board, $columns);
43
45
44
46
require_celerity_resource('project-view-css');
+3
-1
src/applications/project/controller/PhabricatorProjectColumnDetailController.php
+3
-1
src/applications/project/controller/PhabricatorProjectColumnDetailController.php
···
51
51
$crumbs->addTextCrumb(pht('Column: %s', $title));
52
52
$crumbs->setBorder(true);
53
53
54
-
$nav = $this->getProfileMenu();
54
+
$nav = $this->newNavigation(
55
+
$project,
56
+
PhabricatorProject::ITEM_WORKBOARD);
55
57
require_celerity_resource('project-view-css');
56
58
57
59
$view = id(new PHUITwoColumnView())
+3
-2
src/applications/project/controller/PhabricatorProjectEditPictureController.php
+3
-2
src/applications/project/controller/PhabricatorProjectEditPictureController.php
···
273
273
->setHeaderText(pht('Upload New Picture'))
274
274
->setForm($upload_form);
275
275
276
-
$nav = $this->getProfileMenu();
277
-
$nav->selectFilter(PhabricatorProject::ITEM_MANAGE);
276
+
$nav = $this->newNavigation(
277
+
$project,
278
+
PhabricatorProject::ITEM_MANAGE);
278
279
279
280
return $this->newPage()
280
281
->setTitle($title)