@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
fix inline comment for new differential fluid view
Summary: we need to render left and right* classes as appropriate, plus colspan for the right
Test Plan: made inline comments and it was no longer borked
Reviewers: vrana, epriestley, chad
Reviewed By: chad
CC: aran, Korvin
Maniphest Tasks: T2005
Differential Revision: https://secure.phabricator.com/D4131
+10
-2
+10
-2
src/applications/differential/view/DifferentialInlineCommentEditView.php
+10
-2
src/applications/differential/view/DifferentialInlineCommentEditView.php
···
65
65
$this->renderBody());
66
66
67
67
if ($this->onRight) {
68
-
$core = '<th></th><td></td><th></th><td colspan="2">'.$content.'</td>';
68
+
$core =
69
+
'<th></th>'.
70
+
'<td class="left"></td>'.
71
+
'<th></th>'.
72
+
'<td colspan="3" class="right3">'.$content.'</td>';
69
73
} else {
70
-
$core = '<th></th><td>'.$content.'</td><th></th><td colspan="2"></td>';
74
+
$core =
75
+
'<th></th>'.
76
+
'<td class="left">'.$content.'</td>'.
77
+
'<th></th>'.
78
+
'<td colspan="3" class="right3"></td>';
71
79
}
72
80
73
81
return '<table><tr class="inline-comment-splint">'.$core.'</tr></table>';