@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Respect "can edit username" in registration UI
Summary:
Fixes T3741. The flag is respected in terms of actually creating the account, but the UI is a bit unclear.
This can never occur naturally, but installs can register an event which locks it.
Test Plan:
Artificially locked it, verified I got more reasonable UI;
{F81282}
Reviewers: btrahan, datr
Reviewed By: datr
CC: aran
Maniphest Tasks: T3741
Differential Revision: https://secure.phabricator.com/D7577
+9
-2
+9
-2
src/applications/auth/controller/PhabricatorAuthRegisterController.php
+9
-2
src/applications/auth/controller/PhabricatorAuthRegisterController.php
···
326
326
}
327
327
328
328
329
-
$form
330
-
->appendChild(
329
+
if ($can_edit_username) {
330
+
$form->appendChild(
331
331
id(new AphrontFormTextControl())
332
332
->setLabel(pht('Phabricator Username'))
333
333
->setName('username')
334
334
->setValue($value_username)
335
335
->setError($e_username));
336
+
} else {
337
+
$form->appendChild(
338
+
id(new AphrontFormMarkupControl())
339
+
->setLabel(pht('Phabricator Username'))
340
+
->setValue($value_username)
341
+
->setError($e_username));
342
+
}
336
343
337
344
if ($must_set_password) {
338
345
$form->appendChild(