recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

(PhabricatorIRCProtocolAdapter.connect) Use recommended connection registration order from RFC{1459,2812}

http://tools.ietf.org/html/rfc1459.html#section-4.1 and http://tools.ietf.org/html/rfc2812#section-3.1
mentions that client should send the PASS first, then the latter of NICK/USER.

This is tested and confirmed working with ngircd commit 485d0aec813db9966922f17aae044df2d82b0b67

See: <https://github.com/facebook/phabricator/pull/524>

Reviewed by: epriestley

authored by

Roy Sindre Norangshol and committed by
epriestley fb87d0f4 d1e64e64

+1 -1
+1 -1
src/infrastructure/daemon/bot/adapter/PhabricatorIRCProtocolAdapter.php
··· 49 49 } 50 50 51 51 $this->socket = $socket; 52 - $this->write("USER {$user} 0 * :{$user}"); 53 52 if ($pass) { 54 53 $this->write("PASS {$pass}"); 55 54 } 56 55 $this->write("NICK {$nick}"); 56 + $this->write("USER {$user} 0 * :{$user}"); 57 57 } 58 58 59 59 public function getNextMessages($poll_frequency) {