recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Modernize various menu collapse settings

Summary: Ref T4103. Fully modernize the filetree show/hide, durable column show/hide, and profile menu collapse/wide settings.

Test Plan:
- Toggled filetree on/off, reloaded page, setting stuck.
- Same with conpherence column and profile menus.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T4103

Differential Revision: https://secure.phabricator.com/D16034

epriestley fc45de29 804e7a6e

+47 -12
+6
src/__phutil_library_map__.php
··· 2144 2144 'PhabricatorConfigVersionsModule' => 'applications/config/module/PhabricatorConfigVersionsModule.php', 2145 2145 'PhabricatorConfigWelcomeController' => 'applications/config/controller/PhabricatorConfigWelcomeController.php', 2146 2146 'PhabricatorConpherenceApplication' => 'applications/conpherence/application/PhabricatorConpherenceApplication.php', 2147 + 'PhabricatorConpherenceColumnVisibleSetting' => 'applications/settings/setting/PhabricatorConpherenceColumnVisibleSetting.php', 2147 2148 'PhabricatorConpherenceNotificationsSetting' => 'applications/settings/setting/PhabricatorConpherenceNotificationsSetting.php', 2148 2149 'PhabricatorConpherencePreferencesSettingsPanel' => 'applications/settings/panel/PhabricatorConpherencePreferencesSettingsPanel.php', 2149 2150 'PhabricatorConpherenceThreadPHIDType' => 'applications/conpherence/phid/PhabricatorConpherenceThreadPHIDType.php', ··· 2515 2516 'PhabricatorFilesManagementWorkflow' => 'applications/files/management/PhabricatorFilesManagementWorkflow.php', 2516 2517 'PhabricatorFilesOnDiskBuiltinFile' => 'applications/files/builtin/PhabricatorFilesOnDiskBuiltinFile.php', 2517 2518 'PhabricatorFilesOutboundRequestAction' => 'applications/files/action/PhabricatorFilesOutboundRequestAction.php', 2519 + 'PhabricatorFiletreeVisibleSetting' => 'applications/settings/setting/PhabricatorFiletreeVisibleSetting.php', 2518 2520 'PhabricatorFlag' => 'applications/flag/storage/PhabricatorFlag.php', 2519 2521 'PhabricatorFlagAddFlagHeraldAction' => 'applications/flag/herald/PhabricatorFlagAddFlagHeraldAction.php', 2520 2522 'PhabricatorFlagColor' => 'applications/flag/constants/PhabricatorFlagColor.php', ··· 3049 3051 'PhabricatorPolicyTestObject' => 'applications/policy/__tests__/PhabricatorPolicyTestObject.php', 3050 3052 'PhabricatorPolicyType' => 'applications/policy/constants/PhabricatorPolicyType.php', 3051 3053 'PhabricatorPonderApplication' => 'applications/ponder/application/PhabricatorPonderApplication.php', 3054 + 'PhabricatorProfileMenuCollapsedSetting' => 'applications/settings/setting/PhabricatorProfileMenuCollapsedSetting.php', 3052 3055 'PhabricatorProfilePanel' => 'applications/search/profilepanel/PhabricatorProfilePanel.php', 3053 3056 'PhabricatorProfilePanelConfiguration' => 'applications/search/storage/PhabricatorProfilePanelConfiguration.php', 3054 3057 'PhabricatorProfilePanelConfigurationQuery' => 'applications/search/query/PhabricatorProfilePanelConfigurationQuery.php', ··· 6692 6695 'PhabricatorConfigVersionsModule' => 'PhabricatorConfigModule', 6693 6696 'PhabricatorConfigWelcomeController' => 'PhabricatorConfigController', 6694 6697 'PhabricatorConpherenceApplication' => 'PhabricatorApplication', 6698 + 'PhabricatorConpherenceColumnVisibleSetting' => 'PhabricatorInternalSetting', 6695 6699 'PhabricatorConpherenceNotificationsSetting' => 'PhabricatorSelectSetting', 6696 6700 'PhabricatorConpherencePreferencesSettingsPanel' => 'PhabricatorEditEngineSettingsPanel', 6697 6701 'PhabricatorConpherenceThreadPHIDType' => 'PhabricatorPHIDType', ··· 7126 7130 'PhabricatorFilesManagementWorkflow' => 'PhabricatorManagementWorkflow', 7127 7131 'PhabricatorFilesOnDiskBuiltinFile' => 'PhabricatorFilesBuiltinFile', 7128 7132 'PhabricatorFilesOutboundRequestAction' => 'PhabricatorSystemAction', 7133 + 'PhabricatorFiletreeVisibleSetting' => 'PhabricatorInternalSetting', 7129 7134 'PhabricatorFlag' => array( 7130 7135 'PhabricatorFlagDAO', 7131 7136 'PhabricatorPolicyInterface', ··· 7732 7737 ), 7733 7738 'PhabricatorPolicyType' => 'PhabricatorPolicyConstants', 7734 7739 'PhabricatorPonderApplication' => 'PhabricatorApplication', 7740 + 'PhabricatorProfileMenuCollapsedSetting' => 'PhabricatorInternalSetting', 7735 7741 'PhabricatorProfilePanel' => 'Phobject', 7736 7742 'PhabricatorProfilePanelConfiguration' => array( 7737 7743 'PhabricatorSearchDAO',
+1 -1
src/applications/conpherence/view/ConpherenceDurableColumnView.php
··· 108 108 } 109 109 110 110 protected function getTagContent() { 111 - $column_key = PhabricatorUserPreferences::PREFERENCE_CONPHERENCE_COLUMN; 111 + $column_key = PhabricatorConpherenceColumnVisibleSetting::SETTINGKEY; 112 112 113 113 Javelin::initBehavior( 114 114 'durable-column',
+1 -1
src/applications/differential/controller/DifferentialRevisionViewController.php
··· 381 381 382 382 $nav = null; 383 383 if ($filetree_on) { 384 - $collapsed_key = PhabricatorUserPreferences::PREFERENCE_NAV_COLLAPSED; 384 + $collapsed_key = PhabricatorFiletreeVisibleSetting::SETTINGKEY; 385 385 $collapsed_value = $viewer->getUserSetting($collapsed_key); 386 386 387 387 $nav = id(new DifferentialChangesetFileTreeSideNavBuilder())
+1 -1
src/applications/diffusion/controller/DiffusionCommitController.php
··· 329 329 PhabricatorShowFiletreeSetting::SETTINGKEY, 330 330 PhabricatorShowFiletreeSetting::VALUE_ENABLE_FILETREE); 331 331 332 - $pref_collapse = PhabricatorUserPreferences::PREFERENCE_NAV_COLLAPSED; 332 + $pref_collapse = PhabricatorFiletreeVisibleSetting::SETTINGKEY; 333 333 $collapsed = $viewer->getUserSetting($pref_collapse); 334 334 335 335 $nav = null;
+1 -2
src/applications/search/engine/PhabricatorProfilePanelEngine.php
··· 382 382 383 383 $collapse_id = celerity_generate_unique_node_id(); 384 384 $viewer = $this->getViewer(); 385 - $collapse_key = 386 - PhabricatorUserPreferences::PREFERENCE_PROFILE_MENU_COLLAPSED; 385 + $collapse_key = PhabricatorProfileMenuCollapsedSetting::SETTINGKEY; 387 386 388 387 $is_collapsed = $viewer->getUserSetting($collapse_key); 389 388
+12
src/applications/settings/setting/PhabricatorConpherenceColumnVisibleSetting.php
··· 1 + <?php 2 + 3 + final class PhabricatorConpherenceColumnVisibleSetting 4 + extends PhabricatorInternalSetting { 5 + 6 + const SETTINGKEY = 'conpherence-column'; 7 + 8 + public function getSettingName() { 9 + return pht('Conpherence Column Visible'); 10 + } 11 + 12 + }
+12
src/applications/settings/setting/PhabricatorFiletreeVisibleSetting.php
··· 1 + <?php 2 + 3 + final class PhabricatorFiletreeVisibleSetting 4 + extends PhabricatorInternalSetting { 5 + 6 + const SETTINGKEY = 'nav-collapsed'; 7 + 8 + public function getSettingName() { 9 + return pht('Filetree Visible'); 10 + } 11 + 12 + }
+12
src/applications/settings/setting/PhabricatorProfileMenuCollapsedSetting.php
··· 1 + <?php 2 + 3 + final class PhabricatorProfileMenuCollapsedSetting 4 + extends PhabricatorInternalSetting { 5 + 6 + const SETTINGKEY = 'profile-menu.collapsed'; 7 + 8 + public function getSettingName() { 9 + return pht('Profile Menu Collapsed'); 10 + } 11 + 12 + }
-6
src/applications/settings/storage/PhabricatorUserPreferences.php
··· 14 14 const PREFERENCE_VARY_SUBJECT = 'vary-subject'; 15 15 const PREFERENCE_HTML_EMAILS = 'html-emails'; 16 16 17 - const PREFERENCE_NAV_COLLAPSED = 'nav-collapsed'; 18 - const PREFERENCE_APP_TILES = 'app-tiles'; 19 - const PREFERENCE_APP_PINNED = 'app-pinned'; 20 - 21 - const PREFERENCE_CONPHERENCE_COLUMN = 'conpherence-column'; 22 17 const PREFERENCE_DESKTOP_NOTIFICATIONS = 'desktop-notifications'; 23 - const PREFERENCE_PROFILE_MENU_COLLAPSED = 'profile-menu.collapsed'; 24 18 25 19 // These are in an unusual order for historic reasons. 26 20 const MAILTAG_PREFERENCE_NOTIFY = 0;
+1 -1
src/view/page/PhabricatorStandardPageView.php
··· 132 132 } 133 133 134 134 public function getDurableColumnVisible() { 135 - $column_key = PhabricatorUserPreferences::PREFERENCE_CONPHERENCE_COLUMN; 135 + $column_key = PhabricatorConpherenceColumnVisibleSetting::SETTINGKEY; 136 136 return (bool)$this->getUserPreference($column_key, false); 137 137 } 138 138