@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Remove obsolete "options" from workboard "updateCard()" call
Summary: Depends on D20637. Ref T4900. This is some ancient dead code that nothing uses.
Test Plan: Grepped for `updateCard()` to verify it's private. Searched for "options" and "dirtyColumn" and got no hits.
Reviewers: amckinley
Reviewed By: amckinley
Maniphest Tasks: T4900
Differential Revision: https://secure.phabricator.com/D20638
+15
-18
+14
-14
resources/celerity/map.php
+14
-14
resources/celerity/map.php
···
412
412
'rsrc/js/application/phortune/phortune-credit-card-form.js' => 'd12d214f',
413
413
'rsrc/js/application/policy/behavior-policy-control.js' => '0eaa33a9',
414
414
'rsrc/js/application/policy/behavior-policy-rule-editor.js' => '9347f172',
415
-
'rsrc/js/application/projects/WorkboardBoard.js' => 'c02a5497',
415
+
'rsrc/js/application/projects/WorkboardBoard.js' => '44f71637',
416
416
'rsrc/js/application/projects/WorkboardCard.js' => '0392a5d8',
417
417
'rsrc/js/application/projects/WorkboardCardTemplate.js' => '2a61f8d4',
418
418
'rsrc/js/application/projects/WorkboardColumn.js' => 'c3d24e63',
···
743
743
'javelin-view-renderer' => '9aae2b66',
744
744
'javelin-view-visitor' => '308f9fe4',
745
745
'javelin-websocket' => 'fdc13e4e',
746
-
'javelin-workboard-board' => 'c02a5497',
746
+
'javelin-workboard-board' => '44f71637',
747
747
'javelin-workboard-card' => '0392a5d8',
748
748
'javelin-workboard-card-template' => '2a61f8d4',
749
749
'javelin-workboard-column' => 'c3d24e63',
···
1305
1305
'javelin-uri',
1306
1306
'javelin-routable',
1307
1307
),
1308
+
'44f71637' => array(
1309
+
'javelin-install',
1310
+
'javelin-dom',
1311
+
'javelin-util',
1312
+
'javelin-stratcom',
1313
+
'javelin-workflow',
1314
+
'phabricator-draggable-list',
1315
+
'javelin-workboard-column',
1316
+
'javelin-workboard-header-template',
1317
+
'javelin-workboard-card-template',
1318
+
'javelin-workboard-order-template',
1319
+
),
1308
1320
'46116c01' => array(
1309
1321
'javelin-request',
1310
1322
'javelin-behavior',
···
1942
1954
),
1943
1955
'bde53589' => array(
1944
1956
'phui-inline-comment-view-css',
1945
-
),
1946
-
'c02a5497' => array(
1947
-
'javelin-install',
1948
-
'javelin-dom',
1949
-
'javelin-util',
1950
-
'javelin-stratcom',
1951
-
'javelin-workflow',
1952
-
'phabricator-draggable-list',
1953
-
'javelin-workboard-column',
1954
-
'javelin-workboard-header-template',
1955
-
'javelin-workboard-card-template',
1956
-
'javelin-workboard-order-template',
1957
1957
),
1958
1958
'c03f2fb4' => array(
1959
1959
'javelin-install',
+1
-4
webroot/rsrc/js/application/projects/WorkboardBoard.js
+1
-4
webroot/rsrc/js/application/projects/WorkboardBoard.js
···
570
570
list.unlock();
571
571
},
572
572
573
-
updateCard: function(response, options) {
574
-
options = options || {};
575
-
options.dirtyColumns = options.dirtyColumns || {};
576
-
573
+
updateCard: function(response) {
577
574
var columns = this.getColumns();
578
575
579
576
var phid = response.objectPHID;