recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Update menu item names for Applications -> Favorites

Summary: Adds a `MenuName` method to applications that `ProfileMenuItem` uses instead of the application name if set. This improves the home/menu/new user experience at little cost. Also renamed the label from Applications to Favorites, since this menu gets altered to provide more than just applications. This also allows instances to set back to Maniphest if they so choose. Overall I think this direction resolves 95% of my concerns, with maybe a small potential downside which I don't really anticipate. We already name Dashboard panels by their object, and that hasn't really caused confusion. I think these links are similar. I click 'Tasks' and get presented a list of my tasks from Maniphest.

Test Plan: Review each of the name changes as a default new install and a modified install.

Reviewers: epriestley, amckinley

Reviewed By: epriestley

Spies: Korvin

Differential Revision: https://secure.phabricator.com/D18524

Chad Little fc893658 e1fd74dd

+33 -5
+4
src/applications/base/PhabricatorApplication.php
··· 57 57 58 58 abstract public function getName(); 59 59 60 + public function getMenuName() { 61 + return $this->getName(); 62 + } 63 + 60 64 public function getShortDescription() { 61 65 return pht('%s Application', $this->getName()); 62 66 }
+5 -1
src/applications/differential/application/PhabricatorDifferentialApplication.php
··· 10 10 return pht('Differential'); 11 11 } 12 12 13 + public function getMenuName() { 14 + return pht('Code Review'); 15 + } 16 + 13 17 public function getShortDescription() { 14 - return pht('Review Code'); 18 + return pht('Pre-Commit Review'); 15 19 } 16 20 17 21 public function getIcon() {
+4
src/applications/diffusion/application/PhabricatorDiffusionApplication.php
··· 6 6 return pht('Diffusion'); 7 7 } 8 8 9 + public function getMenuName() { 10 + return pht('Repositories'); 11 + } 12 + 9 13 public function getShortDescription() { 10 14 return pht('Host and Browse Repositories'); 11 15 }
+1 -1
src/applications/home/engine/PhabricatorHomeProfileMenuEngine.php
··· 49 49 $items[] = $this->newItem() 50 50 ->setBuiltinKey(PhabricatorHomeConstants::ITEM_APPS_LABEL) 51 51 ->setMenuItemKey(PhabricatorLabelProfileMenuItem::MENUITEMKEY) 52 - ->setMenuItemProperties(array('name' => pht('Applications'))); 52 + ->setMenuItemProperties(array('name' => pht('Favorites'))); 53 53 54 54 foreach ($applications as $application) { 55 55 if (!$application->isPinnedByDefault($viewer)) {
+4
src/applications/maniphest/application/PhabricatorManiphestApplication.php
··· 6 6 return pht('Maniphest'); 7 7 } 8 8 9 + public function getMenuName() { 10 + return pht('Tasks'); 11 + } 12 + 9 13 public function getShortDescription() { 10 14 return pht('Tasks and Bugs'); 11 15 }
+5 -1
src/applications/phame/application/PhabricatorPhameApplication.php
··· 6 6 return pht('Phame'); 7 7 } 8 8 9 + public function getMenuName() { 10 + return pht('Blogs'); 11 + } 12 + 9 13 public function getBaseURI() { 10 14 return '/phame/'; 11 15 } ··· 15 19 } 16 20 17 21 public function getShortDescription() { 18 - return pht('Blog'); 22 + return pht('Internal and External Blogs'); 19 23 } 20 24 21 25 public function getTitleGlyph() {
+4
src/applications/pholio/application/PhabricatorPholioApplication.php
··· 6 6 return pht('Pholio'); 7 7 } 8 8 9 + public function getMenuName() { 10 + return pht('Design Review'); 11 + } 12 + 9 13 public function getBaseURI() { 10 14 return '/pholio/'; 11 15 }
+5 -1
src/applications/phriction/application/PhabricatorPhrictionApplication.php
··· 6 6 return pht('Phriction'); 7 7 } 8 8 9 - public function getShortDescription() { 9 + public function getMenuName() { 10 10 return pht('Wiki'); 11 + } 12 + 13 + public function getShortDescription() { 14 + return pht('Wiki Documents'); 11 15 } 12 16 13 17 public function getBaseURI() {
+1 -1
src/applications/search/menuitem/PhabricatorApplicationProfileMenuItem.php
··· 31 31 return $name; 32 32 } 33 33 34 - return $application->getName(); 34 + return $application->getMenuName(); 35 35 } 36 36 37 37 public function buildEditEngineFields(