recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Be more strict with JSHint.

Summary: Add a bunch of extra checks to be performed by `jshint`. For documentation, see http://jshint.com/docs/options/.

Test Plan:
Ran `jshint --config support/jshint/jshintconfig webroot/rsrc/js/`. There were a bunch of existing violations, but some of these are legitimate and probably require attention.

```lang=json
{
"bitwise": true, // 0 violations
"curly": true, // 0 violations
"immed": true, // 1 violation
"indent": 2, // 0 violations
"latedef": true, // 10 violations
"newcap": true, // 1 violation
"noarg": true, // 0 violations
"quotmark": "single", // 55 violations
"undef": true, // 24 violations
"unused": true, // 107 violations

"expr": true,
"loopfunc": true,
"sub": true,

"globals": {
"JX": false,
"__DEV__": false
},
"browser": true
}
```

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: epriestley, Korvin

Differential Revision: https://secure.phabricator.com/D9659

Joshua Spence fcaeb2ae e0191750

+20 -3
+20 -3
support/jshint/jshintconfig
··· 1 1 { 2 - "expr" : true, 3 - "loopfunc" : true, 4 - "sub" : true 2 + "bitwise": true, 3 + "curly": true, 4 + "immed": true, 5 + "indent": 2, 6 + "latedef": true, 7 + "newcap": true, 8 + "noarg": true, 9 + "quotmark": "single", 10 + "undef": true, 11 + "unused": true, 12 + 13 + "expr": true, 14 + "loopfunc": true, 15 + "sub": true, 16 + 17 + "globals": { 18 + "JX": false, 19 + "__DEV__": false 20 + }, 21 + "browser": true 5 22 }