Restore "Auditor" as an alias for the commit message field "Auditors"

@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge

phorge phabricator

fork

Summary:
Fixes T12197. I //think// this field was never recognized by Differential (it doesn't appear in D17070, but maybe that isn't the right change).

It was recognized by the ad-hoc regular expression which I replaced with a formal parser in D17262.

Allow the former parser to accept "Auditor" as an alias for "Auditors".

Test Plan: Committed a change with `Auditor: dog`, saw the audit trigger correctly in the web UI.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T12197

Differential Revision: https://secure.phabricator.com/D17306

epriestley 9 years ago fd0591e1 46867692

1 changed file

expand all

src

applications

differential

field

DifferentialAuditorsCommitMessageField.php

src/applications/differential/field/DifferentialAuditorsCommitMessageField.php

··· 9 9 return pht('Auditors'); 10 10 } 11 11 12 + public function getFieldAliases() { 13 + return array( 14 + 'Auditor', 15 + ); 16 + } 17 + 12 18 public function parseFieldValue($value) { 13 19 return $this->parseObjectList( 14 20 $value,

Configure Feed

Configure Feed