@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Widen pinboard to 280x210.
Summary: This widens pinboard images to 280x210, which neatly fits on an iPhone 4, and gives more visual space to Macros and Mocks.
Test Plan: Test Pinboard in Chrome and iOS simulator.
Reviewers: epriestley
Reviewed By: epriestley
CC: aran, Korvin
Differential Revision: https://secure.phabricator.com/D5224
+20
-7
+1
-1
src/__celerity_resource_map__.php
+1
-1
src/__celerity_resource_map__.php
···
2889
2889
),
2890
2890
'phabricator-pinboard-view-css' =>
2891
2891
array(
2892
-
'uri' => '/res/c6af8d76/rsrc/css/layout/phabricator-pinboard-view.css',
2892
+
'uri' => '/res/dbd15ab7/rsrc/css/layout/phabricator-pinboard-view.css',
2893
2893
'type' => 'css',
2894
2894
'requires' =>
2895
2895
array(
+3
src/applications/files/controller/PhabricatorFileTransformController.php
+3
src/applications/files/controller/PhabricatorFileTransformController.php
···
49
49
$unguarded = AphrontWriteGuard::beginScopedUnguardedWrites();
50
50
51
51
switch ($this->transform) {
52
+
case 'thumb-280x210':
53
+
$xformed_file = $this->executeThumbTransform($file, 280, 210);
54
+
break;
52
55
case 'thumb-220x165':
53
56
$xformed_file = $this->executeThumbTransform($file, 220, 165);
54
57
break;
+6
src/applications/files/storage/PhabricatorFile.php
+6
src/applications/files/storage/PhabricatorFile.php
···
475
475
return PhabricatorEnv::getCDNURI($path);
476
476
}
477
477
478
+
public function getThumb280x210URI() {
479
+
$path = '/file/xform/thumb-280x210/'.$this->getPHID().'/'
480
+
.$this->getSecretKey().'/';
481
+
return PhabricatorEnv::getCDNURI($path);
482
+
}
483
+
478
484
public function isViewableInBrowser() {
479
485
return ($this->getViewableMimeType() !== null);
480
486
}
+2
-2
src/applications/macro/controller/PhabricatorMacroListController.php
+2
-2
src/applications/macro/controller/PhabricatorMacroListController.php
···
120
120
121
121
$item = new PhabricatorPinboardItemView();
122
122
if ($file) {
123
-
$item->setImageURI($file->getThumb220x165URI());
124
-
$item->setImageSize(220, 165);
123
+
$item->setImageURI($file->getThumb280x210URI());
124
+
$item->setImageSize(280, 210);
125
125
if ($file->getAuthorPHID()) {
126
126
$author_handle = $this->getHandle($file->getAuthorPHID());
127
127
$item->appendChild(
+2
-2
src/applications/pholio/controller/PholioMockListController.php
+2
-2
src/applications/pholio/controller/PholioMockListController.php
···
52
52
$item = new PhabricatorPinboardItemView();
53
53
$item->setHeader('M'.$mock->getID().' '.$mock->getName())
54
54
->setURI('/M'.$mock->getID())
55
-
->setImageURI($mock->getCoverFile()->getThumb220x165URI())
56
-
->setImageSize(220, 165);
55
+
->setImageURI($mock->getCoverFile()->getThumb280x210URI())
56
+
->setImageSize(280, 210);
57
57
58
58
if ($mock->getAuthorPHID()) {
59
59
$author_handle = $this->getHandle($mock->getAuthorPHID());
+6
-2
webroot/rsrc/css/layout/phabricator-pinboard-view.css
+6
-2
webroot/rsrc/css/layout/phabricator-pinboard-view.css
···
8
8
margin: 1em 0;
9
9
}
10
10
11
+
.device-phone .phabricator-pinboard-view {
12
+
padding: 0;
13
+
}
14
+
11
15
.phabricator-pinboard-item-view {
12
16
margin: 0 16px 16px 0;
13
17
border: 1px solid #d5d9df;
···
15
19
border-radius: 3px;
16
20
17
21
float: left;
18
-
width: 240px;
22
+
width: 300px;
19
23
box-shadow: 0 1px 3px rgba(0, 0, 0, 0.15);
20
24
text-align: left;
21
25
}
···
28
32
/* On phones, show a single column of items. */
29
33
.device-phone .phabricator-pinboard-item-view {
30
34
float: none;
31
-
margin: 0 auto 10px;
35
+
margin: 0 auto 16px;
32
36
}
33
37
34
38
.phabricator-pinboard-item-header {