@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Change wording of "Show Entire File" to "Show All Context"

Summary: Fixes T10139. This clarification seems reasonable to me.

Test Plan:
- Viewed a revision with context.
- Clicked "Show All Context".
- Saw "All Context Shown".

{F1060624}

{F1060625}

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10139

Differential Revision: https://secure.phabricator.com/D15009

+33 -33
+27 -27
resources/celerity/map.php
··· 11 11 'core.pkg.js' => '6ae03393', 12 12 'darkconsole.pkg.js' => 'e7393ebb', 13 13 'differential.pkg.css' => '2de124c9', 14 - 'differential.pkg.js' => '64e69521', 14 + 'differential.pkg.js' => 'f83532f8', 15 15 'diffusion.pkg.css' => 'f45955ed', 16 16 'diffusion.pkg.js' => '3a9a8bfa', 17 17 'maniphest.pkg.css' => '4845691a', ··· 375 375 'rsrc/js/application/dashboard/behavior-dashboard-move-panels.js' => '82439934', 376 376 'rsrc/js/application/dashboard/behavior-dashboard-query-panel-select.js' => '453c5375', 377 377 'rsrc/js/application/dashboard/behavior-dashboard-tab-panel.js' => 'd4eecc63', 378 - 'rsrc/js/application/differential/ChangesetViewManager.js' => '58562350', 378 + 'rsrc/js/application/differential/ChangesetViewManager.js' => 'a2828756', 379 379 'rsrc/js/application/differential/DifferentialInlineCommentEditor.js' => '64a5550f', 380 380 'rsrc/js/application/differential/behavior-add-reviewers-and-ccs.js' => 'e10f8e18', 381 381 'rsrc/js/application/differential/behavior-comment-jump.js' => '4fdb476d', 382 382 'rsrc/js/application/differential/behavior-comment-preview.js' => 'b064af76', 383 383 'rsrc/js/application/differential/behavior-diff-radios.js' => 'e1ff79b1', 384 - 'rsrc/js/application/differential/behavior-dropdown-menus.js' => '2035b9cb', 384 + 'rsrc/js/application/differential/behavior-dropdown-menus.js' => '9a6b9324', 385 385 'rsrc/js/application/differential/behavior-edit-inline-comments.js' => '65ef6074', 386 386 'rsrc/js/application/differential/behavior-keyboard-nav.js' => '2c426492', 387 387 'rsrc/js/application/differential/behavior-populate.js' => '8694b1df', ··· 523 523 'aphront-typeahead-control-css' => '0e403212', 524 524 'auth-css' => '0877ed6e', 525 525 'bulk-job-css' => 'df9c1d4a', 526 - 'changeset-view-manager' => '58562350', 526 + 'changeset-view-manager' => 'a2828756', 527 527 'conduit-api-css' => '7bc725c4', 528 528 'config-options-css' => '0ede4c9b', 529 529 'config-welcome-css' => '6abd79be', ··· 588 588 'javelin-behavior-differential-add-reviewers-and-ccs' => 'e10f8e18', 589 589 'javelin-behavior-differential-comment-jump' => '4fdb476d', 590 590 'javelin-behavior-differential-diff-radios' => 'e1ff79b1', 591 - 'javelin-behavior-differential-dropdown-menus' => '2035b9cb', 591 + 'javelin-behavior-differential-dropdown-menus' => '9a6b9324', 592 592 'javelin-behavior-differential-edit-inline-comments' => '65ef6074', 593 593 'javelin-behavior-differential-feedback-preview' => 'b064af76', 594 594 'javelin-behavior-differential-keyboard-navigation' => '2c426492', ··· 978 978 'phuix-icon-view', 979 979 'javelin-behavior-phabricator-gesture', 980 980 ), 981 - '2035b9cb' => array( 982 - 'javelin-behavior', 983 - 'javelin-dom', 984 - 'javelin-util', 985 - 'javelin-stratcom', 986 - 'javelin-workflow', 987 - 'phuix-dropdown-menu', 988 - 'phuix-action-list-view', 989 - 'phuix-action-view', 990 - 'phabricator-phtize', 991 - 'changeset-view-manager', 992 - ), 993 981 '21ba5861' => array( 994 982 'javelin-behavior', 995 983 'javelin-dom', ··· 1210 1198 'javelin-request', 1211 1199 'javelin-util', 1212 1200 ), 1213 - 58562350 => array( 1214 - 'javelin-dom', 1215 - 'javelin-util', 1216 - 'javelin-stratcom', 1217 - 'javelin-install', 1218 - 'javelin-workflow', 1219 - 'javelin-router', 1220 - 'javelin-behavior-device', 1221 - 'javelin-vector', 1222 - ), 1223 1201 '59a7976a' => array( 1224 1202 'javelin-install', 1225 1203 'javelin-dom', ··· 1571 1549 'javelin-dom', 1572 1550 'javelin-reactor-dom', 1573 1551 ), 1552 + '9a6b9324' => array( 1553 + 'javelin-behavior', 1554 + 'javelin-dom', 1555 + 'javelin-util', 1556 + 'javelin-stratcom', 1557 + 'javelin-workflow', 1558 + 'phuix-dropdown-menu', 1559 + 'phuix-action-list-view', 1560 + 'phuix-action-view', 1561 + 'phabricator-phtize', 1562 + 'changeset-view-manager', 1563 + ), 1574 1564 '9e54692d' => array( 1575 1565 'javelin-install', 1576 1566 'javelin-dom', ··· 1609 1599 'javelin-dom', 1610 1600 'javelin-vector', 1611 1601 'javelin-install', 1602 + ), 1603 + 'a2828756' => array( 1604 + 'javelin-dom', 1605 + 'javelin-util', 1606 + 'javelin-stratcom', 1607 + 'javelin-install', 1608 + 'javelin-workflow', 1609 + 'javelin-router', 1610 + 'javelin-behavior-device', 1611 + 'javelin-vector', 1612 1612 ), 1613 1613 'a464fe03' => array( 1614 1614 'javelin-behavior',
+2 -2
src/applications/differential/view/DifferentialChangesetListView.php
··· 129 129 array( 130 130 'pht' => array( 131 131 'Open in Editor' => pht('Open in Editor'), 132 - 'Show Entire File' => pht('Show Entire File'), 133 - 'Entire File Shown' => pht('Entire File Shown'), 132 + 'Show All Context' => pht('Show All Context'), 133 + 'All Context Shown' => pht('All Context Shown'), 134 134 "Can't Toggle Unloaded File" => pht("Can't Toggle Unloaded File"), 135 135 'Expand File' => pht('Expand File'), 136 136 'Collapse File' => pht('Collapse File'),
+2 -2
webroot/rsrc/js/application/differential/ChangesetViewManager.js
··· 141 141 * Load missing context in a changeset. 142 142 * 143 143 * We do this when the user clicks "Show X Lines". We also expand all of 144 - * the missing context when they "Show Entire File". 144 + * the missing context when they "Show All Context". 145 145 * 146 146 * @param string Line range specification, like "0-40/0-20". 147 147 * @param node Row where the context should be rendered after loading. ··· 162 162 163 163 if (bulk) { 164 164 // If we're loading a bunch of these because the viewer clicked 165 - // "Show Entire File Content" or similar, use lower-priority requests 165 + // "Show All Context" or similar, use lower-priority requests 166 166 // and draw a progress bar. 167 167 this._startContentWorkflow(workflow); 168 168 } else {
+2 -2
webroot/rsrc/js/application/differential/behavior-dropdown-menus.js
··· 180 180 if (nodes.length) { 181 181 reveal_item 182 182 .setDisabled(false) 183 - .setName(pht('Show Entire File')) 183 + .setName(pht('Show All Context')) 184 184 .setIcon('fa-file-o') 185 185 .setHandler(function(e) { 186 186 show_more(JX.$(data.containerID)); ··· 191 191 reveal_item 192 192 .setDisabled(true) 193 193 .setIcon('fa-file') 194 - .setName(pht('Entire File Shown')) 194 + .setName(pht('All Context Shown')) 195 195 .setHandler(function(e) { e.prevent(); }); 196 196 } 197 197