@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Normalize headers and actions in Project sub pages
Summary: Run through all the pages in projects and make sure they all feel similar. Adds back curtain on board manage page, even though it is sad for only having a single action.
Test Plan: Test all pages on a project for consistency in UI.
Reviewers: epriestley
Reviewed By: epriestley
Subscribers: Korvin
Differential Revision: https://secure.phabricator.com/D17909
+26
-18
+25
-16
src/applications/project/controller/PhabricatorProjectBoardManageController.php
+25
-16
src/applications/project/controller/PhabricatorProjectBoardManageController.php
···
31
31
$board_id = $board->getID();
32
32
33
33
$header = $this->buildHeaderView($board);
34
+
$curtain = $this->buildCurtainView($board);
34
35
35
36
$crumbs = $this->buildApplicationCrumbs();
36
37
$crumbs->addTextCrumb(pht('Workboard'), "/project/board/{$board_id}/");
···
46
47
->setHeader($header)
47
48
->addClass('project-view-home')
48
49
->addClass('project-view-people-home')
49
-
->setFooter($columns_list);
50
+
->setCurtain($curtain)
51
+
->setMainColumn($columns_list);
50
52
51
53
$title = array(
52
54
pht('Manage Workboard'),
···
63
65
private function buildHeaderView(PhabricatorProject $board) {
64
66
$viewer = $this->getViewer();
65
67
68
+
$header = id(new PHUIHeaderView())
69
+
->setHeader(pht('Workboard: %s', $board->getDisplayName()))
70
+
->setUser($viewer);
71
+
72
+
return $header;
73
+
}
74
+
75
+
private function buildCurtainView(PhabricatorProject $board) {
76
+
$viewer = $this->getViewer();
77
+
$id = $board->getID();
78
+
79
+
$curtain = $this->newCurtainView();
80
+
66
81
$can_edit = PhabricatorPolicyFilter::hasCapability(
67
82
$viewer,
68
83
$board,
69
84
PhabricatorPolicyCapability::CAN_EDIT);
70
85
71
-
$id = $board->getID();
72
86
$disable_uri = $this->getApplicationURI("board/{$id}/disable/");
73
87
74
-
$button = id(new PHUIButtonView())
75
-
->setTag('a')
76
-
->setIcon('fa-ban')
77
-
->setText(pht('Disable Board'))
78
-
->setHref($disable_uri)
79
-
->setDisabled(!$can_edit)
80
-
->setWorkflow(true);
88
+
$curtain->addAction(
89
+
id(new PhabricatorActionView())
90
+
->setIcon('fa-ban')
91
+
->setName(pht('Disable Workboard'))
92
+
->setHref($disable_uri)
93
+
->setDisabled(!$can_edit)
94
+
->setWorkflow(true));
81
95
82
-
$header = id(new PHUIHeaderView())
83
-
->setHeader(pht('Workboard: %s', $board->getDisplayName()))
84
-
->setUser($viewer)
85
-
->setProfileHeader(true)
86
-
->addActionLink($button);
87
-
88
-
return $header;
96
+
return $curtain;
89
97
}
90
98
91
99
private function buildColumnsList(
···
126
134
127
135
return id(new PHUIObjectBoxView())
128
136
->setHeaderText(pht('Columns'))
137
+
->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
129
138
->setObjectList($view);
130
139
}
131
140
+1
-2
src/applications/project/controller/PhabricatorProjectColumnDetailController.php
+1
-2
src/applications/project/controller/PhabricatorProjectColumnDetailController.php