@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Clean up some minor UI behaviors in Differential
Summary:
Minor UI tweaks:
- Use the dynamic icon for each file (e.g., image, text), not a hard-coded icon.
- Render the path (less important) in grey and the filename (more important) in black.
Test Plan: {F4966176}
Reviewers: chad
Reviewed By: chad
Differential Revision: https://secure.phabricator.com/D17957
+65
-38
+29
-29
resources/celerity/map.php
+29
-29
resources/celerity/map.php
···
9
9
'names' => array(
10
10
'conpherence.pkg.css' => 'ff161f2d',
11
11
'conpherence.pkg.js' => 'b5b51108',
12
-
'core.pkg.css' => 'd6dc3994',
12
+
'core.pkg.css' => '5ffe8b79',
13
13
'core.pkg.js' => 'e822b496',
14
14
'darkconsole.pkg.js' => '1f9a31bc',
15
-
'differential.pkg.css' => 'deae6388',
16
-
'differential.pkg.js' => 'dedee9c8',
15
+
'differential.pkg.css' => '4d7dd14e',
16
+
'differential.pkg.js' => '68a4fa60',
17
17
'diffusion.pkg.css' => 'b93d9b8c',
18
18
'diffusion.pkg.js' => '84c8f8fd',
19
19
'favicon.ico' => '30672e08',
···
64
64
'rsrc/css/application/dashboard/dashboard.css' => 'fe5b1869',
65
65
'rsrc/css/application/diff/inline-comment-summary.css' => '51efda3a',
66
66
'rsrc/css/application/differential/add-comment.css' => 'c47f8c40',
67
-
'rsrc/css/application/differential/changeset-view.css' => '6b79bdf3',
67
+
'rsrc/css/application/differential/changeset-view.css' => '54774a28',
68
68
'rsrc/css/application/differential/core.css' => '5b7b8ff4',
69
69
'rsrc/css/application/differential/phui-inline-comment.css' => 'ffd1a542',
70
70
'rsrc/css/application/differential/revision-comment.css' => '14b8565a',
···
116
116
'rsrc/css/core/core.css' => '9f4cb463',
117
117
'rsrc/css/core/remarkup.css' => 'd1a5e11e',
118
118
'rsrc/css/core/syntax.css' => 'cae95e89',
119
-
'rsrc/css/core/z-index.css' => '9d8f7c4b',
119
+
'rsrc/css/core/z-index.css' => '998f3ce1',
120
120
'rsrc/css/diviner/diviner-shared.css' => '896f1d43',
121
121
'rsrc/css/font/font-awesome.css' => 'e838e088',
122
122
'rsrc/css/font/font-lato.css' => 'c7ccd872',
···
390
390
'rsrc/js/application/dashboard/behavior-dashboard-move-panels.js' => '408bf173',
391
391
'rsrc/js/application/dashboard/behavior-dashboard-query-panel-select.js' => '453c5375',
392
392
'rsrc/js/application/dashboard/behavior-dashboard-tab-panel.js' => 'd4eecc63',
393
-
'rsrc/js/application/diff/DiffChangeset.js' => '20580ec0',
394
-
'rsrc/js/application/diff/DiffChangesetList.js' => '61086d73',
393
+
'rsrc/js/application/diff/DiffChangeset.js' => 'cf4e2140',
394
+
'rsrc/js/application/diff/DiffChangesetList.js' => '5c68c40c',
395
395
'rsrc/js/application/diff/DiffInline.js' => '77e14b60',
396
396
'rsrc/js/application/diff/ScrollObjective.js' => '0eee7a00',
397
397
'rsrc/js/application/diff/ScrollObjectiveList.js' => '1ca4d9db',
···
567
567
'conpherence-thread-manager' => '4d863052',
568
568
'conpherence-transaction-css' => '85129c68',
569
569
'd3' => 'a11a5ff2',
570
-
'differential-changeset-view-css' => '6b79bdf3',
570
+
'differential-changeset-view-css' => '54774a28',
571
571
'differential-core-view-css' => '5b7b8ff4',
572
572
'differential-revision-add-comment-css' => 'c47f8c40',
573
573
'differential-revision-comment-css' => '14b8565a',
···
777
777
'phabricator-darklog' => 'c8e1ffe3',
778
778
'phabricator-darkmessage' => 'c48cccdd',
779
779
'phabricator-dashboard-css' => 'fe5b1869',
780
-
'phabricator-diff-changeset' => '20580ec0',
781
-
'phabricator-diff-changeset-list' => '61086d73',
780
+
'phabricator-diff-changeset' => 'cf4e2140',
781
+
'phabricator-diff-changeset-list' => '5c68c40c',
782
782
'phabricator-diff-inline' => '77e14b60',
783
783
'phabricator-drag-and-drop-file-upload' => '58dea2fa',
784
784
'phabricator-draggable-list' => 'bea6e7f4',
···
820
820
'phabricator-uiexample-reactor-select' => 'a155550f',
821
821
'phabricator-uiexample-reactor-sendclass' => '1def2711',
822
822
'phabricator-uiexample-reactor-sendproperties' => 'b1f0ccee',
823
-
'phabricator-zindex-css' => '9d8f7c4b',
823
+
'phabricator-zindex-css' => '998f3ce1',
824
824
'phame-css' => 'b3a0b3a3',
825
825
'pholio-css' => 'ca89d380',
826
826
'pholio-edit-css' => '07676f51',
···
1070
1070
'javelin-install',
1071
1071
'javelin-dom',
1072
1072
),
1073
-
'20580ec0' => array(
1074
-
'javelin-dom',
1075
-
'javelin-util',
1076
-
'javelin-stratcom',
1077
-
'javelin-install',
1078
-
'javelin-workflow',
1079
-
'javelin-router',
1080
-
'javelin-behavior-device',
1081
-
'javelin-vector',
1082
-
'phabricator-diff-inline',
1083
-
),
1084
1073
'21df4ff5' => array(
1085
1074
'javelin-install',
1086
1075
'javelin-workboard-card',
···
1327
1316
'5294060f' => array(
1328
1317
'phui-theme-css',
1329
1318
),
1319
+
'54774a28' => array(
1320
+
'phui-inline-comment-view-css',
1321
+
),
1330
1322
'54b612ba' => array(
1331
1323
'javelin-color',
1332
1324
'javelin-install',
···
1375
1367
'javelin-behavior',
1376
1368
'javelin-stratcom',
1377
1369
'javelin-dom',
1370
+
),
1371
+
'5c68c40c' => array(
1372
+
'javelin-install',
1373
+
'phabricator-scroll-objective-list',
1378
1374
),
1379
1375
'5e2634b9' => array(
1380
1376
'javelin-behavior',
···
1407
1403
'javelin-stratcom',
1408
1404
'javelin-dom',
1409
1405
),
1410
-
'61086d73' => array(
1411
-
'javelin-install',
1412
-
'phabricator-scroll-objective-list',
1413
-
),
1414
1406
'61cbc29a' => array(
1415
1407
'javelin-magical-init',
1416
1408
'javelin-util',
···
1441
1433
'javelin-event',
1442
1434
'javelin-util',
1443
1435
'javelin-magical-init',
1444
-
),
1445
-
'6b79bdf3' => array(
1446
-
'phui-inline-comment-view-css',
1447
1436
),
1448
1437
'6b8ef10b' => array(
1449
1438
'javelin-install',
···
2012
2001
),
2013
2002
'cd2b9b77' => array(
2014
2003
'phui-oi-list-view-css',
2004
+
),
2005
+
'cf4e2140' => array(
2006
+
'javelin-dom',
2007
+
'javelin-util',
2008
+
'javelin-stratcom',
2009
+
'javelin-install',
2010
+
'javelin-workflow',
2011
+
'javelin-router',
2012
+
'javelin-behavior-device',
2013
+
'javelin-vector',
2014
+
'phabricator-diff-inline',
2015
2015
),
2016
2016
'd0c516d5' => array(
2017
2017
'javelin-behavior',
+22
-2
src/applications/differential/view/DifferentialChangesetDetailView.php
+22
-2
src/applications/differential/view/DifferentialChangesetDetailView.php
···
168
168
$right_id = $changeset_id;
169
169
}
170
170
171
+
// In the persistent banner, emphasize the current filename.
172
+
$path_part = dirname($display_filename);
173
+
$file_part = basename($display_filename);
174
+
$display_parts = array();
175
+
if (strlen($path_part)) {
176
+
$path_part = $path_part.'/';
177
+
$display_parts[] = phutil_tag(
178
+
'span',
179
+
array(
180
+
'class' => 'diff-banner-path',
181
+
),
182
+
$path_part);
183
+
}
184
+
$display_parts[] = phutil_tag(
185
+
'span',
186
+
array(
187
+
'class' => 'diff-banner-file',
188
+
),
189
+
$file_part);
190
+
171
191
return javelin_tag(
172
192
'div',
173
193
array(
···
183
203
'autoload' => $this->getAutoload(),
184
204
'loaded' => $this->getLoaded(),
185
205
'undoTemplates' => hsprintf('%s', $renderer->renderUndoTemplates()),
186
-
'path' => $display_filename,
206
+
'displayPath' => hsprintf('%s', $display_parts),
187
207
'objectiveName' => basename($display_filename),
188
-
'icon' => 'fa-file-text-o',
208
+
'icon' => $display_icon,
189
209
),
190
210
'class' => $class,
191
211
'id' => $id,
+4
-1
webroot/rsrc/css/application/differential/changeset-view.css
+4
-1
webroot/rsrc/css/application/differential/changeset-view.css
···
405
405
margin-right: 4px;
406
406
}
407
407
408
+
.diff-banner-path {
409
+
color: {$greytext};
410
+
}
411
+
408
412
.scroll-objective-list {
409
413
position: fixed;
410
414
right: 0;
411
415
width: 24px;
412
416
top: 48px;
413
417
bottom: 48px;
414
-
z-index: 6;
415
418
background: rgba(255, 255, 255, 0.50);
416
419
border-style: solid;
417
420
border-color: rgba(255, 255, 255, 0.95);
+4
webroot/rsrc/css/core/z-index.css
+4
webroot/rsrc/css/core/z-index.css
+4
-4
webroot/rsrc/js/application/diff/DiffChangeset.js
+4
-4
webroot/rsrc/js/application/diff/DiffChangeset.js
···
31
31
this._leftID = data.left;
32
32
this._rightID = data.right;
33
33
34
-
this._path = data.path;
34
+
this._displayPath = JX.$H(data.displayPath);
35
35
this._objectiveName = data.objectiveName;
36
36
this._icon = data.icon;
37
37
···
59
59
_visible: true,
60
60
61
61
_undoNode: null,
62
-
_path: null,
62
+
_displayPath: null,
63
63
64
64
_changesetList: null,
65
65
_objective: null,
···
277
277
JX.Router.getInstance().queue(routable);
278
278
},
279
279
280
-
getPath: function() {
281
-
return this._path;
280
+
getDisplayPath: function() {
281
+
return this._displayPath;
282
282
},
283
283
284
284
/**
+2
-2
webroot/rsrc/js/application/diff/DiffChangesetList.js
+2
-2
webroot/rsrc/js/application/diff/DiffChangesetList.js
···
1322
1322
}
1323
1323
1324
1324
var icon = new JX.PHUIXIconView()
1325
-
.setIcon('fa-file')
1325
+
.setIcon(changeset.getIcon())
1326
1326
.getNode();
1327
-
JX.DOM.setContent(node, [icon, ' ', changeset.getPath()]);
1327
+
JX.DOM.setContent(node, [icon, ' ', changeset.getDisplayPath()]);
1328
1328
1329
1329
document.body.appendChild(node);
1330
1330
},