recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Use shouldAllowPublic(), not shouldRequireLogin(), for Legalpad

Summary: This got written a while ago and is using slightly incorrect gating on logged-out users. The names of these methods should probably be more clear too, but basically "shouldAllowPublic()" is for "this page may be usable to logged-out users, if policies allow it", while "shouldRequireLogin()" is for "this page should skip various credential checks". One of the skipped checks is email verification. This method should maybe be something like "isAuthenticationRelatedOrNoncredentialPage()" but I don't have a good name for that.

Test Plan: Unverified users are now prompted to verify email when viewing a legalpad document, instead of allowed to sign it.

Reviewers: rush898, chad

Reviewed By: chad

Subscribers: epriestley

Differential Revision: https://secure.phabricator.com/D9857

epriestley fe29db6b a89ce7e9

+2 -2
+1 -1
src/applications/legalpad/controller/LegalpadDocumentDoneController.php
··· 2 2 3 3 final class LegalpadDocumentDoneController extends LegalpadController { 4 4 5 - public function shouldRequireLogin() { 5 + public function shouldAllowPublic() { 6 6 return false; 7 7 } 8 8
+1 -1
src/applications/legalpad/controller/LegalpadDocumentSignController.php
··· 4 4 5 5 private $id; 6 6 7 - public function shouldRequireLogin() { 7 + public function shouldAllowPublic() { 8 8 return false; 9 9 } 10 10