recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Update Form Layouts

Summary:
This attempts some consistency in form layouts. Notably, they all now contain headers and are 16px off the sides and tops of pages. Also updated dialogs to the same look and feel. I think I got 98% of forms with this pass, but it's likely I missed some buried somewhere.

TODO: will take another pass as consolidating these colors and new gradients in another diff.

Test Plan: Played in my sandbox all week. Please play with it too and let me know how they feel.

Reviewers: epriestley, btrahan

Reviewed By: epriestley

CC: Korvin, aran

Differential Revision: https://secure.phabricator.com/D6806

Chad Little fe2a96e3 320498d3

+633 -589
resources/sprite/gradients/lightblue-header.png

This is a binary file and will not be displayed.

+5
resources/sprite/manifest/gradient.json
··· 31 31 "rule" : ".gradient-grey-header", 32 32 "hash" : "1c8f8d61984e3fc5a7e528b9bd4d484a" 33 33 }, 34 + "gradient-lightblue-header" : { 35 + "name" : "gradient-lightblue-header", 36 + "rule" : ".gradient-lightblue-header", 37 + "hash" : "b838d2eb15f9b620e82b4da240bf464a" 38 + }, 34 39 "gradient-menu-label" : { 35 40 "name" : "gradient-menu-label", 36 41 "rule" : ".gradient-menu-label, .phabricator-side-menu .phui-list-item-type-label",
+1 -2
scripts/celerity_mapper.php
··· 70 70 'phui-button-css', 71 71 'phabricator-standard-page-view', 72 72 'aphront-dialog-view-css', 73 - 'aphront-form-view-css', 73 + 'phui-form-view-css', 74 74 'aphront-panel-view-css', 75 75 'aphront-table-view-css', 76 76 'aphront-tokenizer-control-css', ··· 97 97 'phabricator-notification-menu-css', 98 98 'lightbox-attachment-css', 99 99 'phabricator-header-view-css', 100 - 'phabricator-form-view-css', 101 100 'phabricator-filetree-view-css', 102 101 'phabricator-nav-view-css', 103 102 'phabricator-side-menu-view-css',
+81 -92
src/__celerity_resource_map__.php
··· 632 632 ), 633 633 '/rsrc/image/sprite-gradient.png' => 634 634 array( 635 - 'hash' => 'a49d2e493dba4bea85bb202af528106a', 636 - 'uri' => '/res/a49d2e49/rsrc/image/sprite-gradient.png', 635 + 'hash' => 'c6c42387e625948e683d9d8c62ea1b7f', 636 + 'uri' => '/res/c6c42387/rsrc/image/sprite-gradient.png', 637 637 'disk' => '/rsrc/image/sprite-gradient.png', 638 638 'type' => 'png', 639 639 ), ··· 836 836 ), 837 837 'aphront-dialog-view-css' => 838 838 array( 839 - 'uri' => '/res/29a054fd/rsrc/css/aphront/dialog-view.css', 839 + 'uri' => '/res/c7a7e179/rsrc/css/aphront/dialog-view.css', 840 840 'type' => 'css', 841 841 'requires' => 842 842 array( ··· 845 845 ), 846 846 'aphront-error-view-css' => 847 847 array( 848 - 'uri' => '/res/e2bb50c4/rsrc/css/aphront/error-view.css', 848 + 'uri' => '/res/4ba306a0/rsrc/css/aphront/error-view.css', 849 849 'type' => 'css', 850 850 'requires' => 851 851 array( 852 852 ), 853 853 'disk' => '/rsrc/css/aphront/error-view.css', 854 854 ), 855 - 'aphront-form-view-css' => 856 - array( 857 - 'uri' => '/res/1be2545a/rsrc/css/aphront/form-view.css', 858 - 'type' => 'css', 859 - 'requires' => 860 - array( 861 - ), 862 - 'disk' => '/rsrc/css/aphront/form-view.css', 863 - ), 864 855 'aphront-list-filter-view-css' => 865 856 array( 866 - 'uri' => '/res/a90a0c94/rsrc/css/aphront/list-filter-view.css', 857 + 'uri' => '/res/9fd0aae6/rsrc/css/aphront/list-filter-view.css', 867 858 'type' => 'css', 868 859 'requires' => 869 860 array( ··· 899 890 ), 900 891 'aphront-panel-view-css' => 901 892 array( 902 - 'uri' => '/res/f55024c3/rsrc/css/aphront/panel-view.css', 893 + 'uri' => '/res/e19deae5/rsrc/css/aphront/panel-view.css', 903 894 'type' => 'css', 904 895 'requires' => 905 896 array( ··· 990 981 ), 991 982 'conpherence-message-pane-css' => 992 983 array( 993 - 'uri' => '/res/80cde760/rsrc/css/application/conpherence/message-pane.css', 984 + 'uri' => '/res/4f3bfae5/rsrc/css/application/conpherence/message-pane.css', 994 985 'type' => 'css', 995 986 'requires' => 996 987 array( ··· 2178 2169 ), 2179 2170 'javelin-behavior-phabricator-transaction-list' => 2180 2171 array( 2181 - 'uri' => '/res/db441ac4/rsrc/js/application/transactions/behavior-transaction-list.js', 2172 + 'uri' => '/res/f05b3c6b/rsrc/js/application/transactions/behavior-transaction-list.js', 2182 2173 'type' => 'js', 2183 2174 'requires' => 2184 2175 array( ··· 3063 3054 ), 3064 3055 'phabricator-core-css' => 3065 3056 array( 3066 - 'uri' => '/res/bb4b77f3/rsrc/css/core/core.css', 3057 + 'uri' => '/res/9e767fb1/rsrc/css/core/core.css', 3067 3058 'type' => 'css', 3068 3059 'requires' => 3069 3060 array( ··· 3181 3172 ), 3182 3173 'disk' => '/rsrc/css/application/flag/flag.css', 3183 3174 ), 3184 - 'phabricator-form-view-css' => 3185 - array( 3186 - 'uri' => '/res/ba05f8ba/rsrc/css/layout/phabricator-form-view.css', 3187 - 'type' => 'css', 3188 - 'requires' => 3189 - array( 3190 - ), 3191 - 'disk' => '/rsrc/css/layout/phabricator-form-view.css', 3192 - ), 3193 3175 'phabricator-header-view-css' => 3194 3176 array( 3195 3177 'uri' => '/res/da35cfa0/rsrc/css/layout/phabricator-header-view.css', ··· 3404 3386 ), 3405 3387 'phabricator-remarkup-css' => 3406 3388 array( 3407 - 'uri' => '/res/8531b6a1/rsrc/css/core/remarkup.css', 3389 + 'uri' => '/res/d0af3cab/rsrc/css/core/remarkup.css', 3408 3390 'type' => 'css', 3409 3391 'requires' => 3410 3392 array( ··· 3443 3425 ), 3444 3426 'phabricator-side-menu-view-css' => 3445 3427 array( 3446 - 'uri' => '/res/f43a8365/rsrc/css/layout/phabricator-side-menu-view.css', 3428 + 'uri' => '/res/e83fbe58/rsrc/css/layout/phabricator-side-menu-view.css', 3447 3429 'type' => 'css', 3448 3430 'requires' => 3449 3431 array( ··· 3766 3748 ), 3767 3749 'phui-box-css' => 3768 3750 array( 3769 - 'uri' => '/res/1b741073/rsrc/css/phui/phui-box.css', 3751 + 'uri' => '/res/8244305c/rsrc/css/phui/phui-box.css', 3770 3752 'type' => 'css', 3771 3753 'requires' => 3772 3754 array( ··· 3802 3784 ), 3803 3785 'phui-form-css' => 3804 3786 array( 3805 - 'uri' => '/res/c02b6db7/rsrc/css/phui/phui-form.css', 3787 + 'uri' => '/res/8f33e95f/rsrc/css/phui/phui-form.css', 3806 3788 'type' => 'css', 3807 3789 'requires' => 3808 3790 array( 3809 3791 ), 3810 3792 'disk' => '/rsrc/css/phui/phui-form.css', 3811 3793 ), 3794 + 'phui-form-view-css' => 3795 + array( 3796 + 'uri' => '/res/52025834/rsrc/css/phui/phui-form-view.css', 3797 + 'type' => 'css', 3798 + 'requires' => 3799 + array( 3800 + ), 3801 + 'disk' => '/rsrc/css/phui/phui-form-view.css', 3802 + ), 3812 3803 'phui-icon-view-css' => 3813 3804 array( 3814 3805 'uri' => '/res/f78f4c64/rsrc/css/phui/phui-icon.css', ··· 3838 3829 ), 3839 3830 'phui-remarkup-preview-css' => 3840 3831 array( 3841 - 'uri' => '/res/4535e062/rsrc/css/phui/phui-remarkup-preview.css', 3832 + 'uri' => '/res/3cba9fbc/rsrc/css/phui/phui-remarkup-preview.css', 3842 3833 'type' => 'css', 3843 3834 'requires' => 3844 3835 array( ··· 4081 4072 ), 4082 4073 'sprite-gradient-css' => 4083 4074 array( 4084 - 'uri' => '/res/af8d50a1/rsrc/css/sprite-gradient.css', 4075 + 'uri' => '/res/08c64fb3/rsrc/css/sprite-gradient.css', 4085 4076 'type' => 'css', 4086 4077 'requires' => 4087 4078 array( ··· 4172 4163 ), array( 4173 4164 'packages' => 4174 4165 array( 4175 - '4a060444' => 4166 + '4c072d06' => 4176 4167 array( 4177 4168 'name' => 'core.pkg.css', 4178 4169 'symbols' => ··· 4182 4173 2 => 'phui-button-css', 4183 4174 3 => 'phabricator-standard-page-view', 4184 4175 4 => 'aphront-dialog-view-css', 4185 - 5 => 'aphront-form-view-css', 4176 + 5 => 'phui-form-view-css', 4186 4177 6 => 'aphront-panel-view-css', 4187 4178 7 => 'aphront-table-view-css', 4188 4179 8 => 'aphront-tokenizer-control-css', ··· 4205 4196 25 => 'phabricator-notification-menu-css', 4206 4197 26 => 'lightbox-attachment-css', 4207 4198 27 => 'phabricator-header-view-css', 4208 - 28 => 'phabricator-form-view-css', 4209 - 29 => 'phabricator-filetree-view-css', 4210 - 30 => 'phabricator-nav-view-css', 4211 - 31 => 'phabricator-side-menu-view-css', 4212 - 32 => 'phabricator-crumbs-view-css', 4213 - 33 => 'phabricator-object-item-list-view-css', 4214 - 34 => 'global-drag-and-drop-css', 4215 - 35 => 'phui-spacing-css', 4216 - 36 => 'phui-form-css', 4217 - 37 => 'phui-icon-view-css', 4218 - 38 => 'phabricator-application-launch-view-css', 4219 - 39 => 'phabricator-action-list-view-css', 4220 - 40 => 'phabricator-property-list-view-css', 4221 - 41 => 'phabricator-tag-view-css', 4199 + 28 => 'phabricator-filetree-view-css', 4200 + 29 => 'phabricator-nav-view-css', 4201 + 30 => 'phabricator-side-menu-view-css', 4202 + 31 => 'phabricator-crumbs-view-css', 4203 + 32 => 'phabricator-object-item-list-view-css', 4204 + 33 => 'global-drag-and-drop-css', 4205 + 34 => 'phui-spacing-css', 4206 + 35 => 'phui-form-css', 4207 + 36 => 'phui-icon-view-css', 4208 + 37 => 'phabricator-application-launch-view-css', 4209 + 38 => 'phabricator-action-list-view-css', 4210 + 39 => 'phabricator-property-list-view-css', 4211 + 40 => 'phabricator-tag-view-css', 4222 4212 ), 4223 - 'uri' => '/res/pkg/4a060444/core.pkg.css', 4213 + 'uri' => '/res/pkg/4c072d06/core.pkg.css', 4224 4214 'type' => 'css', 4225 4215 ), 4226 4216 '4f81c788' => ··· 4411 4401 ), 4412 4402 'reverse' => 4413 4403 array( 4414 - 'aphront-dialog-view-css' => '4a060444', 4415 - 'aphront-error-view-css' => '4a060444', 4416 - 'aphront-form-view-css' => '4a060444', 4417 - 'aphront-list-filter-view-css' => '4a060444', 4418 - 'aphront-pager-view-css' => '4a060444', 4419 - 'aphront-panel-view-css' => '4a060444', 4420 - 'aphront-table-view-css' => '4a060444', 4421 - 'aphront-tokenizer-control-css' => '4a060444', 4422 - 'aphront-tooltip-css' => '4a060444', 4423 - 'aphront-typeahead-control-css' => '4a060444', 4404 + 'aphront-dialog-view-css' => '4c072d06', 4405 + 'aphront-error-view-css' => '4c072d06', 4406 + 'aphront-list-filter-view-css' => '4c072d06', 4407 + 'aphront-pager-view-css' => '4c072d06', 4408 + 'aphront-panel-view-css' => '4c072d06', 4409 + 'aphront-table-view-css' => '4c072d06', 4410 + 'aphront-tokenizer-control-css' => '4c072d06', 4411 + 'aphront-tooltip-css' => '4c072d06', 4412 + 'aphront-typeahead-control-css' => '4c072d06', 4424 4413 'differential-changeset-view-css' => '09216861', 4425 4414 'differential-core-view-css' => '09216861', 4426 4415 'differential-inline-comment-editor' => 'd07a3bc2', ··· 4434 4423 'differential-table-of-contents-css' => '09216861', 4435 4424 'diffusion-commit-view-css' => 'c8ce2d88', 4436 4425 'diffusion-icons-css' => 'c8ce2d88', 4437 - 'global-drag-and-drop-css' => '4a060444', 4426 + 'global-drag-and-drop-css' => '4c072d06', 4438 4427 'inline-comment-summary-css' => '09216861', 4439 4428 'javelin-aphlict' => '4f81c788', 4440 4429 'javelin-behavior' => '2dbbb7d1', ··· 4507 4496 'javelin-util' => '2dbbb7d1', 4508 4497 'javelin-vector' => '2dbbb7d1', 4509 4498 'javelin-workflow' => '2dbbb7d1', 4510 - 'lightbox-attachment-css' => '4a060444', 4499 + 'lightbox-attachment-css' => '4c072d06', 4511 4500 'maniphest-task-summary-css' => '06bacb9a', 4512 4501 'maniphest-transaction-detail-css' => '06bacb9a', 4513 - 'phabricator-action-list-view-css' => '4a060444', 4514 - 'phabricator-application-launch-view-css' => '4a060444', 4502 + 'phabricator-action-list-view-css' => '4c072d06', 4503 + 'phabricator-application-launch-view-css' => '4c072d06', 4515 4504 'phabricator-busy' => '4f81c788', 4516 4505 'phabricator-content-source-view-css' => '09216861', 4517 - 'phabricator-core-css' => '4a060444', 4518 - 'phabricator-crumbs-view-css' => '4a060444', 4506 + 'phabricator-core-css' => '4c072d06', 4507 + 'phabricator-crumbs-view-css' => '4c072d06', 4519 4508 'phabricator-drag-and-drop-file-upload' => 'd07a3bc2', 4520 4509 'phabricator-dropdown-menu' => '4f81c788', 4521 4510 'phabricator-file-upload' => '4f81c788', 4522 - 'phabricator-filetree-view-css' => '4a060444', 4523 - 'phabricator-flag-css' => '4a060444', 4524 - 'phabricator-form-view-css' => '4a060444', 4525 - 'phabricator-header-view-css' => '4a060444', 4511 + 'phabricator-filetree-view-css' => '4c072d06', 4512 + 'phabricator-flag-css' => '4c072d06', 4513 + 'phabricator-header-view-css' => '4c072d06', 4526 4514 'phabricator-hovercard' => '4f81c788', 4527 - 'phabricator-jump-nav' => '4a060444', 4515 + 'phabricator-jump-nav' => '4c072d06', 4528 4516 'phabricator-keyboard-shortcut' => '4f81c788', 4529 4517 'phabricator-keyboard-shortcut-manager' => '4f81c788', 4530 - 'phabricator-main-menu-view' => '4a060444', 4518 + 'phabricator-main-menu-view' => '4c072d06', 4531 4519 'phabricator-menu-item' => '4f81c788', 4532 - 'phabricator-nav-view-css' => '4a060444', 4520 + 'phabricator-nav-view-css' => '4c072d06', 4533 4521 'phabricator-notification' => '4f81c788', 4534 - 'phabricator-notification-css' => '4a060444', 4535 - 'phabricator-notification-menu-css' => '4a060444', 4536 - 'phabricator-object-item-list-view-css' => '4a060444', 4522 + 'phabricator-notification-css' => '4c072d06', 4523 + 'phabricator-notification-menu-css' => '4c072d06', 4524 + 'phabricator-object-item-list-view-css' => '4c072d06', 4537 4525 'phabricator-object-selector-css' => '09216861', 4538 4526 'phabricator-phtize' => '4f81c788', 4539 4527 'phabricator-prefab' => '4f81c788', 4540 4528 'phabricator-project-tag-css' => '06bacb9a', 4541 - 'phabricator-property-list-view-css' => '4a060444', 4542 - 'phabricator-remarkup-css' => '4a060444', 4529 + 'phabricator-property-list-view-css' => '4c072d06', 4530 + 'phabricator-remarkup-css' => '4c072d06', 4543 4531 'phabricator-shaped-request' => 'd07a3bc2', 4544 - 'phabricator-side-menu-view-css' => '4a060444', 4545 - 'phabricator-standard-page-view' => '4a060444', 4546 - 'phabricator-tag-view-css' => '4a060444', 4532 + 'phabricator-side-menu-view-css' => '4c072d06', 4533 + 'phabricator-standard-page-view' => '4c072d06', 4534 + 'phabricator-tag-view-css' => '4c072d06', 4547 4535 'phabricator-textareautils' => '4f81c788', 4548 4536 'phabricator-tooltip' => '4f81c788', 4549 - 'phabricator-transaction-view-css' => '4a060444', 4550 - 'phabricator-zindex-css' => '4a060444', 4551 - 'phui-button-css' => '4a060444', 4552 - 'phui-form-css' => '4a060444', 4553 - 'phui-icon-view-css' => '4a060444', 4554 - 'phui-spacing-css' => '4a060444', 4555 - 'sprite-apps-large-css' => '4a060444', 4556 - 'sprite-gradient-css' => '4a060444', 4557 - 'sprite-icons-css' => '4a060444', 4558 - 'sprite-menu-css' => '4a060444', 4559 - 'syntax-highlighting-css' => '4a060444', 4537 + 'phabricator-transaction-view-css' => '4c072d06', 4538 + 'phabricator-zindex-css' => '4c072d06', 4539 + 'phui-button-css' => '4c072d06', 4540 + 'phui-form-css' => '4c072d06', 4541 + 'phui-form-view-css' => '4c072d06', 4542 + 'phui-icon-view-css' => '4c072d06', 4543 + 'phui-spacing-css' => '4c072d06', 4544 + 'sprite-apps-large-css' => '4c072d06', 4545 + 'sprite-gradient-css' => '4c072d06', 4546 + 'sprite-icons-css' => '4c072d06', 4547 + 'sprite-menu-css' => '4c072d06', 4548 + 'syntax-highlighting-css' => '4c072d06', 4560 4549 ), 4561 4550 ));
+4 -2
src/__phutil_library_map__.php
··· 38 38 'AphrontFormFileControl' => 'view/form/control/AphrontFormFileControl.php', 39 39 'AphrontFormImageControl' => 'view/form/control/AphrontFormImageControl.php', 40 40 'AphrontFormInsetView' => 'view/form/AphrontFormInsetView.php', 41 - 'AphrontFormLayoutView' => 'view/form/AphrontFormLayoutView.php', 42 41 'AphrontFormMarkupControl' => 'view/form/control/AphrontFormMarkupControl.php', 43 42 'AphrontFormPasswordControl' => 'view/form/control/AphrontFormPasswordControl.php', 44 43 'AphrontFormPolicyControl' => 'view/form/control/AphrontFormPolicyControl.php', ··· 737 736 'PHUIDocumentView' => 'view/phui/PHUIDocumentView.php', 738 737 'PHUIFeedStoryExample' => 'applications/uiexample/examples/PHUIFeedStoryExample.php', 739 738 'PHUIFeedStoryView' => 'view/phui/PHUIFeedStoryView.php', 739 + 'PHUIFormBoxView' => 'view/form/PHUIFormBoxView.php', 740 740 'PHUIFormDividerControl' => 'view/form/control/PHUIFormDividerControl.php', 741 741 'PHUIFormFreeformDateControl' => 'view/form/control/PHUIFormFreeformDateControl.php', 742 + 'PHUIFormLayoutView' => 'view/form/PHUIFormLayoutView.php', 742 743 'PHUIFormMultiSubmitControl' => 'view/form/control/PHUIFormMultiSubmitControl.php', 743 744 'PHUIFormPageView' => 'view/form/PHUIFormPageView.php', 744 745 'PHUIIconExample' => 'applications/uiexample/examples/PHUIIconExample.php', ··· 2069 2070 'AphrontFormFileControl' => 'AphrontFormControl', 2070 2071 'AphrontFormImageControl' => 'AphrontFormControl', 2071 2072 'AphrontFormInsetView' => 'AphrontView', 2072 - 'AphrontFormLayoutView' => 'AphrontView', 2073 2073 'AphrontFormMarkupControl' => 'AphrontFormControl', 2074 2074 'AphrontFormPasswordControl' => 'AphrontFormControl', 2075 2075 'AphrontFormPolicyControl' => 'AphrontFormControl', ··· 2774 2774 'PHUIDocumentView' => 'AphrontTagView', 2775 2775 'PHUIFeedStoryExample' => 'PhabricatorUIExample', 2776 2776 'PHUIFeedStoryView' => 'AphrontView', 2777 + 'PHUIFormBoxView' => 'AphrontView', 2777 2778 'PHUIFormDividerControl' => 'AphrontFormControl', 2778 2779 'PHUIFormFreeformDateControl' => 'AphrontFormControl', 2780 + 'PHUIFormLayoutView' => 'AphrontView', 2779 2781 'PHUIFormMultiSubmitControl' => 'AphrontFormControl', 2780 2782 'PHUIFormPageView' => 'AphrontView', 2781 2783 'PHUIIconExample' => 'PhabricatorUIExample',
-1
src/applications/audit/controller/PhabricatorAuditListController.php
··· 87 87 88 88 $form = new AphrontFormView(); 89 89 $form->setUser($user); 90 - $form->setNoShading(true); 91 90 92 91 $show_status = false; 93 92 $show_user = false;
+1 -1
src/applications/auth/controller/PhabricatorAuthConfirmLinkController.php
··· 49 49 ->addCancelButton($panel_uri) 50 50 ->addSubmitButton(pht('Confirm Account Link')); 51 51 52 - $form = id(new AphrontFormLayoutView()) 52 + $form = id(new PHUIFormLayoutView()) 53 53 ->setFullWidth(true) 54 54 ->appendChild( 55 55 phutil_tag(
+1 -1
src/applications/auth/controller/PhabricatorEmailLoginController.php
··· 116 116 $error_view->setErrors($errors); 117 117 } 118 118 119 - $email_auth = new AphrontFormLayoutView(); 119 + $email_auth = new PHUIFormLayoutView(); 120 120 $email_auth->appendChild($error_view); 121 121 $email_auth 122 122 ->setUser($request->getUser())
-4
src/applications/auth/controller/PhabricatorEmailVerificationController.php
··· 24 24 $user->getPHID(), 25 25 $this->code); 26 26 27 - $color = PhabricatorActionHeaderView::HEADER_DARK_GREY; 28 - 29 27 if (!$email) { 30 28 $title = pht('Unable to Verify Email'); 31 29 $content = pht( ··· 33 31 'address has been removed, or the email address is owned by another '. 34 32 'user. Make sure you followed the link in the email correctly and are '. 35 33 'logged in with the user account associated with the email address.'); 36 - $color = PhabricatorActionHeaderView::HEADER_RED; 37 34 $continue = pht('Rats!'); 38 35 } else if ($email->getIsVerified()) { 39 36 $title = pht('Address Already Verified'); ··· 56 53 $dialog = id(new AphrontDialogView()) 57 54 ->setUser($user) 58 55 ->setTitle($title) 59 - ->setHeaderColor($color) 60 56 ->setMethod('GET') 61 57 ->addCancelButton('/', $continue) 62 58 ->appendChild($content);
+6 -3
src/applications/auth/controller/config/PhabricatorAuthEditController.php
··· 202 202 203 203 $form = id(new AphrontFormView()) 204 204 ->setUser($viewer) 205 - ->setFlexible(true) 206 205 ->appendChild( 207 206 id(new AphrontFormStaticControl()) 208 207 ->setLabel(pht('Provider')) ··· 270 269 ->setTransactions($xactions); 271 270 } 272 271 272 + $form_box = id(new PHUIFormBoxView()) 273 + ->setHeaderText($title) 274 + ->setFormError($errors) 275 + ->setForm($form); 276 + 273 277 return $this->buildApplicationPage( 274 278 array( 275 279 $crumbs, 276 - $errors, 277 - $form, 280 + $form_box, 278 281 $xaction_view, 279 282 ), 280 283 array(
+5 -2
src/applications/auth/controller/config/PhabricatorAuthNewController.php
··· 81 81 ->addCancelButton($this->getApplicationURI()) 82 82 ->setValue(pht('Continue'))); 83 83 84 + $form_box = id(new PHUIFormBoxView()) 85 + ->setHeaderText(pht('Add Authentication Provider')) 86 + ->setFormError($errors) 87 + ->setForm($form); 84 88 85 89 $crumbs = $this->buildApplicationCrumbs(); 86 90 $crumbs->addCrumb( ··· 90 94 return $this->buildApplicationPage( 91 95 array( 92 96 $crumbs, 93 - $errors, 94 - $form, 97 + $form_box, 95 98 ), 96 99 array( 97 100 'title' => pht('Add Authentication Provider'),
+1 -1
src/applications/auth/provider/PhabricatorAuthProviderLDAP.php
··· 104 104 $errors[] = pht('Username or password are incorrect.'); 105 105 } 106 106 107 - $form = id(new AphrontFormLayoutView()) 107 + $form = id(new PHUIFormLayoutView()) 108 108 ->setUser($viewer) 109 109 ->setFullWidth(true) 110 110 ->appendChild(
+1 -1
src/applications/auth/provider/PhabricatorAuthProviderPassword.php
··· 115 115 $errors = id(new AphrontErrorView())->setErrors($errors); 116 116 } 117 117 118 - $form = id(new AphrontFormLayoutView()) 118 + $form = id(new PHUIFormLayoutView()) 119 119 ->setFullWidth(true) 120 120 ->appendChild($errors) 121 121 ->appendChild(
+8 -6
src/applications/calendar/controller/PhabricatorCalendarEditStatusController.php
··· 126 126 $dialog->setSubmitURI( 127 127 $this->getApplicationURI('status/edit/'.$status->getID().'/')); 128 128 } 129 - $form = new AphrontFormLayoutView(); 129 + $form = new PHUIFormLayoutView(); 130 130 if ($error_view) { 131 131 $form->appendChild($error_view); 132 132 } 133 133 } else { 134 134 $form = id(new AphrontFormView()) 135 - ->setUser($user) 136 - ->setFlexible(true); 135 + ->setUser($user); 137 136 } 138 137 139 138 $form ··· 164 163 } 165 164 $form->appendChild($submit); 166 165 166 + $form_box = id(new PHUIFormBoxView()) 167 + ->setHeaderText($page_title) 168 + ->setFormError($error_view) 169 + ->setForm($form); 170 + 167 171 $nav = $this->buildSideNavView($status); 168 172 $nav->selectFilter($filter); 169 173 170 174 $nav->appendChild( 171 175 array( 172 - id(new PhabricatorHeaderView())->setHeader($page_title), 173 - $error_view, 174 - $form, 176 + $form_box, 175 177 )); 176 178 177 179 return $this->buildApplicationPage(
-1
src/applications/chatlog/controller/PhabricatorChatLogChannelLogController.php
··· 150 150 ->setUser($user) 151 151 ->setMethod('GET') 152 152 ->setAction($uri) 153 - ->setNoShading(true) 154 153 ->appendChild( 155 154 id(new AphrontFormTextControl()) 156 155 ->setLabel(pht('Date'))
-1
src/applications/conduit/controller/PhabricatorConduitConsoleController.php
··· 69 69 ->setUser($request->getUser()) 70 70 ->setAction('/api/'.$this->method) 71 71 ->addHiddenInput('allowEmptyParams', 1) 72 - ->setFlexible(true) 73 72 ->appendChild( 74 73 id(new AphrontFormStaticControl()) 75 74 ->setLabel('Description')
+6 -5
src/applications/config/controller/PhabricatorConfigEditController.php
··· 98 98 } 99 99 100 100 $form = new AphrontFormView(); 101 - $form->setFlexible(true); 102 101 103 102 $error_view = null; 104 103 if ($errors) { ··· 194 193 $title = pht('Edit %s', $this->key); 195 194 $short = pht('Edit'); 196 195 196 + $form_box = id(new PHUIFormBoxView()) 197 + ->setHeaderText($title) 198 + ->setFormError($error_view) 199 + ->setForm($form); 200 + 197 201 $crumbs = $this->buildApplicationCrumbs(); 198 202 $crumbs->addCrumb( 199 203 id(new PhabricatorCrumbView()) ··· 212 216 ->setName($this->key) 213 217 ->setHref('/config/edit/'.$this->key)); 214 218 215 - 216 219 $xactions = id(new PhabricatorConfigTransactionQuery()) 217 220 ->withObjectPHIDs(array($config_entry->getPHID())) 218 221 ->setViewer($user) ··· 226 229 return $this->buildApplicationPage( 227 230 array( 228 231 $crumbs, 229 - id(new PhabricatorHeaderView())->setHeader($title), 230 - $error_view, 231 - $form, 232 + $form_box, 232 233 $xaction_view, 233 234 ), 234 235 array(
+1 -1
src/applications/conpherence/controller/ConpherenceNewController.php
··· 74 74 ->addCancelButton($cancel_uri) 75 75 ->addSubmitButton(pht('Send Message')); 76 76 77 - $form = id(new AphrontFormLayoutView()) 77 + $form = id(new PHUIFormLayoutView()) 78 78 ->setUser($user) 79 79 ->setFullWidth(true) 80 80 ->appendChild(
+2 -3
src/applications/conpherence/controller/ConpherenceUpdateController.php
··· 181 181 $user = $request->getUser(); 182 182 $add_person = $request->getStr('add_person'); 183 183 184 - $form = id(new AphrontFormLayoutView()) 184 + $form = id(new PHUIFormLayoutView()) 185 185 ->setUser($user) 186 186 ->setFullWidth(true) 187 187 ->appendChild( ··· 222 222 require_celerity_resource('conpherence-update-css'); 223 223 return id(new AphrontDialogView()) 224 224 ->setTitle(pht('Remove Participants')) 225 - ->setHeaderColor(PhabricatorActionHeaderView::HEADER_RED) 226 225 ->addHiddenInput('action', 'remove_person') 227 226 ->addHiddenInput('__continue__', true) 228 227 ->addHiddenInput('remove_person', $remove_person) ··· 233 232 ConpherenceThread $conpherence, 234 233 $error_view) { 235 234 236 - $form = id(new AphrontFormLayoutView()) 235 + $form = id(new PHUIFormLayoutView()) 237 236 ->appendChild($error_view) 238 237 ->appendChild( 239 238 id(new AphrontFormTextControl())
-1
src/applications/conpherence/controller/ConpherenceViewController.php
··· 137 137 $form = 138 138 id(new AphrontFormView()) 139 139 ->setAction($update_uri) 140 - ->setFlexible(true) 141 140 ->addSigil('conpherence-pontificate') 142 141 ->setWorkflow(true) 143 142 ->setUser($user)
+8 -4
src/applications/countdown/controller/PhabricatorCountdownEditController.php
··· 17 17 $user = $request->getUser(); 18 18 19 19 if ($this->id) { 20 + $page_title = pht('Edit Countdown'); 20 21 $countdown = id(new PhabricatorCountdownQuery()) 21 22 ->setViewer($user) 22 23 ->withIDs(array($this->id)) ··· 32 33 return new Aphront404Response(); 33 34 } 34 35 } else { 36 + $page_title = pht('Create Countdown'); 35 37 $countdown = new PhabricatorCountdown(); 36 38 $countdown->setEpoch(time()); 37 39 } ··· 108 110 $form = id(new AphrontFormView()) 109 111 ->setUser($user) 110 112 ->setAction($request->getRequestURI()->getPath()) 111 - ->setFlexible(true) 112 113 ->appendChild( 113 114 id(new AphrontFormTextControl()) 114 115 ->setLabel(pht('Title')) ··· 127 128 ->addCancelButton($cancel_uri) 128 129 ->setValue($submit_label)); 129 130 131 + $form_box = id(new PHUIFormBoxView()) 132 + ->setHeaderText($page_title) 133 + ->setFormError($error_view) 134 + ->setForm($form); 130 135 131 136 return $this->buildApplicationPage( 132 137 array( 133 138 $crumbs, 134 - $error_view, 135 - $form, 139 + $form_box, 136 140 ), 137 141 array( 138 - 'title' => pht('Edit Countdown'), 142 + 'title' => $page_title, 139 143 'device' => true, 140 144 )); 141 145 }
+6 -3
src/applications/differential/controller/DifferentialDiffCreateController.php
··· 41 41 } 42 42 43 43 $form = new AphrontFormView(); 44 - $form->setFlexible(true); 45 44 $arcanist_href = PhabricatorEnv::getDoclink( 46 45 'article/Arcanist_User_Guide.html'); 47 46 $arcanist_link = phutil_tag( ··· 83 82 ->addCancelButton($cancel_uri) 84 83 ->setValue(pht("Create Diff"))); 85 84 85 + $form_box = id(new PHUIFormBoxView()) 86 + ->setHeaderText(pht('Create New Diff')) 87 + ->setFormError($errors) 88 + ->setForm($form); 89 + 86 90 $crumbs = $this->buildApplicationCrumbs(); 87 91 $crumbs->addCrumb( 88 92 id(new PhabricatorCrumbView()) ··· 96 100 return $this->buildApplicationPage( 97 101 array( 98 102 $crumbs, 99 - $errors, 100 - $form 103 + $form_box, 101 104 ), 102 105 array( 103 106 'title' => pht('Create Diff'),
-1
src/applications/differential/controller/DifferentialDiffViewController.php
··· 72 72 ->setAction('/differential/revision/edit/') 73 73 ->addHiddenInput('diffID', $diff->getID()) 74 74 ->addHiddenInput('viaDiffView', 1) 75 - ->setFlexible(true) 76 75 ->appendRemarkupInstructions( 77 76 pht( 78 77 'Review the diff for correctness. When you are satisfied, either '.
-1
src/applications/differential/controller/DifferentialRevisionEditController.php
··· 114 114 115 115 $form = new AphrontFormView(); 116 116 $form->setUser($request->getUser()); 117 - $form->setFlexible(true); 118 117 if ($diff) { 119 118 $form->addHiddenInput('diffID', $diff->getID()); 120 119 }
+1 -1
src/applications/differential/view/DifferentialAddCommentView.php
··· 70 70 $form = new AphrontFormView(); 71 71 $form 72 72 ->setWorkflow(true) 73 - ->setFlexible(true) 74 73 ->setUser($this->user) 74 + ->setShaded(true) 75 75 ->setAction($this->actionURI) 76 76 ->addHiddenInput('revision_id', $revision->getID()) 77 77 ->appendChild(
+1 -2
src/applications/diffusion/controller/DiffusionBrowseController.php
··· 132 132 $drequest = $this->getDiffusionRequest(); 133 133 $form = id(new AphrontFormView()) 134 134 ->setUser($this->getRequest()->getUser()) 135 - ->setMethod('GET') 136 - ->setNoShading(true); 135 + ->setMethod('GET'); 137 136 138 137 switch ($drequest->getRepository()->getVersionControlSystem()) { 139 138 case PhabricatorRepositoryType::REPOSITORY_TYPE_SVN:
-1
src/applications/diffusion/controller/DiffusionCommitEditController.php
··· 55 55 $form = id(new AphrontFormView()) 56 56 ->setUser($user) 57 57 ->setAction($request->getRequestURI()->getPath()) 58 - ->setFlexible(true) 59 58 ->appendChild( 60 59 id(new AphrontFormTokenizerControl()) 61 60 ->setLabel(pht('Projects'))
-1
src/applications/diffusion/controller/DiffusionRepositoryEditBasicController.php
··· 83 83 84 84 $form = id(new AphrontFormView()) 85 85 ->setUser($user) 86 - ->setFlexible(true) 87 86 ->appendChild( 88 87 id(new AphrontFormTextControl()) 89 88 ->setName('name')
-1
src/applications/diffusion/controller/DiffusionRepositoryEditEncodingController.php
··· 74 74 75 75 $form = id(new AphrontFormView()) 76 76 ->setUser($user) 77 - ->setFlexible(true) 78 77 ->appendRemarkupInstructions($this->getEncodingInstructions()) 79 78 ->appendChild( 80 79 id(new AphrontFormTextControl())
+5 -7
src/applications/files/controller/PhabricatorFileUploadController.php
··· 76 76 $global_upload = id(new PhabricatorGlobalUploadTargetView()) 77 77 ->setShowIfSupportedID($support_id); 78 78 79 - $panel = new AphrontPanelView(); 80 - $panel->setHeader(pht('New File Upload')); 81 - $panel->setNoBackground(); 82 - $panel->appendChild($form); 83 - $panel->setWidth(AphrontPanelView::WIDTH_FORM); 79 + $form_box = id(new PHUIFormBoxView()) 80 + ->setHeaderText($title) 81 + ->setFormError($errors) 82 + ->setForm($form); 84 83 85 84 return $this->buildApplicationPage( 86 85 array( 87 86 $crumbs, 88 - $errors, 89 - $panel, 87 + $form_box, 90 88 $global_upload, 91 89 ), 92 90 array(
+1 -1
src/applications/flag/controller/PhabricatorFlagEditController.php
··· 46 46 47 47 require_celerity_resource('phabricator-flag-css'); 48 48 49 - $form = new AphrontFormLayoutView(); 49 + $form = new PHUIFormLayoutView(); 50 50 51 51 $is_new = !$flag->getID(); 52 52
-1
src/applications/herald/controller/HeraldDeleteController.php
··· 43 43 $dialog = new AphrontDialogView(); 44 44 $dialog->setUser($request->getUser()); 45 45 $dialog->setTitle(pht('Really delete this rule?')); 46 - $dialog->setHeaderColor(PhabricatorActionHeaderView::HEADER_RED); 47 46 $dialog->appendChild(pht( 48 47 "Are you sure you want to delete the rule: %s?", 49 48 $rule->getName()));
+5 -2
src/applications/herald/controller/HeraldNewController.php
··· 57 57 $form = id(new AphrontFormView()) 58 58 ->setUser($user) 59 59 ->setAction('/herald/edit/') 60 - ->setFlexible(true) 61 60 ->appendChild( 62 61 id(new AphrontFormSelectControl()) 63 62 ->setLabel(pht('New Rule for')) ··· 70 69 ->setValue(pht('Create Rule')) 71 70 ->addCancelButton($this->getApplicationURI())); 72 71 72 + $form_box = id(new PHUIFormBoxView()) 73 + ->setHeaderText(pht('Create Herald Rule')) 74 + ->setForm($form); 75 + 73 76 $crumbs = $this 74 77 ->buildApplicationCrumbs() 75 78 ->addCrumb( ··· 79 82 return $this->buildApplicationPage( 80 83 array( 81 84 $crumbs, 82 - $form, 85 + $form_box, 83 86 ), 84 87 array( 85 88 'title' => pht('Create Herald Rule'),
+6 -2
src/applications/herald/controller/HeraldRuleController.php
··· 182 182 ? pht('Edit Herald Rule') 183 183 : pht('Create Herald Rule'); 184 184 185 + $form_box = id(new PHUIFormBoxView()) 186 + ->setHeaderText($title) 187 + ->setFormError($error_view) 188 + ->setForm($form); 189 + 185 190 $crumbs = $this 186 191 ->buildApplicationCrumbs() 187 192 ->addCrumb( ··· 191 196 return $this->buildApplicationPage( 192 197 array( 193 198 $crumbs, 194 - $error_view, 195 - $form, 199 + $form_box, 196 200 ), 197 201 array( 198 202 'title' => pht('Edit Rule'),
+6 -3
src/applications/legalpad/controller/LegalpadDocumentEditController.php
··· 113 113 } 114 114 115 115 $form = id(new AphrontFormView()) 116 - ->setFlexible(true) 117 116 ->setUser($user) 118 117 ->appendChild( 119 118 id(new AphrontFormTextControl()) ··· 168 167 $form 169 168 ->appendChild($submit); 170 169 170 + $form_box = id(new PHUIFormBoxView()) 171 + ->setHeaderText($title) 172 + ->setFormError($error_view) 173 + ->setForm($form); 174 + 171 175 $crumbs = $this->buildApplicationCrumbs($this->buildSideNav()); 172 176 $crumbs->addCrumb( 173 177 id(new PhabricatorCrumbView())->setName($short)); ··· 182 186 return $this->buildApplicationPage( 183 187 array( 184 188 $crumbs, 185 - $error_view, 186 - $form, 189 + $form_box, 187 190 $preview 188 191 ), 189 192 array(
-1
src/applications/legalpad/controller/LegalpadDocumentSignController.php
··· 177 177 $data = $signature->getSignatureData(); 178 178 $form = id(new AphrontFormView()) 179 179 ->setUser($user) 180 - ->setFlexible(true) 181 180 ->appendChild( 182 181 id(new AphrontFormInsetView()) 183 182 ->setTitle(pht('Sign and Agree'))
+6 -4
src/applications/macro/controller/PhabricatorMacroEditController.php
··· 153 153 154 154 $form 155 155 ->setEncType('multipart/form-data') 156 - ->setFlexible(true) 157 156 ->appendChild( 158 157 id(new AphrontFormTextControl()) 159 158 ->setLabel(pht('Name')) ··· 239 238 ->setHeader(pht('Upload New File')); 240 239 241 240 $upload_form = id(new AphrontFormView()) 242 - ->setFlexible(true) 243 241 ->setEncType('multipart/form-data') 244 242 ->setUser($request->getUser()); 245 243 ··· 263 261 $upload = array($upload_header, $upload_form); 264 262 } 265 263 264 + $form_box = id(new PHUIFormBoxView()) 265 + ->setHeaderText($title) 266 + ->setFormError($error_view) 267 + ->setForm($form); 268 + 266 269 return $this->buildApplicationPage( 267 270 array( 268 271 $crumbs, 269 - $error_view, 270 - $form, 272 + $form_box, 271 273 $upload, 272 274 ), 273 275 array(
+1 -1
src/applications/macro/controller/PhabricatorMacroMemeDialogController.php
··· 44 44 } 45 45 } 46 46 47 - $view = id(new AphrontFormLayoutView()) 47 + $view = id(new PHUIFormLayoutView()) 48 48 ->appendChild( 49 49 id(new AphrontFormTextControl()) 50 50 ->setLabel(pht('Macro'))
+9 -3
src/applications/mailinglists/controller/PhabricatorMailingListsEditController.php
··· 14 14 $viewer = $request->getUser(); 15 15 16 16 if ($this->id) { 17 + $page_title = pht('Edit Mailing List'); 17 18 $list = id(new PhabricatorMailingListQuery()) 18 19 ->setViewer($viewer) 19 20 ->withIDs(array($this->id)) ··· 22 23 return new Aphront404Response(); 23 24 } 24 25 } else { 26 + $page_title = pht('Create Mailing List'); 25 27 $list = new PhabricatorMetaMTAMailingList(); 26 28 } 27 29 ··· 124 126 ->setName(pht('Create Mailing List'))); 125 127 } 126 128 129 + $form_box = id(new PHUIFormBoxView()) 130 + ->setHeaderText($page_title) 131 + ->setFormError($error_view) 132 + ->setForm($form); 133 + 127 134 return $this->buildApplicationPage( 128 135 array( 129 136 $crumbs, 130 - $error_view, 131 - $form, 137 + $form_box, 132 138 ), 133 139 array( 134 - 'title' => pht('Edit Mailing List'), 140 + 'title' => $page_title, 135 141 'device' => true, 136 142 )); 137 143 }
+1 -1
src/applications/maniphest/controller/ManiphestExportController.php
··· 76 76 $dialog->appendChild(phutil_tag('p', array(), pht( 77 77 'Do you want to export the query results to Excel?'))); 78 78 79 - $form = id(new AphrontFormLayoutView()) 79 + $form = id(new PHUIFormLayoutView()) 80 80 ->appendChild( 81 81 id(new AphrontFormSelectControl()) 82 82 ->setLabel(pht('Format:'))
+1
src/applications/maniphest/controller/ManiphestTaskDetailController.php
··· 198 198 $comment_form = new AphrontFormView(); 199 199 $comment_form 200 200 ->setUser($user) 201 + ->setShaded(true) 201 202 ->setAction('/maniphest/transaction/save/') 202 203 ->setEncType('multipart/form-data') 203 204 ->addHiddenInput('taskID', $task->getID())
+7 -4
src/applications/maniphest/controller/ManiphestTaskEditController.php
··· 381 381 $project_tokenizer_id = celerity_generate_unique_node_id(); 382 382 383 383 if ($request->isAjax()) { 384 - $form = new AphrontFormLayoutView(); 384 + $form = new PHUIFormLayoutView(); 385 385 } else { 386 386 $form = new AphrontFormView(); 387 - $form->setFlexible(true); 388 387 $form 389 388 ->setUser($user) 390 389 ->addHiddenInput('template', $template_id); ··· 536 535 ->addCancelButton($cancel_uri) 537 536 ->setValue($button_name)); 538 537 538 + $form_box = id(new PHUIFormBoxView()) 539 + ->setHeaderText($header_name) 540 + ->setFormError($error_view) 541 + ->setForm($form); 542 + 539 543 $preview = id(new PHUIRemarkupPreviewPanel()) 540 544 ->setHeader(pht('Description Preview')) 541 545 ->setControlID('description-textarea') ··· 561 565 return $this->buildApplicationPage( 562 566 array( 563 567 $crumbs, 564 - $error_view, 565 - $form, 568 + $form_box, 566 569 $preview, 567 570 ), 568 571 array(
-1
src/applications/maniphest/controller/ManiphestTaskListController.php
··· 124 124 125 125 $form = id(new AphrontFormView()) 126 126 ->setUser($user) 127 - ->setNoShading(true) 128 127 ->setAction( 129 128 $request->getRequestURI() 130 129 ->alter('key', null)
-1
src/applications/owners/controller/PhabricatorOwnersDeleteController.php
··· 29 29 $dialog = id(new AphrontDialogView()) 30 30 ->setUser($user) 31 31 ->setTitle('Really delete this package?') 32 - ->setHeaderColor(PhabricatorActionHeaderView::HEADER_RED) 33 32 ->appendChild(hsprintf( 34 33 '<p>%s</p>', 35 34 $text))
+5 -6
src/applications/owners/controller/PhabricatorOwnersEditController.php
··· 181 181 182 182 $form = id(new AphrontFormView()) 183 183 ->setUser($user) 184 - ->setFlexible(true) 185 184 ->appendChild( 186 185 id(new AphrontFormTextControl()) 187 186 ->setLabel(pht('Name')) ··· 252 251 ->addCancelButton($cancel_uri) 253 252 ->setValue(pht('Save Package'))); 254 253 255 - $header = id(new PhabricatorHeaderView()) 256 - ->setHeader($title); 254 + $form_box = id(new PHUIFormBoxView()) 255 + ->setHeaderText($title) 256 + ->setFormError($error_view) 257 + ->setForm($form); 257 258 258 259 $nav = $this->buildSideNavView(); 259 - $nav->appendChild($error_view); 260 - $nav->appendChild($header); 261 - $nav->appendChild($form); 260 + $nav->appendChild($form_box); 262 261 263 262 return $this->buildApplicationPage( 264 263 array(
-1
src/applications/owners/controller/PhabricatorOwnersListController.php
··· 168 168 ->setUser($user) 169 169 ->setAction('/owners/view/search/') 170 170 ->setMethod('GET') 171 - ->setNoShading(true) 172 171 ->appendChild( 173 172 id(new AphrontFormTextControl()) 174 173 ->setName('name')
+8 -7
src/applications/paste/controller/PhabricatorPasteEditController.php
··· 131 131 } 132 132 133 133 $form = new AphrontFormView(); 134 - $form->setFlexible(true); 135 134 136 135 $langs = array( 137 136 '' => pht('(Detect From Filename in Title)'), ··· 200 199 $short = pht('Edit'); 201 200 } else { 202 201 $submit->setValue(pht('Create Paste')); 203 - $title = pht('Create Paste'); 202 + $title = pht('Create New Paste'); 204 203 $short = pht('Create'); 205 204 } 206 205 207 - $form 208 - ->appendChild($submit); 206 + $form->appendChild($submit); 207 + 208 + $form_box = id(new PHUIFormBoxView()) 209 + ->setHeaderText($title) 210 + ->setFormError($error_view) 211 + ->setForm($form); 209 212 210 213 $crumbs = $this->buildApplicationCrumbs($this->buildSideNavView()); 211 214 if (!$is_create) { ··· 220 223 return $this->buildApplicationPage( 221 224 array( 222 225 $crumbs, 223 - id(new PhabricatorHeaderView())->setHeader($title), 224 - $error_view, 225 - $form, 226 + $form_box, 226 227 ), 227 228 array( 228 229 'title' => $title,
+31 -16
src/applications/people/controller/PhabricatorPeopleEditController.php
··· 343 343 id(new AphrontFormSubmitControl()) 344 344 ->setValue(pht('Save'))); 345 345 346 - $header = new PhabricatorHeaderView(); 347 346 if ($user->getID()) { 348 - $header->setHeader(pht('Edit User')); 347 + $title = pht('Edit User'); 349 348 } else { 350 - $header->setHeader(pht('Create New User')); 349 + $title = pht('Create New User'); 351 350 } 352 351 353 - return array($error_view, $form); 352 + $form_box = id(new PHUIFormBoxView()) 353 + ->setHeaderText($title) 354 + ->setFormError($error_view) 355 + ->setForm($form); 356 + 357 + return array($form_box); 354 358 } 355 359 356 360 private function processRoleRequest(PhabricatorUser $user) { ··· 448 452 ->setValue(pht('Edit Role'))); 449 453 } 450 454 451 - $header = new PhabricatorHeaderView(); 452 - $header->setHeader(pht('Edit Role')); 455 + $title = pht('Edit Role'); 453 456 454 - return array($error_view, $header, $form); 457 + $form_box = id(new PHUIFormBoxView()) 458 + ->setHeaderText($title) 459 + ->setFormError($error_view) 460 + ->setForm($form); 461 + 462 + return array($form_box); 455 463 } 456 464 457 465 private function processCertificateRequest($user) { ··· 486 494 pht('You may only view the certificates of System Agents.'))); 487 495 } 488 496 489 - $header = new PhabricatorHeaderView(); 490 - $header->setHeader(pht('Conduit Certificate')); 497 + $title = pht('Conduit Certificate'); 498 + 499 + $form_box = id(new PHUIFormBoxView()) 500 + ->setHeaderText($title) 501 + ->setForm($form); 491 502 492 - return array($header, $form); 503 + return array($form_box); 493 504 } 494 505 495 506 private function processRenameRequest(PhabricatorUser $user) { ··· 581 592 id(new AphrontFormSubmitControl()) 582 593 ->setValue(pht('Change Username'))); 583 594 584 - $header = new PhabricatorHeaderView(); 585 - $header->setHeader(pht('Change Username')); 595 + $form_box = id(new PHUIFormBoxView()) 596 + ->setHeaderText(pht('Change Username')) 597 + ->setFormError($errors) 598 + ->setForm($form); 586 599 587 - return array($errors, $header, $form); 600 + return array($form_box); 588 601 } 589 602 590 603 private function processDeleteRequest(PhabricatorUser $user) { ··· 672 685 id(new AphrontFormSubmitControl()) 673 686 ->setValue(pht('Delete User'))); 674 687 675 - $header = new PhabricatorHeaderView(); 676 - $header->setHeader(pht('Delete User')); 688 + $form_box = id(new PHUIFormBoxView()) 689 + ->setHeaderText(pht('Delete User')) 690 + ->setFormError($errors) 691 + ->setForm($form); 677 692 678 - return array($errors, $header, $form); 693 + return array($form_box); 679 694 } 680 695 681 696 private function getRoleInstructions() {
+5 -1
src/applications/people/controller/PhabricatorPeopleProfileEditController.php
··· 74 74 ->addCancelButton($profile_uri) 75 75 ->setValue(pht('Save Profile'))); 76 76 77 + $form_box = id(new PHUIFormBoxView()) 78 + ->setHeaderText(pht('Edit Your Profile')) 79 + ->setForm($form); 80 + 77 81 return $this->buildApplicationPage( 78 82 array( 79 83 $crumbs, 80 - $form, 84 + $form_box, 81 85 ), 82 86 array( 83 87 'title' => $title,
+1 -2
src/applications/people/controller/PhabricatorPeopleProfilePictureController.php
··· 98 98 id(new PhabricatorCrumbView()) 99 99 ->setName($title)); 100 100 101 - $form = id(new AphrontFormLayoutView()) 101 + $form = id(new PHUIFormLayoutView()) 102 102 ->setUser($viewer); 103 103 104 104 $default_image = PhabricatorFile::loadBuiltin($viewer, 'profile.png'); ··· 265 265 266 266 $upload_form = id(new AphrontFormView()) 267 267 ->setUser($user) 268 - ->setFlexible(true) 269 268 ->setEncType('multipart/form-data') 270 269 ->appendChild( 271 270 id(new AphrontFormFileControl())
-1
src/applications/phame/controller/blog/PhameBlogDeleteController.php
··· 38 38 $dialog = id(new AphrontDialogView()) 39 39 ->setUser($user) 40 40 ->setTitle(pht('Delete Blog?')) 41 - ->setHeaderColor(PhabricatorActionHeaderView::HEADER_RED) 42 41 ->appendChild( 43 42 pht( 44 43 'Really delete the blog "%s"? It will be gone forever.',
+6 -3
src/applications/phame/controller/blog/PhameBlogEditController.php
··· 107 107 108 108 $form = id(new AphrontFormView()) 109 109 ->setUser($user) 110 - ->setFlexible(true) 111 110 ->appendChild( 112 111 id(new AphrontFormTextControl()) 113 112 ->setLabel(pht('Name')) ··· 171 170 $error_view = null; 172 171 } 173 172 173 + $form_box = id(new PHUIFormBoxView()) 174 + ->setHeaderText($page_title) 175 + ->setFormError($error_view) 176 + ->setForm($form); 177 + 174 178 $crumbs = $this->buildApplicationCrumbs(); 175 179 $crumbs->addCrumb( 176 180 id(new PhabricatorCrumbView()) ··· 182 186 $nav->appendChild( 183 187 array( 184 188 $crumbs, 185 - $error_view, 186 - $form, 189 + $form_box, 187 190 )); 188 191 189 192 return $this->buildApplicationPage(
-1
src/applications/phame/controller/post/PhamePostDeleteController.php
··· 38 38 $dialog = id(new AphrontDialogView()) 39 39 ->setUser($user) 40 40 ->setTitle(pht('Delete Post?')) 41 - ->setHeaderColor(PhabricatorActionHeaderView::HEADER_RED) 42 41 ->appendChild( 43 42 pht( 44 43 'Really delete the post "%s"? It will be gone forever.',
+6 -3
src/applications/phame/controller/post/PhamePostEditController.php
··· 100 100 101 101 $form = id(new AphrontFormView()) 102 102 ->setUser($user) 103 - ->setFlexible(true) 104 103 ->addHiddenInput('blog', $request->getInt('blog')) 105 104 ->appendChild( 106 105 id(new AphrontFormMarkupControl()) ··· 174 173 $error_view = null; 175 174 } 176 175 176 + $form_box = id(new PHUIFormBoxView()) 177 + ->setHeaderText($page_title) 178 + ->setFormError($error_view) 179 + ->setForm($form); 180 + 177 181 $crumbs = $this->buildApplicationCrumbs(); 178 182 $crumbs->addCrumb( 179 183 id(new PhabricatorCrumbView()) ··· 184 188 $nav->appendChild( 185 189 array( 186 190 $crumbs, 187 - $error_view, 188 - $form, 191 + $form_box, 189 192 $preview_panel, 190 193 )); 191 194
+6 -2
src/applications/phame/controller/post/PhamePostNewController.php
··· 94 94 95 95 $form = id(new AphrontFormView()) 96 96 ->setUser($user) 97 - ->setFlexible(true) 98 97 ->appendChild( 99 98 id(new AphrontFormSelectControl()) 100 99 ->setLabel(pht('Blog')) ··· 117 116 ->setValue(pht('Continue'))); 118 117 } 119 118 120 - $nav->appendChild($form); 119 + 120 + $form_box = id(new PHUIFormBoxView()) 121 + ->setHeaderText($title) 122 + ->setForm($form); 123 + 124 + $nav->appendChild($form_box); 121 125 } 122 126 123 127 return $this->buildApplicationPage(
-1
src/applications/phame/controller/post/PhamePostPublishController.php
··· 42 42 43 43 $form = id(new AphrontFormView()) 44 44 ->setUser($user) 45 - ->setFlexible(true) 46 45 ->appendChild( 47 46 id(new AphrontFormSubmitControl()) 48 47 ->setValue(pht('Publish Post'))
+5 -5
src/applications/phlux/controller/PhluxEditController.php
··· 176 176 ->setHref($request->getRequestURI())); 177 177 } 178 178 179 - $header = id(new PhabricatorHeaderView()) 180 - ->setHeader($title); 179 + $form_box = id(new PHUIFormBoxView()) 180 + ->setHeaderText($title) 181 + ->setFormError($errors) 182 + ->setForm($form); 181 183 182 184 return $this->buildApplicationPage( 183 185 array( 184 186 $crumbs, 185 - $header, 186 - $errors, 187 - $form, 187 + $form_box, 188 188 ), 189 189 array( 190 190 'title' => $title,
+6 -3
src/applications/pholio/controller/PholioMockEditController.php
··· 285 285 require_celerity_resource('pholio-edit-css'); 286 286 $form = id(new AphrontFormView()) 287 287 ->setUser($user) 288 - ->setFlexible(true) 289 288 ->appendChild($order_control) 290 289 ->appendChild( 291 290 id(new AphrontFormTextControl()) ··· 322 321 ->setError($e_images)) 323 322 ->appendChild($submit); 324 323 324 + $form_box = id(new PHUIFormBoxView()) 325 + ->setHeaderText($title) 326 + ->setFormError($error_view) 327 + ->setForm($form); 328 + 325 329 $crumbs = $this->buildApplicationCrumbs(); 326 330 $crumbs->addCrumb( 327 331 id(new PhabricatorCrumbView()) ··· 330 334 331 335 $content = array( 332 336 $crumbs, 333 - $error_view, 334 - $form, 337 + $form_box, 335 338 ); 336 339 337 340 return $this->buildApplicationPage(
+1 -3
src/applications/phortune/controller/PhortuneAccountBuyController.php
··· 160 160 $user); 161 161 } 162 162 163 - $provider_form = id(new AphrontFormLayoutView()) 164 - ->setPadded(true) 165 - ->setBackgroundShading(true); 163 + $provider_form = new PHUIFormLayoutView(); 166 164 $provider_form->appendChild( 167 165 id(new AphrontFormMarkupControl()) 168 166 ->setLabel('Pay With')
-1
src/applications/phrequent/controller/PhrequentListController.php
··· 144 144 145 145 $form = id(new AphrontFormView()) 146 146 ->setUser($user) 147 - ->setNoShading(true) 148 147 ->setAction($this->getApplicationURI("/view/custom/")); 149 148 150 149 $user_handles = id(new PhabricatorObjectHandleData($user_phids))
-1
src/applications/phriction/controller/PhrictionDeleteController.php
··· 50 50 $dialog = id(new AphrontDialogView()) 51 51 ->setUser($user) 52 52 ->setTitle(pht('Delete Document?')) 53 - ->setHeaderColor(PhabricatorActionHeaderView::HEADER_RED) 54 53 ->appendChild( 55 54 pht('Really delete this document? You can recover it later by '. 56 55 'reverting to a previous version.'))
+5 -4
src/applications/phriction/controller/PhrictionEditController.php
··· 226 226 ->addCancelButton($cancel_uri) 227 227 ->setValue($submit_button)); 228 228 229 - $header = id(new PhabricatorHeaderView()) 230 - ->setHeader($panel_header); 229 + $form_box = id(new PHUIFormBoxView()) 230 + ->setHeaderText(pht('Edit Document')) 231 + ->setFormError($error_view) 232 + ->setForm($form); 231 233 232 234 $preview = id(new PHUIRemarkupPreviewPanel()) 233 235 ->setHeader(pht('Document Preview')) ··· 254 256 array( 255 257 $crumbs, 256 258 $draft_note, 257 - $error_view, 258 - $form, 259 + $form_box, 259 260 $preview, 260 261 ), 261 262 array(
+1 -1
src/applications/phriction/controller/PhrictionMoveController.php
··· 118 118 $descr_caption = $is_serious ? pht('A reason for the move.') : 119 119 pht('You better give a good reason for this.'); 120 120 121 - $form = id(new AphrontFormLayoutView()) 121 + $form = id(new PHUIFormLayoutView()) 122 122 ->setUser($user) 123 123 ->appendChild( 124 124 id(new AphrontFormStaticControl())
+1 -1
src/applications/phriction/controller/PhrictionNewController.php
··· 44 44 $slug = ''; 45 45 } 46 46 47 - $view = id(new AphrontFormLayoutView()) 47 + $view = id(new PHUIFormLayoutView()) 48 48 ->appendChild(id(new AphrontFormTextControl()) 49 49 ->setLabel('/w/') 50 50 ->setValue($slug)
+6 -2
src/applications/ponder/controller/PonderAnswerEditController.php
··· 95 95 id(new PhabricatorCrumbView()) 96 96 ->setName(pht('Edit Answer'))); 97 97 98 + $form_box = id(new PHUIFormBoxView()) 99 + ->setHeaderText(pht('Edit Answer')) 100 + ->setFormError($errors) 101 + ->setForm($form); 102 + 98 103 $preview = id(new PHUIRemarkupPreviewPanel()) 99 104 ->setHeader(pht('Answer Preview')) 100 105 ->setControlID($answer_content_id) ··· 103 108 return $this->buildApplicationPage( 104 109 array( 105 110 $crumbs, 106 - $errors, 107 - $form, 111 + $form_box, 108 112 $preview, 109 113 ), 110 114 array(
+7 -4
src/applications/ponder/controller/PonderQuestionEditController.php
··· 85 85 86 86 $form = id(new AphrontFormView()) 87 87 ->setUser($user) 88 - ->setFlexible(true) 89 88 ->appendChild( 90 89 id(new AphrontFormTextControl()) 91 90 ->setLabel(pht('Question')) ··· 108 107 ->setHeader(pht('Question Preview')) 109 108 ->setControlID('content') 110 109 ->setPreviewURI($this->getApplicationURI('preview/')); 110 + 111 + $form_box = id(new PHUIFormBoxView()) 112 + ->setHeaderText(pht('Ask New Question')) 113 + ->setFormError($error_view) 114 + ->setForm($form); 111 115 112 116 $crumbs = $this->buildApplicationCrumbs(); 113 117 ··· 129 133 return $this->buildApplicationPage( 130 134 array( 131 135 $crumbs, 132 - $error_view, 133 - $form, 136 + $form_box, 134 137 $preview, 135 138 ), 136 139 array( 137 - 'title' => pht('Ask a Question'), 140 + 'title' => pht('Ask New Question'), 138 141 'device' => true, 139 142 )); 140 143 }
-1
src/applications/ponder/view/PonderAddAnswerView.php
··· 26 26 27 27 $form = new AphrontFormView(); 28 28 $form 29 - ->setFlexible(true) 30 29 ->setUser($this->user) 31 30 ->setAction($this->actionURI) 32 31 ->setWorkflow(true)
+7 -3
src/applications/project/controller/PhabricatorProjectCreateController.php
··· 68 68 } 69 69 70 70 if ($request->isAjax()) { 71 - $form = new AphrontFormLayoutView(); 71 + $form = new PHUIFormLayoutView(); 72 72 } else { 73 73 $form = new AphrontFormView(); 74 74 $form->setUser($user); ··· 113 113 ->setName(pht('Create Project')) 114 114 ->setHref($this->getApplicationURI().'create/')); 115 115 116 + $form_box = id(new PHUIFormBoxView()) 117 + ->setHeaderText(pht('Create New Project')) 118 + ->setFormError($error_view) 119 + ->setForm($form); 120 + 116 121 return $this->buildApplicationPage( 117 122 array( 118 123 $crumbs, 119 - $error_view, 120 - $form, 124 + $form_box, 121 125 ), 122 126 array( 123 127 'title' => pht('Create New Project'),
+10 -9
src/applications/project/controller/PhabricatorProjectMembersEditController.php
··· 91 91 $form = new AphrontFormView(); 92 92 $form 93 93 ->setUser($user) 94 - ->setFlexible(true) 95 94 ->appendChild( 96 95 id(new AphrontFormTokenizerControl()) 97 96 ->setName('phids') ··· 101 100 id(new AphrontFormSubmitControl()) 102 101 ->addCancelButton('/project/view/'.$project->getID().'/') 103 102 ->setValue(pht('Add Members'))); 104 - $faux_form = id(new AphrontFormLayoutView()) 103 + $faux_form = id(new AphrontFormView()) 104 + ->setUser($user) 105 105 ->appendChild( 106 106 id(new AphrontFormInsetView()) 107 - ->setTitle(pht('Current Members (%d)', count($handles))) 108 107 ->appendChild($list)); 109 108 110 - $box = new PHUIBoxView(); 111 - $box->appendChild($faux_form); 112 - $box->setShadow(true); 113 - $box->addPadding(PHUI::PADDING_LARGE); 114 - $box->addMargin(PHUI::MARGIN_LARGE); 109 + $box = id(new PHUIFormBoxView()) 110 + ->setHeaderText(pht('Current Members (%d)', count($handles))) 111 + ->setForm($faux_form); 112 + 113 + $form_box = id(new PHUIFormBoxView()) 114 + ->setHeaderText($title) 115 + ->setForm($form); 115 116 116 117 $crumbs = $this->buildApplicationCrumbs($this->buildSideNavView()); 117 118 $crumbs->addCrumb( ··· 126 127 return $this->buildApplicationPage( 127 128 array( 128 129 $crumbs, 129 - $form, 130 + $form_box, 130 131 $box, 131 132 ), 132 133 array(
+5 -3
src/applications/project/controller/PhabricatorProjectProfileEditController.php
··· 151 151 ->setUser($user) 152 152 ->setAction($action) 153 153 ->setEncType('multipart/form-data') 154 - ->setFlexible(true) 155 154 ->appendChild( 156 155 id(new AphrontFormTextControl()) 157 156 ->setLabel(pht('Name')) ··· 220 219 ->addCancelButton('/project/view/'.$project->getID().'/') 221 220 ->setValue(pht('Save'))); 222 221 222 + $form_box = id(new PHUIFormBoxView()) 223 + ->setHeaderText($title) 224 + ->setFormError($error_view) 225 + ->setForm($form); 223 226 224 227 $crumbs = $this->buildApplicationCrumbs($this->buildSideNavView()); 225 228 $crumbs->addCrumb( ··· 234 237 return $this->buildApplicationPage( 235 238 array( 236 239 $crumbs, 237 - $error_view, 238 - $form, 240 + $form_box, 239 241 ), 240 242 array( 241 243 'title' => $title,
-1
src/applications/releeph/controller/project/ReleephProjectCreateController.php
··· 92 92 93 93 $form = id(new AphrontFormView()) 94 94 ->setUser($request->getUser()) 95 - ->setFlexible(true) 96 95 ->appendChild($project_name_input) 97 96 ->appendChild($arc_project_input) 98 97 ->appendChild(
+5 -7
src/applications/repository/controller/PhabricatorRepositoryCreateController.php
··· 66 66 $error_view->setTitle('Form Errors'); 67 67 } 68 68 69 - 70 69 $form = new AphrontFormView(); 71 70 $form 72 71 ->setUser($user) 73 72 ->setAction('/repository/create/') 74 - ->setFlexible(true) 75 73 ->appendChild( 76 74 id(new AphrontFormTextControl()) 77 75 ->setLabel('Name') ··· 103 101 ->setValue('Create Repository') 104 102 ->addCancelButton('/repository/')); 105 103 106 - $header = id(new PhabricatorHeaderView()) 107 - ->setHeader(pht('Create Repository')); 104 + $form_box = id(new PHUIFormBoxView()) 105 + ->setHeaderText(pht('Create Repository')) 106 + ->setFormError($error_view) 107 + ->setForm($form); 108 108 109 109 return $this->buildApplicationPage( 110 110 array( 111 - $error_view, 112 - $header, 113 - $form, 111 + $form_box, 114 112 ), 115 113 array( 116 114 'title' => pht('Create Repository'),
+5 -6
src/applications/repository/controller/PhabricatorRepositoryEditController.php
··· 155 155 156 156 $nav = $this->sideNav; 157 157 158 - $header = id(new PhabricatorHeaderView()) 159 - ->setHeader(pht('Edit Repository')); 158 + $form_box = id(new PHUIFormBoxView()) 159 + ->setHeaderText(pht('Edit Repository')) 160 + ->setFormError($error_view) 161 + ->setForm($form); 160 162 161 - $nav->appendChild($error_view); 162 - $nav->appendChild($header); 163 - $nav->appendChild($form); 163 + $nav->appendChild($form_box); 164 164 165 165 return $this->buildApplicationPage( 166 166 $nav, ··· 358 358 $form 359 359 ->setUser($user) 360 360 ->setAction('/repository/edit/'.$repository->getID().'/tracking/') 361 - ->setFlexible(true) 362 361 ->appendChild(hsprintf( 363 362 '<p class="aphront-form-instructions">Phabricator can track '. 364 363 'repositories, importing commits as they happen and notifying '.
-1
src/applications/search/controller/PhabricatorApplicationSearchController.php
··· 133 133 'query/advanced'); 134 134 135 135 $form = id(new AphrontFormView()) 136 - ->setNoShading(true) 137 136 ->setUser($user); 138 137 139 138 $engine->buildSearchForm($form, $saved_query);
-1
src/applications/search/controller/PhabricatorSearchController.php
··· 143 143 $search_form 144 144 ->setUser($user) 145 145 ->setAction('/search/') 146 - ->setNoShading(true) 147 146 ->appendChild( 148 147 phutil_tag( 149 148 'input',
+6 -2
src/applications/search/controller/PhabricatorSearchEditController.php
··· 92 92 $title = pht('Save Query'); 93 93 } 94 94 95 + $form_box = id(new PHUIFormBoxView()) 96 + ->setHeaderText($title) 97 + ->setFormError($errors) 98 + ->setForm($form); 99 + 95 100 $crumbs = $this->buildApplicationCrumbs(); 96 101 $crumbs->addCrumb( 97 102 id(new PhabricatorCrumbView()) ··· 100 105 return $this->buildApplicationPage( 101 106 array( 102 107 $crumbs, 103 - $errors, 104 - $form, 108 + $form_box, 105 109 ), 106 110 array( 107 111 'title' => $title,
+4 -5
src/applications/settings/panel/PhabricatorSettingsPanelAccount.php
··· 88 88 $form = new AphrontFormView(); 89 89 $form 90 90 ->setUser($user) 91 - ->setFlexible(true) 92 91 ->appendChild( 93 92 id(new AphrontFormSelectControl()) 94 93 ->setLabel(pht('Timezone')) ··· 111 110 id(new AphrontFormSubmitControl()) 112 111 ->setValue(pht('Save Account Settings'))); 113 112 114 - $header = new PhabricatorHeaderView(); 115 - $header->setHeader(pht('Account Settings')); 113 + $form_box = id(new PHUIFormBoxView()) 114 + ->setHeaderText(pht('Account Settings')) 115 + ->setForm($form); 116 116 117 117 return array( 118 118 $notice, 119 - $header, 120 - $form, 119 + $form_box, 121 120 ); 122 121 } 123 122 }
+6 -6
src/applications/settings/panel/PhabricatorSettingsPanelConduit.php
··· 78 78 ->setHeight(AphrontFormTextAreaControl::HEIGHT_SHORT) 79 79 ->setValue($user->getConduitCertificate())); 80 80 81 - $header1 = new PhabricatorHeaderView(); 82 - $header1->setHeader(pht('Arcanist Certificate')); 81 + $cert_form = id(new PHUIFormBoxView()) 82 + ->setHeaderText(pht('Arcanist Certificate')) 83 + ->setForm($cert_form); 83 84 84 85 $regen_instruction = pht('You can regenerate this certificate, which '. 85 86 'will invalidate the old certificate and create a new one.'); ··· 95 96 id(new AphrontFormSubmitControl()) 96 97 ->setValue(pht('Regenerate Certificate'))); 97 98 98 - $header = new PhabricatorHeaderView(); 99 - $header->setHeader(pht('Regenerate Certificate')); 99 + $regen_form = id(new PHUIFormBoxView()) 100 + ->setHeaderText(pht('Regenerate Certificate')) 101 + ->setForm($regen_form); 100 102 101 103 return array( 102 104 $notice, 103 - $header1, 104 105 $cert_form, 105 - $header, 106 106 $regen_form, 107 107 ); 108 108 }
+6 -6
src/applications/settings/panel/PhabricatorSettingsPanelConpherencePreferences.php
··· 56 56 id(new AphrontFormSubmitControl()) 57 57 ->setValue(pht('Save Preferences'))); 58 58 59 - $header = new PhabricatorHeaderView(); 60 - $header->setHeader(pht('Conpherence Preferences')); 61 - 62 59 $error_view = null; 63 60 if ($request->getBool('saved')) { 64 61 $error_view = id(new AphrontErrorView()) ··· 67 64 ->setErrors(array(pht('Your preferences have been saved.'))); 68 65 } 69 66 67 + $form_box = id(new PHUIFormBoxView()) 68 + ->setHeaderText(pht('Conpherence Preferences')) 69 + ->setFormError($error_view) 70 + ->setForm($form); 71 + 70 72 return array( 71 - $error_view, 72 - $header, 73 - $form, 73 + $form_box, 74 74 ); 75 75 } 76 76 }
+6 -7
src/applications/settings/panel/PhabricatorSettingsPanelDeveloperPreferences.php
··· 69 69 70 70 $form = id(new AphrontFormView()) 71 71 ->setUser($user) 72 - ->setFlexible(true) 73 72 ->appendRemarkupInstructions($instructions) 74 73 ->appendChild( 75 74 id(new AphrontFormSelectControl()) ··· 86 85 id(new AphrontFormSubmitControl()) 87 86 ->setValue(pht('Save Preferences'))); 88 87 89 - $header = id(new PhabricatorHeaderView()) 90 - ->setHeader(pht('Developer Settings')); 91 - 92 88 $error_view = null; 93 89 if ($request->getBool('saved')) { 94 90 $error_view = id(new AphrontErrorView()) ··· 97 93 ->setErrors(array(pht('Your preferences have been saved.'))); 98 94 } 99 95 96 + $form_box = id(new PHUIFormBoxView()) 97 + ->setHeaderText(pht('Developer Settings')) 98 + ->setFormError($error_view) 99 + ->setForm($form); 100 + 100 101 return array( 101 - $error_view, 102 - $header, 103 - $form, 102 + $form_box, 104 103 ); 105 104 } 106 105 }
+6 -6
src/applications/settings/panel/PhabricatorSettingsPanelDiffPreferences.php
··· 58 58 id(new AphrontFormSubmitControl()) 59 59 ->setValue(pht('Save Preferences'))); 60 60 61 - $header = new PhabricatorHeaderView(); 62 - $header->setHeader(pht('Diff Preferences')); 63 - 64 61 $error_view = null; 65 62 if ($request->getBool('saved')) { 66 63 $error_view = id(new AphrontErrorView()) ··· 69 66 ->setErrors(array(pht('Your preferences have been saved.'))); 70 67 } 71 68 69 + $form_box = id(new PHUIFormBoxView()) 70 + ->setHeaderText(pht('Diff Preferences')) 71 + ->setFormError($error_view) 72 + ->setForm($form); 73 + 72 74 return array( 73 - $error_view, 74 - $header, 75 - $form, 75 + $form_box, 76 76 ); 77 77 } 78 78 }
+6 -6
src/applications/settings/panel/PhabricatorSettingsPanelDisplayPreferences.php
··· 137 137 id(new AphrontFormSubmitControl()) 138 138 ->setValue(pht('Save Preferences'))); 139 139 140 - $header = new PhabricatorHeaderView(); 141 - $header->setHeader(pht('Display Preferences')); 142 - 143 140 $error_view = null; 144 141 if ($request->getStr('saved') === 'true') { 145 142 $error_view = id(new AphrontErrorView()) ··· 148 145 ->setErrors(array(pht('Your preferences have been saved.'))); 149 146 } 150 147 148 + $form_box = id(new PHUIFormBoxView()) 149 + ->setHeaderText(pht('Display Preferences')) 150 + ->setFormError($error_view) 151 + ->setForm($form); 152 + 151 153 return array( 152 - $error_view, 153 - $header, 154 - $form, 154 + $form_box, 155 155 ); 156 156 } 157 157 }
+1 -1
src/applications/settings/panel/PhabricatorSettingsPanelEmailAddresses.php
··· 210 210 ->setErrors($errors); 211 211 } 212 212 213 - $form = id(new AphrontFormLayoutView()) 213 + $form = id(new PHUIFormLayoutView()) 214 214 ->appendChild( 215 215 id(new AphrontFormTextControl()) 216 216 ->setLabel(pht('Email'))
+5 -5
src/applications/settings/panel/PhabricatorSettingsPanelEmailPreferences.php
··· 216 216 id(new AphrontFormSubmitControl()) 217 217 ->setValue(pht('Save Preferences'))); 218 218 219 - $header = new PhabricatorHeaderView(); 220 - $header->setHeader(pht('Email Preferences')); 219 + $form_box = id(new PHUIFormBoxView()) 220 + ->setHeaderText(pht('Email Preferences')) 221 + ->setFormError($notice) 222 + ->setForm($form); 221 223 222 224 return id(new AphrontNullView()) 223 225 ->appendChild( 224 226 array( 225 - $notice, 226 - $header, 227 - $form, 227 + $form_box, 228 228 )); 229 229 } 230 230
+6 -7
src/applications/settings/panel/PhabricatorSettingsPanelHomePreferences.php
··· 48 48 ->setURI($this->getPanelURI('?saved=true')); 49 49 } 50 50 51 - $header = id(new PhabricatorHeaderView()) 52 - ->setHeader(pht('Home Page Preferences')); 53 - 54 51 $form = id(new AphrontFormView()) 55 - ->setFlexible(true) 56 52 ->setUser($user); 57 53 58 54 $group_map = PhabricatorApplication::getApplicationGroups(); ··· 204 200 ->setErrors(array(pht('Your preferences have been saved.'))); 205 201 } 206 202 203 + $form_box = id(new PHUIFormBoxView()) 204 + ->setHeaderText(pht('Home Page Preferences')) 205 + ->setFormError($error_view) 206 + ->setForm($form); 207 + 207 208 return array( 208 - $header, 209 - $error_view, 210 - $form, 209 + $form_box, 211 210 ); 212 211 } 213 212 }
+5 -5
src/applications/settings/panel/PhabricatorSettingsPanelPassword.php
··· 159 159 id(new AphrontFormSubmitControl()) 160 160 ->setValue(pht('Save'))); 161 161 162 - $header = new PhabricatorHeaderView(); 163 - $header->setHeader(pht('Change Password')); 162 + $form_box = id(new PHUIFormBoxView()) 163 + ->setHeaderText(pht('Delete User')) 164 + ->setFormError($notice) 165 + ->setForm($form); 164 166 165 167 return array( 166 - $notice, 167 - $header, 168 - $form, 168 + $form_box, 169 169 ); 170 170 } 171 171 }
+6 -6
src/applications/settings/panel/PhabricatorSettingsPanelSearchPreferences.php
··· 50 50 id(new AphrontFormSubmitControl()) 51 51 ->setValue(pht('Save'))); 52 52 53 - $header = new PhabricatorHeaderView(); 54 - $header->setHeader(pht('Search Preferences')); 55 - 56 53 $error_view = null; 57 54 if ($request->getStr('saved') === 'true') { 58 55 $error_view = id(new AphrontErrorView()) ··· 61 58 ->setErrors(array(pht('Your preferences have been saved.'))); 62 59 } 63 60 61 + $form_box = id(new PHUIFormBoxView()) 62 + ->setHeaderText(pht('Search Preferences')) 63 + ->setFormError($error_view) 64 + ->setForm($form); 65 + 64 66 return array( 65 - $error_view, 66 - $header, 67 - $form, 67 + $form_box, 68 68 ); 69 69 } 70 70 }
+6 -3
src/applications/slowvote/controller/PhabricatorSlowvoteEditController.php
··· 136 136 137 137 $form = id(new AphrontFormView()) 138 138 ->setUser($user) 139 - ->setFlexible(true) 140 139 ->appendChild($instructions) 141 140 ->appendChild( 142 141 id(new AphrontFormTextAreaControl()) ··· 232 231 id(new PhabricatorCrumbView()) 233 232 ->setName($title)); 234 233 234 + $form_box = id(new PHUIFormBoxView()) 235 + ->setHeaderText($title) 236 + ->setFormError($error_view) 237 + ->setForm($form); 238 + 235 239 return $this->buildApplicationPage( 236 240 array( 237 241 $crumbs, 238 - $error_view, 239 - $form, 242 + $form_box, 240 243 ), 241 244 array( 242 245 'title' => $title,
+1 -1
src/applications/transactions/controller/PhabricatorApplicationTransactionCommentEditController.php
··· 65 65 $dialog 66 66 ->addHiddenInput('anchor', $request->getStr('anchor')) 67 67 ->appendChild( 68 - id(new AphrontFormLayoutView()) 68 + id(new PHUIFormLayoutView()) 69 69 ->setFullWidth(true) 70 70 ->appendChild( 71 71 id(new PhabricatorRemarkupControl())
+1 -1
src/applications/transactions/view/PhabricatorApplicationTransactionCommentView.php
··· 146 146 147 147 return id(new AphrontFormView()) 148 148 ->setUser($this->getUser()) 149 - ->setFlexible(true) 150 149 ->addSigil('transaction-append') 151 150 ->setWorkflow(true) 151 + ->setShaded(true) 152 152 ->setMetadata( 153 153 array( 154 154 'objectPHID' => $this->getObjectPHID(),
-1
src/applications/uiexample/examples/PhabricatorFormExample.php
··· 40 40 41 41 $form = id(new AphrontFormView()) 42 42 ->setUser($user) 43 - ->setFlexible(true) 44 43 ->appendChild($start_time) 45 44 ->appendChild($end_time) 46 45 ->appendChild($null_time)
+2 -2
src/applications/uiexample/examples/PhabricatorMultiColumnExample.php
··· 99 99 ->setFluidLayout(true) 100 100 ->setShadow(true); 101 101 102 - $shipping = id(new AphrontFormLayoutView()) 102 + $shipping = id(new PHUIFormLayoutView()) 103 103 ->setUser($user) 104 104 ->setFullWidth(true) 105 105 ->appendChild( ··· 128 128 ->setDisableAutocomplete(true) 129 129 ->setSigil('postal-input')); 130 130 131 - $cc = id(new AphrontFormLayoutView()) 131 + $cc = id(new PHUIFormLayoutView()) 132 132 ->setUser($user) 133 133 ->setFullWidth(true) 134 134 ->appendChild(
-1
src/applications/uiexample/examples/PhabricatorUIListFilterExample.php
··· 17 17 $filter = new AphrontListFilterView(); 18 18 19 19 $form = new AphrontFormView(); 20 - $form->setNoShading(true); 21 20 $form->setUser($this->getRequest()->getUser()); 22 21 $form 23 22 ->appendChild(
+1
src/infrastructure/celerity/CeleritySpriteGenerator.php
··· 526 526 'yellow-header' => 70, 527 527 'grey-header' => 70, 528 528 'dark-grey-header' => 70, 529 + 'lightblue-header' => 70, 529 530 ); 530 531 531 532 $extra_css = array(
+1 -1
src/view/AphrontDialogView.php
··· 11 11 private $class; 12 12 private $renderAsForm = true; 13 13 private $formID; 14 - private $headerColor = PhabricatorActionHeaderView::HEADER_DARK_GREY; 14 + private $headerColor = PhabricatorActionHeaderView::HEADER_LIGHTBLUE; 15 15 private $footers = array(); 16 16 private $isStandalone; 17 17 private $method = 'POST';
-53
src/view/form/AphrontFormLayoutView.php
··· 1 - <?php 2 - 3 - /** 4 - * This provides the layout of an AphrontFormView without actually providing 5 - * the <form /> tag. Useful on its own for creating forms in other forms (like 6 - * dialogs) or forms which aren't submittable. 7 - */ 8 - final class AphrontFormLayoutView extends AphrontView { 9 - 10 - private $backgroundShading; 11 - private $padded; 12 - private $fullWidth; 13 - 14 - public function setBackgroundShading($shading) { 15 - $this->backgroundShading = $shading; 16 - return $this; 17 - } 18 - 19 - public function setPadded($padded) { 20 - $this->padded = $padded; 21 - return $this; 22 - } 23 - 24 - public function setFullWidth($width) { 25 - $this->fullWidth = $width; 26 - return $this; 27 - } 28 - 29 - public function render() { 30 - $classes = array('aphront-form-view'); 31 - 32 - if ($this->backgroundShading) { 33 - $classes[] = 'aphront-form-view-shaded'; 34 - } 35 - 36 - if ($this->padded) { 37 - $classes[] = 'aphront-form-view-padded'; 38 - } 39 - 40 - if ($this->fullWidth) { 41 - $classes[] = 'aphront-form-full-width'; 42 - } 43 - 44 - $classes = implode(' ', $classes); 45 - 46 - return phutil_tag( 47 - 'div', 48 - array( 49 - 'class' => $classes, 50 - ), 51 - $this->renderChildren()); 52 - } 53 - }
+9 -26
src/view/form/AphrontFormView.php
··· 9 9 private $encType; 10 10 private $workflow; 11 11 private $id; 12 - private $flexible; 13 - private $noShading; 12 + private $shaded = false; 14 13 private $sigils = array(); 15 14 private $metadata; 16 15 ··· 24 23 return $this->metadata; 25 24 } 26 25 27 - public function setFlexible($flexible) { 28 - $this->flexible = $flexible; 29 - return $this; 30 - } 31 - 32 - public function setNoShading($shading) { 33 - $this->noShading = $shading; 34 - return $this; 35 - } 36 - 37 26 public function setID($id) { 38 27 $this->id = $id; 39 28 return $this; ··· 51 40 52 41 public function setEncType($enc_type) { 53 42 $this->encType = $enc_type; 43 + return $this; 44 + } 45 + 46 + public function setShaded($shaded) { 47 + $this->shaded = $shaded; 54 48 return $this; 55 49 } 56 50 ··· 88 82 } 89 83 90 84 public function render() { 91 - if ($this->flexible) { 92 - require_celerity_resource('phabricator-form-view-css'); 93 - } 94 - require_celerity_resource('aphront-form-view-css'); 95 85 96 - $layout = new AphrontFormLayoutView(); 97 - 98 - if ((!$this->flexible) && (!$this->noShading)) { 99 - $layout 100 - ->setBackgroundShading(true) 101 - ->setPadded(true); 102 - } 103 - 104 - $layout 86 + require_celerity_resource('phui-form-view-css'); 87 + $layout = id (new PHUIFormLayoutView()) 105 88 ->appendChild($this->renderDataInputs()) 106 89 ->appendChild($this->renderChildren()); 107 90 ··· 117 100 return phabricator_form( 118 101 $this->user, 119 102 array( 120 - 'class' => $this->flexible ? 'phabricator-form-view' : null, 103 + 'class' => $this->shaded ? 'phui-form-shaded' : null, 121 104 'action' => $this->action, 122 105 'method' => $this->method, 123 106 'enctype' => $this->encType,
+43
src/view/form/PHUIFormBoxView.php
··· 1 + <?php 2 + 3 + final class PHUIFormBoxView extends AphrontView { 4 + 5 + private $headerText; 6 + private $formError = null; 7 + private $form; 8 + 9 + public function setHeaderText($text) { 10 + $this->headerText = $text; 11 + return $this; 12 + } 13 + 14 + public function setFormError($error) { 15 + $this->formError = $error; 16 + return $this; 17 + } 18 + 19 + public function setForm(AphrontFormView $form) { 20 + $this->form = $form; 21 + return $this; 22 + } 23 + 24 + public function render() { 25 + 26 + $error = $this->formError ? $this->formError : null; 27 + 28 + $header = id(new PhabricatorActionHeaderView()) 29 + ->setHeaderTitle($this->headerText) 30 + ->setHeaderColor(PhabricatorActionHeaderView::HEADER_LIGHTBLUE); 31 + 32 + $content = id(new PHUIBoxView()) 33 + ->appendChild(array($header, $error, $this->form)) 34 + ->setBorder(true) 35 + ->addMargin(PHUI::MARGIN_LARGE_TOP) 36 + ->addMargin(PHUI::MARGIN_LARGE_LEFT) 37 + ->addMargin(PHUI::MARGIN_LARGE_RIGHT) 38 + ->addClass('phui-form-box'); 39 + 40 + return $content; 41 + 42 + } 43 + }
+32
src/view/form/PHUIFormLayoutView.php
··· 1 + <?php 2 + 3 + /** 4 + * This provides the layout of an AphrontFormView without actually providing 5 + * the <form /> tag. Useful on its own for creating forms in other forms (like 6 + * dialogs) or forms which aren't submittable. 7 + */ 8 + final class PHUIFormLayoutView extends AphrontView { 9 + 10 + private $fullWidth; 11 + 12 + public function setFullWidth($width) { 13 + $this->fullWidth = $width; 14 + return $this; 15 + } 16 + 17 + public function render() { 18 + $classes = array('phui-form-view'); 19 + 20 + if ($this->fullWidth) { 21 + $classes[] = 'phui-form-full-width'; 22 + } 23 + 24 + return phutil_tag( 25 + 'div', 26 + array( 27 + 'class' => implode(' ', $classes), 28 + ), 29 + $this->renderChildren()); 30 + 31 + } 32 + }
+1
src/view/layout/PhabricatorActionHeaderView.php
··· 11 11 const HEADER_GREEN = 'green'; 12 12 const HEADER_RED = 'red'; 13 13 const HEADER_YELLOW = 'yellow'; 14 + const HEADER_LIGHTBLUE ='lightblue'; 14 15 15 16 private $headerTitle; 16 17 private $headerHref;
+9
src/view/phui/PHUIBoxView.php
··· 5 5 private $margin = array(); 6 6 private $padding = array(); 7 7 private $shadow = false; 8 + private $border = false; 8 9 9 10 public function addMargin($margin) { 10 11 $this->margin[] = $margin; ··· 21 22 return $this; 22 23 } 23 24 25 + public function setBorder($border) { 26 + $this->border = $border; 27 + return $this; 28 + } 29 + 24 30 public function getTagContent() { 25 31 26 32 require_celerity_resource('phui-box-css'); ··· 29 35 $outer_classes[] = 'phui-box'; 30 36 if ($this->shadow) { 31 37 $outer_classes[] = 'phui-box-shadow'; 38 + } 39 + if ($this->border) { 40 + $outer_classes[] = 'phui-box-border'; 32 41 } 33 42 foreach ($this->margin as $margin) { 34 43 $outer_classes[] = $margin;
+8 -1
src/view/phui/PHUIRemarkupPreviewPanel.php
··· 115 115 116 116 switch ($this->skin) { 117 117 case 'document': 118 - $content = id(new PHUIDocumentView())->appendChild($content); 118 + $content = id(new PHUIDocumentView()) 119 + ->appendChild($content); 119 120 break; 120 121 default: 122 + $content = id(new PHUIBoxView()) 123 + ->appendChild($content) 124 + ->setBorder(true) 125 + ->addMargin(PHUI::MARGIN_LARGE) 126 + ->addPadding(PHUI::PADDING_LARGE) 127 + ->addClass('phui-panel-preview'); 121 128 break; 122 129 } 123 130
+13 -20
webroot/rsrc/css/aphront/dialog-view.css
··· 5 5 .aphront-dialog-view { 6 6 width: 540px; 7 7 margin: 32px auto 16px; 8 - border-radius: 6px; 8 + border: 1px solid #bfcfda; 9 + border-bottom: 1px solid #95a6c5; 9 10 box-shadow: 0 1px 5px rgba(0, 0, 0, 0.25), 10 11 inset 0 1px 0 rgba(255, 255, 255, 0.5); 11 12 } ··· 15 16 width: auto; 16 17 } 17 18 18 - /* The "standalone" dialog (which is delivered over Ajax and appears above 19 - an existing page) has a more pronounced shadow than dialogs do when they 20 - are embedded in a page. */ 21 19 .aphront-dialog-view-standalone { 22 - box-shadow: 0 4px 12px rgba(0, 0, 0, 0.4), 23 - inset 0 1px 0 rgba(255, 255, 255, 0.5); 24 20 margin: auto; 25 21 } 26 - 27 22 28 23 .aphront-dialog-head .phabricator-action-header { 29 24 border-bottom: 1px solid #d4dadf; 30 25 padding: 4px 16px; 31 26 white-space: nowrap; 32 - border-top-left-radius: 6px; 33 - border-top-right-radius: 6px; 34 27 } 35 28 36 29 .aphront-dialog-head .phabricator-action-header 37 30 .phabricator-action-header-title { 38 31 font-size: 15px; 32 + color: #6b748c; 33 + text-shadow: 0 1px 2px #fff; 39 34 } 40 35 41 36 .aphront-dialog-view-width-form { ··· 54 49 55 50 .aphront-dialog-tail { 56 51 border: none; 57 - background: #fff; 52 + background: #f7f7f7; 58 53 padding: 8px 16px; 59 54 border-top: 1px solid #d4dadf; 60 - border-bottom-left-radius: 6px; 61 - border-bottom-right-radius: 6px; 62 55 } 63 56 64 57 .aphront-dialog-foot { ··· 69 62 .aphront-dialog-tail button, 70 63 .aphront-dialog-tail a.button { 71 64 float: right; 72 - margin-left: .5em; 65 + margin-left: 8px; 73 66 } 74 67 75 68 .jx-client-dialog { ··· 78 71 } 79 72 80 73 .jx-mask { 81 - opacity: .37; 82 - background: #222; 83 - position: fixed; 84 - top: 0; 85 - left: 0; 86 - right: 0; 87 - bottom: 0; 74 + opacity: .75; 75 + background: #fff; 76 + position: fixed; 77 + top: 0; 78 + left: 0; 79 + right: 0; 80 + bottom: 0; 88 81 } 89 82 90 83 .jx-dark-mask {
+7 -13
webroot/rsrc/css/aphront/error-view.css
··· 13 13 } 14 14 15 15 .aphront-error-view { 16 - margin: 20px; 16 + margin: 16px; 17 17 } 18 18 .aphront-error-view-dialogue { 19 19 margin: 0px 0px 16px 0px; 20 20 } 21 21 22 22 .device-phone .aphront-error-view { 23 - margin: 10px; 23 + margin: 8px; 24 24 } 25 25 26 26 .aphront-error-view-body { 27 - padding: 10px; 28 - line-height: 1.6em; 27 + padding: 12px; 29 28 } 30 29 31 30 .aphront-error-view-head { ··· 35 34 } 36 35 37 36 .aphront-error-view-list { 38 - margin: 0 0 0 20px; 37 + margin: 0 0 0 16px; 39 38 list-style: disc; 40 39 } 41 40 ··· 70 69 } 71 70 72 71 .aphront-error-severity-nodata { 73 - border-color: #dfdfdf; 74 - background: #f3f3f3; 75 - color: #666; 76 - } 77 - 78 - .make-me-sneeze .aphront-error-severity-nodata { 79 - background: #fff; 80 - border-color: #e6e6e6; 72 + border-color: #ccc; 73 + color: #6b748c; 74 + background-color: #fff; 81 75 }
+54 -39
webroot/rsrc/css/aphront/form-view.css webroot/rsrc/css/phui/phui-form-view.css
··· 1 1 /** 2 - * @provides aphront-form-view-css 2 + * @provides phui-form-view-css 3 3 */ 4 4 5 - /** 6 - * These styles are overrides for .aphront-form-view 7 - */ 8 - .aphront-form-view-shaded { 9 - border-top: 1px solid #d4dae0; 10 - border-bottom: 1px solid #d4dae0; 11 - background: #f4f5f8; 5 + .phui-form-view { 6 + padding: 16px; 7 + background: #fff; 12 8 } 13 9 14 - .aphront-panel-width-form .aphront-form-view-shaded { 15 - border: 1px solid #d4dae0; 10 + .phui-form-view.phui-form-full-width { 11 + padding: 0; 16 12 } 17 13 18 - .aphront-form-view-padded { 19 - padding: 1em; 14 + /* only used in transaction comments */ 15 + .phui-form-shaded .phui-form-view { 16 + border-bottom: 1px solid #D4DAE0; 17 + background: #F4F5F8; 20 18 } 21 19 22 - .aphront-form-view label.aphront-form-label { 20 + .phui-form-view label.aphront-form-label { 23 21 padding-top: 5px; 24 22 width: 19%; 25 23 float: left; 26 24 text-align: right; 27 25 font-weight: bold; 28 26 font-size: 13px; 29 - color: #757c88; 30 - text-shadow: 0 1px rgba(255,255,255,1); 27 + color: #6b748c; 28 + -webkit-font-smoothing: antialiased; 31 29 } 32 30 33 - .device-phone .aphront-form-view label.aphront-form-label, 34 - .aphront-form-full-width.aphront-form-view label.aphront-form-label { 31 + .device-phone .phui-form-view label.aphront-form-label, 32 + .phui-form-full-width.phui-form-view label.aphront-form-label { 35 33 display: block; 36 34 float: none; 37 35 text-align: left; ··· 46 44 } 47 45 48 46 .device-phone .aphront-form-input, 49 - .aphront-form-full-width .aphront-form-input { 47 + .phui-form-full-width .aphront-form-input { 50 48 margin-left: 0%; 51 49 margin-right: 0%; 52 50 width: 100%; ··· 60 58 padding-top: 5px; 61 59 } 62 60 63 - .aphront-dialog-body .aphront-form-full-width { 61 + .aphront-dialog-body .phui-form-full-width { 64 62 margin-top: -10px; 65 63 } 66 64 65 + .aphront-dialog-body .phui-form-view { 66 + padding: 0; 67 + } 68 + 67 69 .device-phone .aphront-form-error, 68 - .aphront-form-full-width .aphront-form-error { 70 + .phui-form-full-width .aphront-form-error { 69 71 float: none; 70 72 width: 100%; 71 73 } ··· 76 78 77 79 .aphront-form-required { 78 80 font-weight: normal; 79 - color: #888888; 81 + color: #6b748c; 80 82 font-size: 11px; 83 + -webkit-font-smoothing: antialiased; 81 84 } 82 85 83 86 .aphront-form-input input { ··· 95 98 padding: 4px; 96 99 } 97 100 98 - .aphront-form-full-width .aphront-form-control { 101 + .phui-form-full-width .aphront-form-control { 99 102 padding: 4px 0; 100 103 } 101 104 102 105 .aphront-form-control-submit button, 103 106 .aphront-form-control-submit a.button { 104 107 float: right; 105 - margin: 0.5em 0 0 2%; 108 + margin: 4px 0 0 8px; 106 109 } 107 110 108 111 .phui-form-control-multi-submit input { ··· 123 126 padding-top: 2px; 124 127 } 125 128 126 - .aphront-form-view .aphront-form-caption { 129 + .phui-form-view .aphront-form-caption { 127 130 font-size: 12px; 128 - color: #888; 129 - padding: 2px; 131 + color: #6b748c; 132 + padding: 8px 4px; 130 133 text-align: right; 131 134 margin-right: 20%; 132 135 margin-left: 20%; 136 + -webkit-font-smoothing: antialiased; 137 + line-height: 15px; 133 138 } 134 139 135 - .device-phone .aphront-form-view .aphront-form-caption, 136 - .aphront-form-full-width .aphront-form-view .aphront-form-caption { 140 + .device-phone .phui-form-view .aphront-form-caption, 141 + .phui-form-full-width .phui-form-view .aphront-form-caption { 137 142 margin-right: 0%; 138 143 } 139 144 140 145 /* override for when inside an aphront-panel-view */ 141 - .aphront-panel-view .aphront-form-view h1 { 146 + .aphront-panel-view .phui-form-view h1 { 142 147 padding: 0em 0em .8em 0em; 143 148 } 144 149 ··· 147 152 margin-left: 20%; 148 153 padding: 10px 4px; 149 154 } 150 - 151 - 152 155 153 156 .device .aphront-form-instructions, 154 - .aphront-form-full-width .aphront-form-instructions { 157 + .phui-form-full-width .aphront-form-instructions { 155 158 width: 100%; 156 159 margin: 0; 157 160 } ··· 199 202 color: #222222; 200 203 } 201 204 202 - 203 205 .aphront-form-control-radio-layout td input, 204 206 .aphront-form-control-checkbox-layout td input { 205 207 margin-top: 4px; 206 208 width: auto; 207 209 } 208 - 209 210 210 211 .aphront-form-control-radio-layout label.disabled, 211 212 .aphront-form-control-checkbox-layout label.disabled { ··· 236 237 } 237 238 238 239 .aphront-form-inset { 239 - margin: 0 0 10px; 240 - padding: 10px; 240 + margin: 0 0 8px; 241 + padding: 8px; 241 242 background: #fff; 242 243 border: 1px solid #d4dae0; 243 244 } ··· 245 246 .aphront-form-inset h1 { 246 247 color: #777; 247 248 font-weight: normal; 248 - padding-bottom: 10px; 249 + padding-bottom: 8px; 249 250 } 250 251 251 252 .aphront-form-drag-and-drop-file-list { ··· 260 261 261 262 .drag-and-drop-file-target { 262 263 border: 1px dashed #bfbfbf; 263 - padding-top: 10px; 264 - padding-bottom: 10px; 264 + padding-top: 12px; 265 + padding-bottom: 12px; 265 266 } 266 267 267 268 .aphront-textarea-drag-and-drop { ··· 424 425 .recaptcha_only_if_privacy { 425 426 display: none; 426 427 } 428 + 429 + .phui-form-box .phabricator-action-header { 430 + padding: 4px 5px 4px 12px; 431 + border-bottom: 1px solid #bfcfda; 432 + } 433 + 434 + .phui-form-box .phabricator-action-header h3 { 435 + color: #6b748c; 436 + text-shadow: 0 1px 2px #fff; 437 + } 438 + 439 + .phui-form-box .aphront-error-view { 440 + margin-bottom: 0; 441 + }
+4 -4
webroot/rsrc/css/aphront/list-filter-view.css
··· 20 20 margin: 0 -2px; 21 21 } 22 22 23 - .aphront-list-filter-view-content .aphront-form-view { 23 + .aphront-list-filter-view-content .phui-form-view { 24 24 border-left: none; 25 25 border-right: none; 26 26 padding: 12px 0 6px; 27 27 } 28 28 29 - .aphront-list-filter-view-content .aphront-form-view .aphront-form-label { 29 + .aphront-list-filter-view-content .phui-form-view .aphront-form-label { 30 30 width: 12%; 31 31 } 32 32 33 - .aphront-list-filter-view-content .aphront-form-view .aphront-form-input { 33 + .aphront-list-filter-view-content .phui-form-view .aphront-form-input { 34 34 width: 70%; 35 35 margin-left: 13%; 36 36 margin-right: 17%; 37 37 } 38 38 39 - .device-phone .aphront-list-filter-view-content .aphront-form-view 39 + .device-phone .aphront-list-filter-view-content .phui-form-view 40 40 .aphront-form-input { 41 41 width: 98%; 42 42 margin-left: 0;
+2 -2
webroot/rsrc/css/aphront/panel-view.css
··· 70 70 border-radius: 3px; 71 71 } 72 72 73 - .aphront-panel-accent .aphront-form-view { 73 + .aphront-panel-accent .phui-form-view { 74 74 background: #f7f7f7; 75 75 border: 1px solid #c4c4c0; 76 76 border-radius: 3px; ··· 107 107 border-color: #669966; 108 108 } 109 109 110 - .aphront-panel-view-drag-and-drop .aphront-form-view { 110 + .aphront-panel-view-drag-and-drop .phui-form-view { 111 111 background: #ccffcc; 112 112 border-color: #669966; 113 113 }
+5 -5
webroot/rsrc/css/application/conpherence/message-pane.css
··· 74 74 display: block; 75 75 } 76 76 77 - .conpherence-message-pane .phabricator-form-view { 77 + .conpherence-message-pane .phui-form-view { 78 78 border-width: 0; 79 79 background: none; 80 80 height: 190px; ··· 89 89 height: 0px; 90 90 } 91 91 92 - .device .conpherence-message-pane .phabricator-form-view { 92 + .device .conpherence-message-pane .phui-form-view { 93 93 left: 0; 94 94 right: 0; 95 95 background-color: #d8dce2; ··· 97 97 width: 100%; 98 98 } 99 99 100 - .conpherence-layout .conpherence-message-pane .phabricator-form-view 100 + .conpherence-layout .conpherence-message-pane .phui-form-view 101 101 div.aphront-form-input { 102 102 margin: 0; 103 103 width: 100%; ··· 188 188 .conpherence-message-pane .remarkup-assist-textarea { 189 189 height: 124px; 190 190 padding: 6px; 191 - border-width: 0 0 1px 0; 192 - border-color: #e7e7e7; 191 + border-width: 1px 0; 192 + border-color: #BFCFDA; 193 193 box-sizing: border-box; 194 194 -moz-box-sizing: border-box; 195 195 -webkit-box-sizing: border-box;
+3 -2
webroot/rsrc/css/core/core.css
··· 61 61 } 62 62 63 63 body { 64 - font: 13px/1.231 'Helvetica Neue', Arial, sans-serif; 64 + font: 13px/1.231 'Helvetica Neue', Helvetica, Arial, sans-serif; 65 65 direction: ltr; 66 66 text-align: left; 67 67 unicode-bidi: embed; 68 - background: #EBECEE; 68 + background: #ebecee; 69 + text-rendering: optimizeLegibility; 69 70 } 70 71 71 72 textarea {
+13 -9
webroot/rsrc/css/core/remarkup.css
··· 255 255 padding: 3px 6px; 256 256 } 257 257 258 - 259 258 .remarkup-assist-textarea { 260 - border-left-color: #96A6C5; 261 - border-right-color: #96A6C5; 262 - border-bottom-color: #96A6C5; 263 - border-top-color: #c9d4e9; 259 + border-left-color: #95a6c5; 260 + border-right-color: #95a6c5; 261 + border-bottom-color: #95a6c5; 262 + border-top-color: #bfcfda; 264 263 border-radius: 0; 265 264 266 265 /* Prevent Safari and Chrome users from dragging the textarea any wider, ··· 278 277 279 278 border-width: 1px 1px 0; 280 279 border-style: solid; 281 - border-top-color: #96A6C5; 282 - border-left-color: #96A6C5; 283 - border-right-color: #96A6C5; 280 + border-top-color: #95a6c5; 281 + border-left-color: #95a6c5; 282 + border-right-color: #95a6c5; 284 283 285 - background: #f5f5f5; 284 + background: #F8F9FC; 286 285 overflow: hidden; 287 286 } 288 287 ··· 337 336 .jx-order-mask { 338 337 background: #ffffff; 339 338 opacity: 1.0; 339 + } 340 + 341 + .remarkup-assist-textarea { 342 + box-shadow: none; 343 + -webkit-box-shadow: none; 340 344 } 341 345 342 346 .remarkup-control-order-mode {
-48
webroot/rsrc/css/layout/phabricator-form-view.css
··· 1 - /** 2 - * @provides phabricator-form-view-css 3 - */ 4 - 5 - .phabricator-form-view { 6 - padding: 20px; 7 - background: #f4f5f8; 8 - border-width: 1px 0; 9 - border-style: solid; 10 - border-color: rgb(199, 201, 214); 11 - } 12 - 13 - .device-phone .phabricator-form-view { 14 - padding: 10px 5px 10px 10px; 15 - } 16 - 17 - .device .phabricator-form-view .aphront-form-control .aphront-form-label { 18 - display: block; 19 - float: none; 20 - text-align: left; 21 - margin: 0; 22 - padding: 0; 23 - } 24 - 25 - .device .phabricator-form-view .aphront-form-control .aphront-form-caption { 26 - display: block; 27 - float: none; 28 - text-align: left; 29 - margin: 0; 30 - padding: 0; 31 - } 32 - 33 - .device .phabricator-form-view .aphront-form-control .aphront-form-input { 34 - float: none; 35 - display: block; 36 - text-align: left; 37 - margin: .25em 0 0 0; 38 - width: 99%; 39 - padding: 0; 40 - } 41 - 42 - .device .phabricator-form-view .aphront-form-control .aphront-form-error { 43 - float: none; 44 - text-align: left; 45 - display: block; 46 - margin: 0; 47 - padding: 0; 48 - }
+1 -1
webroot/rsrc/css/layout/phabricator-side-menu-view.css
··· 27 27 padding: 6px 8px 4px 12px; 28 28 color: #f7f7f7; 29 29 text-transform: uppercase; 30 - font-size: 12px; 30 + font-size: 11px; 31 31 font-weight: bold; 32 32 border-style: solid; 33 33 background-color: #000;
+16
webroot/rsrc/css/phui/phui-box.css
··· 12 12 background-color: #fff; 13 13 box-shadow: 0 1px 2px rgba(0,0,0,0.2); 14 14 } 15 + 16 + .phui-box-border { 17 + border: 1px solid #bfcfda; 18 + border-bottom: 1px solid #95a6c5; 19 + } 20 + 21 + .phui-box-border .phui-box-inner { 22 + background-color: #fff; 23 + } 24 + 25 + .device-phone .phui-box { 26 + border-left: none; 27 + border-right: none; 28 + margin-left: 0; 29 + margin-right: 0; 30 + }
+3 -2
webroot/rsrc/css/phui/phui-form.css
··· 24 24 line-height: 18px; 25 25 color: #333; 26 26 vertical-align: middle; 27 - font: 13px 'Helvetica Neue', Arial, sans-serif; 27 + font: 13px 'Helvetica Neue', Helvetica, Arial, sans-serif; 28 + -webkit-font-smoothing: antialiased; 28 29 } 29 30 30 31 textarea, ··· 45 46 div.jx-tokenizer-container { 46 47 padding: 4px 6px; 47 48 background-color: #ffffff; 48 - border: 1px solid #96A6C5; 49 + border: 1px solid #95a6c5; 49 50 50 51 -webkit-box-shadow: inset 0 1px 1px rgba(0, 0, 0, 0.075); 51 52 -moz-box-shadow: inset 0 1px 1px rgba(0, 0, 0, 0.075);
+10 -14
webroot/rsrc/css/phui/phui-remarkup-preview.css
··· 3 3 */ 4 4 5 5 .phui-preview-header { 6 - color: #666666; 7 - margin-bottom: 12px; 8 - font-size: 11px; 6 + font-size: 12px; 7 + font-weight: bold; 8 + color: #9ca5b5; 9 + text-transform: uppercase; 10 + padding-bottom: 8px; 11 + display: block; 9 12 } 10 13 11 - .phui-remarkup-preview { 12 - background: #fbfbfb; 13 - border-bottom: 1px solid #aaaaaa; 14 - padding: 12px; 14 + .phui-document-inner .phui-preview-header { 15 + padding: 16px 0 0 16px; 15 16 } 16 17 17 18 .phui-remarkup-preview-skin-document { ··· 19 20 border: none; 20 21 } 21 22 22 - .phui-remarkup-preview-skin-document .phui-preview-header { 23 - padding: 8px; 24 - background: #f3f3f3; 25 - } 26 - 27 - .device-phone .aphront-panel-preview { 23 + .device-phone .phui-panel-preview { 28 24 display: none; 29 25 } 30 26 31 27 .phui-preview-loading-text { 32 - color: #666666; 28 + color: #999; 33 29 } 34 30 35 31 /**
+6 -2
webroot/rsrc/css/sprite-gradient.css
··· 35 35 background-position: 0px -296px; 36 36 } 37 37 38 + .gradient-lightblue-header { 39 + background-position: 0px -367px; 40 + } 41 + 38 42 .gradient-menu-label, .phabricator-side-menu .phui-list-item-type-label { 39 43 background-position: 0px 0px; 40 44 } 41 45 42 46 .gradient-red-header { 43 - background-position: 0px -367px; 47 + background-position: 0px -438px; 44 48 } 45 49 46 50 .gradient-yellow-header { 47 - background-position: 0px -438px; 51 + background-position: 0px -509px; 48 52 }
webroot/rsrc/image/sprite-gradient.png

This is a binary file and will not be displayed.