recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Don't copy `null` attributes passed to JX.$N()

Summary:
Fixes T8919. In Safari, `node.href = null;` has no effect, but in Chrome it is like `node.href = "null";`.

Instead, just use semantics similar to `phutil_tag()`: don't assign attributes with `null` values.

Test Plan:
No more `/null` href in Chrome in Owners typehaead.

Typeahead still works in Chrome/Safari.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T8919

Differential Revision: https://secure.phabricator.com/D14021

epriestley fe66d52a 9159c0e0

+7 -1
+7 -1
webroot/rsrc/externals/javelin/lib/DOM.js
··· 310 310 } 311 311 } 312 312 313 - JX.copy(node, attr); 313 + for (var k in attr) { 314 + if (attr[k] === null) { 315 + continue; 316 + } 317 + node[k] = attr[k]; 318 + } 319 + 314 320 if (content) { 315 321 JX.DOM.setContent(node, content); 316 322 }