@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Allow setting of tabs at StandardPageView
Summary: Rather than have tabs live in two column view, sometimes like `admin` we'll want a global set of tabs that work well with all layouts and crumbs.
Test Plan:
I tested this in an upcoming diff for instances.
{F5080228}
Reviewers: epriestley
Reviewed By: epriestley
Subscribers: Korvin
Differential Revision: https://secure.phabricator.com/D18332
+35
-3
+3
-3
resources/celerity/map.php
+3
-3
resources/celerity/map.php
···
9
9
'names' => array(
10
10
'conpherence.pkg.css' => 'e68cf1fa',
11
11
'conpherence.pkg.js' => 'b5b51108',
12
-
'core.pkg.css' => 'd9c9cfd0',
12
+
'core.pkg.css' => '851ae625',
13
13
'core.pkg.js' => '5d80e0db',
14
14
'darkconsole.pkg.js' => '1f9a31bc',
15
15
'differential.pkg.css' => '45951e9e',
···
42
42
'rsrc/css/application/base/main-menu-view.css' => '16053029',
43
43
'rsrc/css/application/base/notification-menu.css' => '73fefdfa',
44
44
'rsrc/css/application/base/phui-theme.css' => '9f261c6b',
45
-
'rsrc/css/application/base/standard-page-view.css' => 'eb5b80c5',
45
+
'rsrc/css/application/base/standard-page-view.css' => 'a0dae682',
46
46
'rsrc/css/application/chatlog/chatlog.css' => 'd295b020',
47
47
'rsrc/css/application/conduit/conduit-api.css' => '7bc725c4',
48
48
'rsrc/css/application/config/config-options.css' => 'd55ed093',
···
802
802
'phabricator-shaped-request' => '7cbe244b',
803
803
'phabricator-slowvote-css' => 'a94b7230',
804
804
'phabricator-source-code-view-css' => 'aea41829',
805
-
'phabricator-standard-page-view' => 'eb5b80c5',
805
+
'phabricator-standard-page-view' => 'a0dae682',
806
806
'phabricator-textareautils' => '320810c8',
807
807
'phabricator-title' => '485aaa6c',
808
808
'phabricator-tooltip' => '358b8c04',
+21
src/view/page/PhabricatorStandardPageView.php
+21
src/view/page/PhabricatorStandardPageView.php
···
19
19
private $showFooter = true;
20
20
private $showDurableColumn = true;
21
21
private $quicksandConfig = array();
22
+
private $tabs;
22
23
private $crumbs;
23
24
private $navigation;
24
25
···
157
158
158
159
public function getCrumbs() {
159
160
return $this->crumbs;
161
+
}
162
+
163
+
public function setTabs(PHUIListView $tabs) {
164
+
$tabs->setType(PHUIListView::TABBAR_LIST);
165
+
$tabs->addClass('phabricator-standard-page-tabs');
166
+
$this->tabs = $tabs;
167
+
return $this;
168
+
}
169
+
170
+
public function getTabs() {
171
+
return $this->tabs;
160
172
}
161
173
162
174
public function setNavigation(AphrontSideNavFilterView $navigation) {
···
528
540
$footer = $this->renderFooter();
529
541
530
542
$nav = $this->getNavigation();
543
+
$tabs = $this->getTabs();
531
544
if ($nav) {
532
545
$crumbs = $this->getCrumbs();
533
546
if ($crumbs) {
···
541
554
542
555
$crumbs = $this->getCrumbs();
543
556
if ($crumbs) {
557
+
if ($this->getTabs()) {
558
+
$crumbs->setBorder(true);
559
+
}
544
560
$content[] = $crumbs;
561
+
}
562
+
563
+
$tabs = $this->getTabs();
564
+
if ($tabs) {
565
+
$content[] = $tabs;
545
566
}
546
567
547
568
$content[] = $body;
+11
webroot/rsrc/css/application/base/standard-page-view.css
+11
webroot/rsrc/css/application/base/standard-page-view.css
···
176
176
position: absolute;
177
177
left: -50px;
178
178
}
179
+
180
+
.phabricator-standard-page-tabs {
181
+
padding: 0 32px;
182
+
margin-bottom: 32px;
183
+
background: {$page.content};
184
+
box-shadow: 0 0 3px 0 rgba(0,0,0,0.2);
185
+
}
186
+
187
+
.phabricator-standard-page-tabs.phui-list-tabbar .phui-list-item-href {
188
+
padding: 12px 24px;
189
+
}