@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Make macro audio errors more clear
Summary: Ref T12685. I bamboozled myself.
Test Plan: {F4945786}
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T12685
Differential Revision: https://secure.phabricator.com/D17847
+6
-2
+6
-2
src/applications/macro/controller/PhabricatorMacroAudioController.php
+6
-2
src/applications/macro/controller/PhabricatorMacroAudioController.php
···
50
50
51
51
if ($file) {
52
52
if (!$file->isAudio()) {
53
-
$errors[] = pht('You must upload audio.');
53
+
$errors[] = pht(
54
+
'The file you uploaded is invalid: it is not recognizable as '.
55
+
'a valid audio file.');
54
56
$e_file = pht('Invalid');
55
57
} else {
56
58
$xactions[] = id(new PhabricatorMacroTransaction())
···
59
61
->setNewValue($file->getPHID());
60
62
}
61
63
} else {
62
-
$errors[] = pht('You must upload an audio file.');
64
+
$errors[] = pht(
65
+
'To change the audio for a macro, you must upload an audio '.
66
+
'file.');
63
67
$e_file = pht('Required');
64
68
}
65
69
}