@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Don't drop "phabricator-remarkup-embed-image" class from Remarkup images with `width` or `height`
Summary: Ref T10110. If an image had `width` or `height`, we would accidentally not give it an `$image_class`.
Test Plan:
{F1057988}
{F1057989}
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T10110
Differential Revision: https://secure.phabricator.com/D14983
+1
-3
+1
-3
src/applications/files/markup/PhabricatorEmbedFileRemarkupRule.php
+1
-3
src/applications/files/markup/PhabricatorEmbedFileRemarkupRule.php
···
79
79
require_celerity_resource('lightbox-attachment-css');
80
80
81
81
$attrs = array();
82
-
$image_class = null;
82
+
$image_class = 'phabricator-remarkup-embed-image';
83
83
84
84
$use_size = true;
85
85
if (!$options['size']) {
···
117
117
$attrs['width'] = $x;
118
118
$attrs['height'] = $y;
119
119
}
120
-
121
-
$image_class = 'phabricator-remarkup-embed-image';
122
120
break;
123
121
}
124
122
}