@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix an issue where email for "accepted" revisions would fatal
Summary: When trying to render "BRANCH", we need the active diff. Load it
in general since it seems reasonable for custom fields to expect it to
exist during mail rendering.
+2
+2
src/applications/differential/editor/DifferentialTransactionEditor.php
+2
src/applications/differential/editor/DifferentialTransactionEditor.php
···
587
587
$new_revision = id(new DifferentialRevisionQuery())
588
588
->setViewer($this->getActor())
589
589
->needReviewerStatus(true)
590
+
->needActiveDiffs(true)
590
591
->withIDs(array($object->getID()))
591
592
->executeOne();
592
593
if (!$new_revision) {
···
595
596
}
596
597
597
598
$object->attachReviewerStatus($new_revision->getReviewerStatus());
599
+
$object->attachActiveDiff($new_revision->getActiveDiff());
598
600
599
601
foreach ($xactions as $xaction) {
600
602
switch ($xaction->getTransactionType()) {