@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Restrict Differential buckets to just ApplicationSearch views
Summary: Ref T9363, If we're in a dashboard panel, only show buckets with data, or a fallback if nothing exists.
Test Plan: Test 'active revisions' panel in a dashboard and in Differential.
Reviewers: epriestley
Reviewed By: epriestley
Subscribers: Korvin
Maniphest Tasks: T9363
Differential Revision: https://secure.phabricator.com/D17544
+13
-4
+13
-4
src/applications/differential/query/DifferentialRevisionSearchEngine.php
+13
-4
src/applications/differential/query/DifferentialRevisionSearchEngine.php
···
162
162
$groups = $bucket->newResultGroups($query, $revisions);
163
163
164
164
foreach ($groups as $group) {
165
-
$views[] = id(clone $template)
166
-
->setHeader($group->getName())
167
-
->setNoDataString($group->getNoDataString())
168
-
->setRevisions($group->getObjects());
165
+
// Don't show groups in Dashboard Panels
166
+
if ($group->getObjects() || !$this->isPanelContext()) {
167
+
$views[] = id(clone $template)
168
+
->setHeader($group->getName())
169
+
->setNoDataString($group->getNoDataString())
170
+
->setRevisions($group->getObjects());
171
+
}
169
172
}
170
173
} catch (Exception $ex) {
171
174
$this->addError($ex->getMessage());
···
174
177
$views[] = id(clone $template)
175
178
->setRevisions($revisions)
176
179
->setHandles(array());
180
+
}
181
+
182
+
if (!$views) {
183
+
$views[] = id(new DifferentialRevisionListView())
184
+
->setUser($viewer)
185
+
->setNoDataString(pht('No revisions found.'));
177
186
}
178
187
179
188
$phids = array_mergev(mpull($views, 'getRequiredHandlePHIDs'));