roost.tools / coop
Mirror of https://github.com/roostorg/coop github.com/roostorg/coop
2
fork

Configure Feed

Select the types of activity you want to include in your feed.

fix: contain Radix Switch hidden inputs in proactive rule form (#368)

* fix: contain Radix Switch hidden inputs in proactive rule form

Radix's <Switch> renders a hidden absolutely-positioned <input>. With
no positioned ancestor, its containing block defaulted to <html>, so
it escaped the rule form's scroll container and extended document
scroll height past the form's actual content -- leaving the empty
whitespace below "Create Rule" when Advanced Settings was expanded.

`position: relative` on the form's outer wrapper makes it the
containing block, keeping the hidden inputs inside the form's layout
box and the scroll container.

Closes #168.

* Shorten form wrapper comment per review feedback

authored by

Samuel Ralak and committed by
GitHub 58a6800b 5be8972d

+2 -1
+2 -1
client/src/webpages/dashboard/rules/rule_form/RuleForm.tsx
··· 1870 1870 */ 1871 1871 1872 1872 return ( 1873 - <div className="flex flex-col test-start"> 1873 + // relative to prevent overflow/scrolling issues; see issue #168 1874 + <div className="flex flex-col test-start relative"> 1874 1875 <Helmet> 1875 1876 <title>{id == null ? 'Create Rule' : 'Update Rule'}</title> 1876 1877 </Helmet>