+2

network/protocol/pktline/chunk_writer.go

reviewed

··· 4 4 5 5 // ChunkWriter packetizes arbitrary stream bytes into data pkt-lines. 6 6 // It never writes control packets automatically. 7 7 + // 8 8 + // Labels: MT-Unsafe. 7 9 type ChunkWriter struct { 8 10 enc *Encoder 9 11 }

+2

network/protocol/pktline/decoder.go

reviewed

··· 17 17 // It is advisable to supply a buffered reader. 18 18 // 19 19 // It preserves frame boundaries and supports one-frame lookahead via PeekFrame. 20 20 + // 21 21 + // Labels: MT-Unsafe. 20 22 type Decoder struct { 21 23 r io.Reader 22 24 maxData int

+2

network/protocol/pktline/encoder.go

reviewed

··· 10 10 // Encoder writes pkt-line frames to a flush-capable output transport. 11 11 // 12 12 // It writes exactly one frame per method call and does not auto-chunk data. 13 13 + // 14 14 + // Labels: MT-Unsafe. 13 15 type Encoder struct { 14 16 w iowrap.WriteFlusher 15 17 maxData int

+2

network/protocol/sideband64k/chunk_writer.go

reviewed

··· 6 6 // for one fixed band. 7 7 // 8 8 // It never writes control packets automatically. 9 9 + // 10 10 + // Labels: MT-Unsafe. 9 11 type ChunkWriter struct { 10 12 enc *Encoder 11 13 band Band

+2

network/protocol/sideband64k/decoder.go

reviewed

··· 17 17 // 18 18 // It preserves frame boundaries and supports one-frame lookahead via 19 19 // PeekFrame. 20 20 + // 21 21 + // Labels: MT-Unsafe. 20 22 type Decoder struct { 21 23 dec *pktline.Decoder 22 24 maxData int

+2

network/protocol/sideband64k/encoder.go

reviewed

··· 10 10 // Encoder writes side-band-64k frames to a flush-capable output transport. 11 11 // 12 12 // It writes exactly one frame per method call and does not auto-chunk data. 13 13 + // 14 14 + // Labels: MT-Unsafe. 13 15 type Encoder struct { 14 16 enc *pktline.Encoder 15 17 maxData int

+4 -2

network/protocol/v0v1/server/receivepack/session.go

reviewed

··· 10 10 ) 11 11 12 12 // Session is one stateful server-side receive-pack protocol session. 13 13 + // 14 14 + // Labels: MT-Unsafe. 13 15 type Session struct { 14 16 base *common.Session 15 17 supported Capabilities ··· 171 173 // 172 174 // When side-band-64k was not negotiated, writes are discarded. 173 175 // 174 174 - // Labels: Life-Parent, Close-No. 176 176 + // Labels: Life-Parent. 175 177 func (session *Session) ProgressWriter() iowrap.WriteFlusher { 176 178 return session.base.ProgressWriter() 177 179 } ··· 185 187 // 186 188 // When side-band-64k was not negotiated, writes are discarded. 187 189 // 188 188 - // Labels: Life-Parent, Close-No. 190 190 + // Labels: Life-Parent. 189 191 func (session *Session) ErrorWriter() iowrap.WriteFlusher { 190 192 return session.base.ErrorWriter() 191 193 }

+5 -3

network/protocol/v0v1/server/session.go

reviewed

··· 18 18 } 19 19 20 20 // Session is one stateful server-side v0/v1 server protocol session. 21 21 + // 22 22 + // Labels: MT-Unsafe. 21 23 type Session struct { 22 24 dec *pktline.Decoder 23 25 enc *pktline.Encoder ··· 103 105 // 104 106 // When side-band-64k was not negotiated, writes are discarded. 105 107 // 106 106 - // Labels: Life-Parent, Close-No. 108 108 + // Labels: Life-Parent. 107 109 func (session *Session) ProgressWriter() iowrap.WriteFlusher { 108 110 if !session.useSideBand { 109 111 return iowrap.NopFlush(io.Discard) ··· 116 118 // 117 119 // When side-band-64k was not negotiated, writes are discarded. 118 120 // 119 119 - // Labels: Life-Parent, Close-No. 121 121 + // Labels: Life-Parent. 120 122 func (session *Session) ErrorWriter() iowrap.WriteFlusher { 121 123 if !session.useSideBand { 122 124 return iowrap.NopFlush(io.Discard) ··· 130 132 // When side-band-64k is enabled, writes are chunked into band-1 sideband 131 133 // frames. Otherwise writes are chunked into direct pkt-line data frames. 132 134 // 133 133 - // Labels: Life-Parent, Close-No. 135 135 + // Labels: Life-Parent. 134 136 func (session *Session) PrimaryDataWriter() iowrap.WriteFlusher { 135 137 if session.useSideBand { 136 138 return sideband64k.NewChunkWriter(session.sideband, sideband64k.BandData)