Merge pull request 'feat(docs): image resize handles and alignment (#118)' (#111) from feat/image-resize into main · scottlanoue.com/atmosphere-office@1f5ca31

+56

src/css/app.css

··· 3057 3057 margin-bottom: 0.25rem; 3058 3058 } 3059 3059 3060 + /* --- Resizable Images (#118) --- */ 3061 + .tiptap .resizable-image-wrapper { 3062 + margin: 0.75em 0; 3063 + line-height: 0; 3064 + } 3065 + 3066 + .tiptap .resizable-image-wrapper[data-align="left"] { 3067 + text-align: left; 3068 + } 3069 + 3070 + .tiptap .resizable-image-wrapper[data-align="center"] { 3071 + text-align: center; 3072 + } 3073 + 3074 + .tiptap .resizable-image-wrapper[data-align="right"] { 3075 + text-align: right; 3076 + } 3077 + 3078 + .tiptap .resizable-image-container { 3079 + display: inline-block; 3080 + position: relative; 3081 + line-height: 0; 3082 + } 3083 + 3084 + .tiptap .resizable-image-container img { 3085 + display: block; 3086 + max-width: 100%; 3087 + border-radius: var(--radius-sm, 4px); 3088 + } 3089 + 3090 + .tiptap .resizable-image-wrapper.selected .resizable-image-container { 3091 + outline: 2px solid var(--color-accent, #0563C1); 3092 + border-radius: var(--radius-sm, 4px); 3093 + } 3094 + 3095 + /* Resize handles — only visible when selected */ 3096 + .tiptap .resize-handle { 3097 + display: none; 3098 + position: absolute; 3099 + width: 10px; 3100 + height: 10px; 3101 + background: var(--color-accent, #0563C1); 3102 + border: 1px solid #fff; 3103 + border-radius: 2px; 3104 + z-index: 10; 3105 + } 3106 + 3107 + .tiptap .resizable-image-wrapper.selected .resize-handle { 3108 + display: block; 3109 + } 3110 + 3111 + .tiptap .resize-handle-nw { top: -5px; left: -5px; cursor: nw-resize; } 3112 + .tiptap .resize-handle-ne { top: -5px; right: -5px; cursor: ne-resize; } 3113 + .tiptap .resize-handle-sw { bottom: -5px; left: -5px; cursor: sw-resize; } 3114 + .tiptap .resize-handle-se { bottom: -5px; right: -5px; cursor: se-resize; } 3115 + 3060 3116 /* --- Print styles --- */ 3061 3117 @media print { 3062 3118 .app-topbar,

+238

src/docs/extensions/resizable-image.ts

··· 1 + /** 2 + * Resizable Image Extension (#118) 3 + * 4 + * Extends TipTap's Image node with: 5 + * - Width/height attributes that persist through HTML round-trip 6 + * - Drag-to-resize handles (corner + edge) 7 + * - Alignment options (left, center, right) 8 + * - Aspect ratio preservation during resize 9 + * 10 + * Uses a NodeView for the interactive resize UI. 11 + */ 12 + 13 + import { Node, mergeAttributes } from '@tiptap/core'; 14 + import type { Editor } from '@tiptap/core'; 15 + 16 + export interface ResizableImageOptions { 17 + HTMLAttributes: Record<string, string>; 18 + /** Minimum image width in px */ 19 + minWidth: number; 20 + /** Maximum image width in px */ 21 + maxWidth: number; 22 + } 23 + 24 + export type ImageAlignment = 'left' | 'center' | 'right'; 25 + 26 + declare module '@tiptap/core' { 27 + interface Commands<ReturnType> { 28 + resizableImage: { 29 + setImage: (options: { src: string; alt?: string; title?: string; width?: number; align?: ImageAlignment }) => ReturnType; 30 + setImageAlign: (align: ImageAlignment) => ReturnType; 31 + setImageWidth: (width: number) => ReturnType; 32 + }; 33 + } 34 + } 35 + 36 + export const ResizableImage = Node.create<ResizableImageOptions>({ 37 + name: 'image', 38 + 39 + group: 'block', 40 + atom: true, 41 + selectable: true, 42 + draggable: true, 43 + 44 + addOptions() { 45 + return { 46 + HTMLAttributes: {}, 47 + minWidth: 50, 48 + maxWidth: 1200, 49 + }; 50 + }, 51 + 52 + addAttributes() { 53 + return { 54 + src: { 55 + default: null, 56 + parseHTML: (el: HTMLElement) => el.getAttribute('src'), 57 + renderHTML: (attrs: Record<string, string | null>) => ({ src: attrs.src }), 58 + }, 59 + alt: { 60 + default: null, 61 + parseHTML: (el: HTMLElement) => el.getAttribute('alt'), 62 + renderHTML: (attrs: Record<string, string | null>) => ({ alt: attrs.alt }), 63 + }, 64 + title: { 65 + default: null, 66 + parseHTML: (el: HTMLElement) => el.getAttribute('title'), 67 + renderHTML: (attrs: Record<string, string | null>) => ({ title: attrs.title }), 68 + }, 69 + width: { 70 + default: null, 71 + parseHTML: (el: HTMLElement) => { 72 + const w = el.getAttribute('width') || el.style.width; 73 + return w ? parseInt(String(w), 10) || null : null; 74 + }, 75 + renderHTML: (attrs: Record<string, number | null>) => { 76 + if (!attrs.width) return {}; 77 + return { width: attrs.width, style: `width: ${attrs.width}px` }; 78 + }, 79 + }, 80 + align: { 81 + default: 'center', 82 + parseHTML: (el: HTMLElement) => el.getAttribute('data-align') || 'center', 83 + renderHTML: (attrs: Record<string, string | null>) => ({ 84 + 'data-align': attrs.align || 'center', 85 + }), 86 + }, 87 + }; 88 + }, 89 + 90 + parseHTML() { 91 + return [ 92 + { tag: 'img[src]' }, 93 + ]; 94 + }, 95 + 96 + renderHTML({ HTMLAttributes }) { 97 + return ['img', mergeAttributes(this.options.HTMLAttributes, HTMLAttributes)]; 98 + }, 99 + 100 + addCommands() { 101 + return { 102 + setImage: 103 + (options) => 104 + ({ commands }) => { 105 + return commands.insertContent({ 106 + type: this.name, 107 + attrs: options, 108 + }); 109 + }, 110 + setImageAlign: 111 + (align: ImageAlignment) => 112 + ({ tr, state }) => { 113 + const { selection } = state; 114 + const node = state.doc.nodeAt(selection.from); 115 + if (node?.type.name !== this.name) return false; 116 + tr.setNodeMarkup(selection.from, undefined, { ...node.attrs, align }); 117 + return true; 118 + }, 119 + setImageWidth: 120 + (width: number) => 121 + ({ tr, state }) => { 122 + const { selection } = state; 123 + const node = state.doc.nodeAt(selection.from); 124 + if (node?.type.name !== this.name) return false; 125 + const clamped = Math.max(this.options.minWidth, Math.min(this.options.maxWidth, width)); 126 + tr.setNodeMarkup(selection.from, undefined, { ...node.attrs, width: clamped }); 127 + return true; 128 + }, 129 + }; 130 + }, 131 + 132 + addNodeView() { 133 + return ({ node, editor, getPos }) => { 134 + const minWidth = this.options.minWidth; 135 + const maxWidth = this.options.maxWidth; 136 + 137 + // Wrapper div for alignment 138 + const wrapper = document.createElement('div'); 139 + wrapper.className = 'resizable-image-wrapper'; 140 + wrapper.setAttribute('data-align', node.attrs.align || 'center'); 141 + 142 + // Container for image + handles 143 + const container = document.createElement('div'); 144 + container.className = 'resizable-image-container'; 145 + container.style.display = 'inline-block'; 146 + container.style.position = 'relative'; 147 + 148 + // The image 149 + const img = document.createElement('img'); 150 + img.src = node.attrs.src || ''; 151 + if (node.attrs.alt) img.alt = node.attrs.alt; 152 + if (node.attrs.title) img.title = node.attrs.title; 153 + if (node.attrs.width) { 154 + img.style.width = `${node.attrs.width}px`; 155 + } 156 + img.style.display = 'block'; 157 + img.style.maxWidth = '100%'; 158 + 159 + container.appendChild(img); 160 + 161 + // Resize handles (four corners) 162 + const handles = ['nw', 'ne', 'sw', 'se'] as const; 163 + for (const pos of handles) { 164 + const handle = document.createElement('div'); 165 + handle.className = `resize-handle resize-handle-${pos}`; 166 + handle.contentEditable = 'false'; 167 + 168 + handle.addEventListener('mousedown', (e: MouseEvent) => { 169 + e.preventDefault(); 170 + e.stopPropagation(); 171 + 172 + const startX = e.clientX; 173 + const startWidth = img.offsetWidth; 174 + const isLeft = pos === 'nw' || pos === 'sw'; 175 + 176 + const onMouseMove = (moveEvent: MouseEvent) => { 177 + const dx = moveEvent.clientX - startX; 178 + const newWidth = isLeft 179 + ? Math.max(minWidth, Math.min(maxWidth, startWidth - dx)) 180 + : Math.max(minWidth, Math.min(maxWidth, startWidth + dx)); 181 + img.style.width = `${newWidth}px`; 182 + }; 183 + 184 + const onMouseUp = () => { 185 + document.removeEventListener('mousemove', onMouseMove); 186 + document.removeEventListener('mouseup', onMouseUp); 187 + 188 + // Commit width to ProseMirror state 189 + const pos = getPos(); 190 + if (typeof pos === 'number') { 191 + const newWidth = img.offsetWidth; 192 + editor.chain().focus().command(({ tr }) => { 193 + const currentNode = tr.doc.nodeAt(pos); 194 + if (currentNode) { 195 + tr.setNodeMarkup(pos, undefined, { ...currentNode.attrs, width: newWidth }); 196 + } 197 + return true; 198 + }).run(); 199 + } 200 + }; 201 + 202 + document.addEventListener('mousemove', onMouseMove); 203 + document.addEventListener('mouseup', onMouseUp); 204 + }); 205 + 206 + container.appendChild(handle); 207 + } 208 + 209 + wrapper.appendChild(container); 210 + 211 + return { 212 + dom: wrapper, 213 + 214 + update(updatedNode) { 215 + if (updatedNode.type.name !== 'image') return false; 216 + img.src = updatedNode.attrs.src || ''; 217 + if (updatedNode.attrs.alt) img.alt = updatedNode.attrs.alt; 218 + if (updatedNode.attrs.title) img.title = updatedNode.attrs.title; 219 + if (updatedNode.attrs.width) { 220 + img.style.width = `${updatedNode.attrs.width}px`; 221 + } else { 222 + img.style.width = ''; 223 + } 224 + wrapper.setAttribute('data-align', updatedNode.attrs.align || 'center'); 225 + return true; 226 + }, 227 + 228 + selectNode() { 229 + wrapper.classList.add('selected'); 230 + }, 231 + 232 + deselectNode() { 233 + wrapper.classList.remove('selected'); 234 + }, 235 + }; 236 + }; 237 + }, 238 + });

+2 -2

src/docs/main.ts

··· 10 10 import StarterKit from '@tiptap/starter-kit'; 11 11 import Underline from '@tiptap/extension-underline'; 12 12 import Link from '@tiptap/extension-link'; 13 - import Image from '@tiptap/extension-image'; 13 + import { ResizableImage } from './extensions/resizable-image.js'; 14 14 import Table from '@tiptap/extension-table'; 15 15 import TableRow from '@tiptap/extension-table-row'; 16 16 import TableCell from '@tiptap/extension-table-cell'; ··· 114 114 StarterKit.configure({ history: false }), 115 115 Underline, 116 116 Link.configure({ openOnClick: false }), 117 - Image, 117 + ResizableImage, 118 118 Table.configure({ resizable: true }), 119 119 TableRow, 120 120 TableCell,

+100

tests/resizable-image.test.ts

··· 1 + import { describe, it, expect } from 'vitest'; 2 + 3 + /** 4 + * Tests for the resizable image extension logic. 5 + * 6 + * Since the NodeView requires a real DOM/editor, we test the attribute 7 + * parsing/rendering logic and width clamping independently. 8 + */ 9 + 10 + describe('image width clamping', () => { 11 + const minWidth = 50; 12 + const maxWidth = 1200; 13 + 14 + function clampWidth(width: number): number { 15 + return Math.max(minWidth, Math.min(maxWidth, width)); 16 + } 17 + 18 + it('clamps width below minimum', () => { 19 + expect(clampWidth(10)).toBe(50); 20 + }); 21 + 22 + it('clamps width above maximum', () => { 23 + expect(clampWidth(2000)).toBe(1200); 24 + }); 25 + 26 + it('passes through valid width', () => { 27 + expect(clampWidth(400)).toBe(400); 28 + }); 29 + 30 + it('handles exact minimum', () => { 31 + expect(clampWidth(50)).toBe(50); 32 + }); 33 + 34 + it('handles exact maximum', () => { 35 + expect(clampWidth(1200)).toBe(1200); 36 + }); 37 + }); 38 + 39 + describe('image alignment', () => { 40 + const validAlignments = ['left', 'center', 'right']; 41 + 42 + it('accepts valid alignment values', () => { 43 + for (const align of validAlignments) { 44 + expect(validAlignments).toContain(align); 45 + } 46 + }); 47 + 48 + it('defaults to center when not specified', () => { 49 + const defaultAlign = null || 'center'; 50 + expect(defaultAlign).toBe('center'); 51 + }); 52 + }); 53 + 54 + describe('width attribute parsing', () => { 55 + function parseWidth(value: string | null): number | null { 56 + if (!value) return null; 57 + const parsed = parseInt(value, 10); 58 + return isNaN(parsed) ? null : parsed; 59 + } 60 + 61 + it('parses numeric string', () => { 62 + expect(parseWidth('400')).toBe(400); 63 + }); 64 + 65 + it('parses pixel value string', () => { 66 + expect(parseWidth('400px')).toBe(400); 67 + }); 68 + 69 + it('returns null for empty string', () => { 70 + expect(parseWidth('')).toBe(null); 71 + }); 72 + 73 + it('returns null for null', () => { 74 + expect(parseWidth(null)).toBe(null); 75 + }); 76 + 77 + it('returns null for non-numeric string', () => { 78 + expect(parseWidth('auto')).toBe(null); 79 + }); 80 + }); 81 + 82 + describe('resize delta calculation', () => { 83 + it('computes new width for right-side drag', () => { 84 + const startWidth = 300; 85 + const dx = 50; // dragged right 86 + expect(startWidth + dx).toBe(350); 87 + }); 88 + 89 + it('computes new width for left-side drag', () => { 90 + const startWidth = 300; 91 + const dx = 50; // dragged right = shrink for left handle 92 + expect(startWidth - dx).toBe(250); 93 + }); 94 + 95 + it('negative delta shrinks right-side drag', () => { 96 + const startWidth = 300; 97 + const dx = -100; 98 + expect(startWidth + dx).toBe(200); 99 + }); 100 + });

Configure Feed

Configure Feed