refactor(agents): remove dead code and fix duplicate ID bug

+31 -61

2 changed files

expand all

dream

templates

agents.html

views

agents.py

+31 -52

dream/templates/agents.html

··· 279 279 display: block; 280 280 } 281 281 282 - .selection-status { 283 - font-size: 0.9rem; 284 - color: #666; 285 - margin-bottom: 1rem; 286 - } 287 - 288 - .selection-status.required { 289 - color: #dc3545; 290 - font-weight: 500; 291 - } 292 - 293 282 /* Session History Table */ 294 283 table { 295 284 border-collapse: collapse; ··· 658 647 margin-bottom: 1rem; 659 648 } 660 649 661 - .prompt-content { 650 + /* Prompt content display box for create modals */ 651 + .prompt-result-box { 662 652 background: #f8f9fa; 663 653 border: 1px solid #dee2e6; 664 654 border-radius: 4px; ··· 843 833 background: #545b62; 844 834 } 845 835 836 + /* Prompt section container in item modal */ 846 837 .prompt-content { 847 838 padding: 1rem; 848 839 max-height: 500px; ··· 888 879 20% { opacity: 1; } 889 880 80% { opacity: 1; } 890 881 100% { opacity: 0; } 891 - } 892 - 893 - /* Remove old toggle button styles */ 894 - .toggle-btn { 895 - display: none !important; 896 882 } 897 883 898 884 /* Tools Tab Styles */ ··· 1258 1244  1259 1245 <div id="topicResult" style="display: none;"> 1260 1246 <h3>Topic Content</h3> 1261 - <div id="topicResultContent" class="prompt-content"></div> 1247 + <div id="topicResultContent" class="prompt-result-box"></div> 1262 1248 <div class="modal-actions"> 1263 1249 <button onclick="saveNewTopic()">Save Topic</button> 1264 1250 <button onclick="editTopicContent()">Edit Content</button> ··· 1350 1336 </div> 1351 1337 <div class="prompt-content"> 1352 1338 <div id="promptDisplay" class="prompt-display"></div> 1353 - <textarea id="promptEditor" class="prompt-editor" style="display: none;"></textarea> 1339 + <textarea id="itemContentEditor" class="prompt-editor" style="display: none;"></textarea> 1354 1340 </div> 1355 1341 </div> 1356 1342 ··· 1446 1432 let currentEditingType = null; // 'agent' or 'topic' 1447 1433 let isEditMode = false; 1448 1434 let activePackFilter = 'all'; 1435 + let originalPromptContent = ''; // Store original content for cancel 1436 + let currentTopicContent = ''; 1437 + let currentTopicTitle = ''; 1449 1438 1450 1439 // Switch between main tabs 1451 1440 function switchMainTab(tabName) { ··· 1668 1657 1669 1658 currentEditingItem = itemId; 1670 1659 currentEditingType = itemType; 1671 - window.originalPromptContent = ''; // Store original content for cancel 1660 + originalPromptContent = ''; // Store original content for cancel 1672 1661 1673 1662 // Set title 1674 1663 const modalTitle = document.getElementById('modalTitle'); ··· 1756 1745 .then(data => { 1757 1746 if (data.error) { 1758 1747 document.getElementById('promptDisplay').innerHTML = `<p>Error: ${data.error}</p>`; 1759 - window.originalPromptContent = ''; 1748 + originalPromptContent = ''; 1760 1749 } else { 1761 1750 // Store raw content for editing 1762 1751 const rawContent = data.content; 1763 - window.originalPromptContent = rawContent; 1764 - document.getElementById('promptEditor').value = rawContent; 1752 + originalPromptContent = rawContent; 1753 + document.getElementById('itemContentEditor').value = rawContent; 1765 1754 1766 1755 // Display content 1767 1756 document.getElementById('promptDisplay').textContent = rawContent; ··· 1814 1803 // Prompt editing functions 1815 1804 function startPromptEdit() { 1816 1805 const promptDisplay = document.getElementById('promptDisplay'); 1817 - const promptEditor = document.getElementById('promptEditor'); 1806 + const promptEditor = document.getElementById('itemContentEditor'); 1818 1807 const editBtn = document.getElementById('editPromptBtn'); 1819 1808 const saveBtn = document.getElementById('savePromptBtn'); 1820 1809 const cancelBtn = document.getElementById('cancelPromptBtn'); ··· 1829 1818 1830 1819 function savePromptEdit() { 1831 1820 const promptDisplay = document.getElementById('promptDisplay'); 1832 - const promptEditor = document.getElementById('promptEditor'); 1821 + const promptEditor = document.getElementById('itemContentEditor'); 1833 1822 const newContent = promptEditor.value.trim(); 1834 1823 1835 1824 if (!newContent) { ··· 1841 1830 saveMetadata({ content: newContent }); 1842 1831 1843 1832 promptDisplay.textContent = newContent; 1844 - window.originalPromptContent = newContent; 1833 + originalPromptContent = newContent; 1845 1834 1846 1835 // Reset UI 1847 1836 promptDisplay.style.display = 'block'; ··· 1853 1842 1854 1843 function cancelPromptEdit() { 1855 1844 const promptDisplay = document.getElementById('promptDisplay'); 1856 - const promptEditor = document.getElementById('promptEditor'); 1845 + const promptEditor = document.getElementById('itemContentEditor'); 1857 1846 1858 1847 // Restore original content 1859 - promptEditor.value = window.originalPromptContent; 1848 + promptEditor.value = originalPromptContent; 1860 1849 1861 1850 // Reset UI 1862 1851 promptDisplay.style.display = 'block'; ··· 1873 1862 if (currentEditingType === 'agent') { 1874 1863 // Gather all current metadata values 1875 1864 const currentTitle = document.getElementById('modalTitle').textContent; 1876 - const currentContent = document.getElementById('promptEditor').value.trim(); 1865 + const currentContent = document.getElementById('itemContentEditor').value.trim(); 1877 1866 1878 1867 requestBody.title = updates.title || currentTitle; 1879 1868 requestBody.content = updates.content || currentContent; ··· 1947 1936 async function saveTopicMetadata() { 1948 1937 const requestBody = { 1949 1938 title: document.getElementById('modalTitle').textContent, 1950 - content: document.getElementById('promptEditor').value.trim(), 1939 + content: document.getElementById('itemContentEditor').value.trim(), 1951 1940 disabled: !document.getElementById('modalTopicEnabled').checked, 1952 1941 color: document.getElementById('modalTopicColor').value 1953 1942 }; ··· 2000 1989 indicator.style.display = 'none'; 2001 1990 }, 2000); 2002 1991 } 2003 - 2004 - // Form submission - removed as agentForm doesn't exist in this template 2005 - // The create agent functionality is handled by createPersonaForm instead 2006 1992 2007 1993 // Show prompt modal with prompt text 2008 1994 function showPromptModal(promptText) { ··· 2124 2110 // Success - close modal and reload agents 2125 2111 closePromptModal(); 2126 2112 loadAgentSessions(); 2127 - 2128 - // Clear the input form 2129 - document.getElementById('agentInput').value = ''; 2130 - 2113 + 2131 2114 } catch (error) { 2132 2115 showError('Error starting agent: ' + error.message); 2133 2116 } finally { ··· 2140 2123 function closeItemModal() { 2141 2124 // Cancel any ongoing prompt edits if elements exist 2142 2125 const promptDisplay = document.getElementById('promptDisplay'); 2143 - const promptEditor = document.getElementById('promptEditor'); 2126 + const promptEditor = document.getElementById('itemContentEditor'); 2144 2127 2145 2128 if (promptDisplay && promptEditor) { 2146 2129 // Reset prompt editor if it was being edited 2147 2130 if (promptEditor.style.display === 'block') { 2148 - promptEditor.value = window.originalPromptContent || ''; 2131 + promptEditor.value = originalPromptContent || ''; 2149 2132 promptDisplay.style.display = 'block'; 2150 2133 promptEditor.style.display = 'none'; 2151 2134 ··· 2546 2529 } 2547 2530 } 2548 2531 2549 - // Removed editPersonaPrompt - now using standard edit modal 2550 - 2551 - // Removed saveNewPersona - now handled in showPersonaPromptResult 2552 - 2553 2532 // Handle create topic form submission 2554 2533 document.getElementById('createTopicForm').addEventListener('submit', async (e) => { 2555 2534 e.preventDefault(); ··· 2571 2550 function showTopicResult(content, title) { 2572 2551 const resultDiv = document.getElementById('topicResult'); 2573 2552 const resultContent = document.getElementById('topicResultContent'); 2574 - 2553 + 2575 2554 // Store content and title for saving 2576 - window.currentTopicContent = content; 2577 - window.currentTopicTitle = title; 2578 - 2555 + currentTopicContent = content; 2556 + currentTopicTitle = title; 2557 + 2579 2558 // Display the content 2580 2559 resultContent.textContent = content; 2581 2560 resultDiv.style.display = 'block'; ··· 2595 2574 2596 2575 resultContent.innerHTML = ''; 2597 2576 resultContent.appendChild(textarea); 2598 - 2577 + 2599 2578 // Update the content when editing 2600 2579 textarea.addEventListener('input', () => { 2601 - window.currentTopicContent = textarea.value; 2580 + currentTopicContent = textarea.value; 2602 2581 }); 2603 2582 } 2604 2583 2605 2584 async function saveNewTopic() { 2606 - const title = window.currentTopicTitle; 2607 - const content = window.currentTopicContent; 2608 - 2585 + const title = currentTopicTitle; 2586 + const content = currentTopicContent; 2587 + 2609 2588 if (!title || !content) { 2610 2589 showError('Missing title or content'); 2611 2590 return;

-9

dream/views/agents.py

··· 1 1 from __future__ import annotations 2 2 3 - # Removed asyncio - no longer needed 4 3 import asyncio 5 4 import json 6 5 import os ··· 16 15 def agents_page() -> str: 17 16 """Render the Agents view.""" 18 17 return render_template("agents.html", active="agents") 19 - 20 - 21 - def _agents_dir() -> str: 22 - if not state.journal_root: 23 - return "" 24 - path = os.path.join(state.journal_root, "agents") 25 - os.makedirs(path, exist_ok=True) 26 - return path 27 18 28 19 29 20 def _list_items(item_type: str) -> list[dict[str, object]]:

Configure Feed

Configure Feed