personal memory agent
refactor: change observe-reduce to use semantic --day/--period args
Replace explicit file path argument with semantic day and period arguments,
allowing reduce to construct the path internally. This fixes path construction
bugs and improves separation of concerns.
**API Change:**
- Old: `observe-reduce /path/to/20251109/222502_303/screen.jsonl`
- New: `observe-reduce --day 20251109 --period 222502_303`
**Benefits:**
- Fixes "JSONL file not found" errors in sense.py after describe moves files
- Path construction logic centralized in reduce.py (single source of truth)
- Callers (sense.py) don't need to understand journal directory structure
- Clearer semantics: "reduce this period" vs "reduce this file"
**Changes:**
- observe/reduce.py: Updated CLI to accept --day and --period, construct path
- observe/sense.py: Updated _run_reduce() and process_day() to use new args
- tests/test_reduce.py: Added test for semantic path construction
- tests/test_sense.py: Fixed pre-existing HandlerProcess test (missing arg)
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
+175
-30
+27
-4
observe/reduce.py
+27
-4
observe/reduce.py
···
303
303
description="Reduce screencast analysis to markdown summary"
304
304
)
305
305
parser.add_argument(
306
-
"jsonl_path",
306
+
"--day",
307
307
type=str,
308
-
help="Path to analysis JSONL file",
308
+
required=True,
309
+
help="Day in YYYYMMDD format",
310
+
)
311
+
parser.add_argument(
312
+
"--period",
313
+
type=str,
314
+
required=True,
315
+
help="Period key (HHMMSS or HHMMSS_LEN)",
309
316
)
310
317
args = setup_cli(parser)
311
318
312
-
jsonl_path = Path(args.jsonl_path)
319
+
# Construct path from semantic arguments
320
+
journal_path = Path(os.getenv("JOURNAL_PATH", ""))
321
+
if not journal_path.is_dir():
322
+
logger.error("JOURNAL_PATH not set or invalid")
323
+
sys.exit(1)
324
+
325
+
day_dir = journal_path / args.day
326
+
if not day_dir.exists():
327
+
logger.error(f"Day directory not found: {day_dir}")
328
+
sys.exit(1)
329
+
330
+
period_dir = day_dir / args.period
331
+
if not period_dir.exists():
332
+
logger.error(f"Period directory not found: {period_dir}")
333
+
sys.exit(1)
334
+
335
+
jsonl_path = period_dir / "screen.jsonl"
313
336
if not jsonl_path.exists():
314
-
logger.error(f"JSONL file not found: {jsonl_path}")
337
+
logger.error(f"Analysis file not found: {jsonl_path}")
315
338
sys.exit(1)
316
339
317
340
exit_code = reduce_analysis(jsonl_path)
+21
-9
observe/sense.py
+21
-9
observe/sense.py
···
286
286
287
287
def _run_reduce(self, video_path: Path):
288
288
"""Run reduce on the video file after describe completes."""
289
-
jsonl_path = video_path.parent / f"{video_path.stem}.jsonl"
290
-
cmd = ["observe-reduce", str(jsonl_path)]
289
+
from think.utils import period_key
290
+
291
+
# Extract day and period from video path
292
+
# Expected structure: journal_dir/YYYYMMDD/HHMMSS_LEN_suffix.webm
293
+
day = video_path.parent.name # YYYYMMDD
294
+
period = period_key(video_path.stem) # HHMMSS or HHMMSS_LEN
295
+
296
+
if not period:
297
+
logger.error(f"Cannot extract period from {video_path.stem}")
298
+
return
299
+
300
+
cmd = ["observe-reduce", "--day", day, "--period", period]
291
301
292
302
# Add verbose/debug flags if set
293
303
if self.debug:
···
295
305
elif self.verbose:
296
306
cmd.append("-v")
297
307
298
-
logger.info(f"Running reduce for {video_path.name}")
308
+
logger.info(f"Running reduce for {day}/{period}")
299
309
300
310
# Use unified runner with automatic logging and timeout
301
311
success, exit_code = run_task(cmd, timeout=300) # 5 minute timeout
302
312
303
313
if success:
304
-
logger.info(f"Reduce completed successfully for {video_path.name}")
314
+
logger.info(f"Reduce completed successfully for {day}/{period}")
305
315
else:
306
-
logger.warning(
307
-
f"Reduce failed for {video_path.name} (exit code {exit_code})"
308
-
)
316
+
logger.warning(f"Reduce failed for {day}/{period} (exit code {exit_code})")
309
317
310
318
def _handle_file(self, file_path: Path):
311
319
"""Route file to appropriate handler."""
···
544
552
screen_jsonl = period / "screen.jsonl"
545
553
screen_md = period / "screen.md"
546
554
if screen_jsonl.exists() and not screen_md.exists():
547
-
# Register reduce as a handler task
555
+
# Register reduce as a handler task with semantic args
548
556
to_process.append(
549
-
(screen_jsonl, "reduce", ["observe-reduce", "{file}"])
557
+
(
558
+
screen_jsonl,
559
+
"reduce",
560
+
["observe-reduce", "--day", day, "--period", period.name],
561
+
)
550
562
)
551
563
552
564
if not to_process:
+126
-16
tests/test_reduce.py
+126
-16
tests/test_reduce.py
···
1
1
"""Tests for observe.reduce module."""
2
2
3
+
import json
4
+
import sys
3
5
from pathlib import Path
6
+
from unittest.mock import MagicMock, patch
7
+
8
+
import pytest
4
9
5
-
from observe.reduce import assemble_markdown
10
+
from observe.reduce import assemble_markdown, reduce_analysis
6
11
7
12
8
13
def test_assemble_markdown_extracts_period_from_directory():
9
14
"""Test that assemble_markdown correctly extracts base time from period directory."""
10
15
# Mock frames with relative timestamps (seconds from period start)
11
16
frames = [
12
-
{"timestamp": 0, "monitor": "0", "analysis": {"visible": "code", "visual_description": "Editing Python"}},
13
-
{"timestamp": 30, "monitor": "0", "analysis": {"visible": "terminal", "visual_description": "Running tests"}},
14
-
{"timestamp": 120, "monitor": "0", "analysis": {"visible": "browser", "visual_description": "Reading docs"}},
17
+
{
18
+
"timestamp": 0,
19
+
"monitor": "0",
20
+
"analysis": {"visible": "code", "visual_description": "Editing Python"},
21
+
},
22
+
{
23
+
"timestamp": 30,
24
+
"monitor": "0",
25
+
"analysis": {"visible": "terminal", "visual_description": "Running tests"},
26
+
},
27
+
{
28
+
"timestamp": 120,
29
+
"monitor": "0",
30
+
"analysis": {"visible": "browser", "visual_description": "Reading docs"},
31
+
},
15
32
]
16
33
17
34
# Simulate path structure: YYYYMMDD/HHMMSS/screen.jsonl
18
35
jsonl_path = Path("20240101/143022/screen.jsonl")
19
36
20
-
markdown = assemble_markdown(frames, entity_names="", video_path=jsonl_path, include_entity_context=False)
37
+
markdown = assemble_markdown(
38
+
frames, entity_names="", video_path=jsonl_path, include_entity_context=False
39
+
)
21
40
22
41
# Verify absolute times are calculated correctly from period (14:30:22)
23
42
assert "14:30:22" in markdown # Base time from period
···
33
52
def test_assemble_markdown_handles_period_with_duration_suffix():
34
53
"""Test that assemble_markdown handles HHMMSS_LEN period format."""
35
54
frames = [
36
-
{"timestamp": 0, "monitor": "0", "analysis": {"visible": "code", "visual_description": "Code"}},
37
-
{"timestamp": 60, "monitor": "0", "analysis": {"visible": "terminal", "visual_description": "Terminal"}},
55
+
{
56
+
"timestamp": 0,
57
+
"monitor": "0",
58
+
"analysis": {"visible": "code", "visual_description": "Code"},
59
+
},
60
+
{
61
+
"timestamp": 60,
62
+
"monitor": "0",
63
+
"analysis": {"visible": "terminal", "visual_description": "Terminal"},
64
+
},
38
65
]
39
66
40
67
# Period with duration suffix: 143022_300 (5 minutes)
41
68
jsonl_path = Path("20240101/143022_300/screen.jsonl")
42
69
43
-
markdown = assemble_markdown(frames, entity_names="", video_path=jsonl_path, include_entity_context=False)
70
+
markdown = assemble_markdown(
71
+
frames, entity_names="", video_path=jsonl_path, include_entity_context=False
72
+
)
44
73
45
74
# Should still extract base time correctly
46
75
assert "14:30:22" in markdown # Base time
···
52
81
def test_assemble_markdown_handles_no_video_path():
53
82
"""Test that assemble_markdown works when video_path is None (defaults to midnight)."""
54
83
frames = [
55
-
{"timestamp": 0, "monitor": "0", "analysis": {"visible": "code", "visual_description": "Code"}},
56
-
{"timestamp": 3600, "monitor": "0", "analysis": {"visible": "browser", "visual_description": "Browser"}},
84
+
{
85
+
"timestamp": 0,
86
+
"monitor": "0",
87
+
"analysis": {"visible": "code", "visual_description": "Code"},
88
+
},
89
+
{
90
+
"timestamp": 3600,
91
+
"monitor": "0",
92
+
"analysis": {"visible": "browser", "visual_description": "Browser"},
93
+
},
57
94
]
58
95
59
-
markdown = assemble_markdown(frames, entity_names="", video_path=None, include_entity_context=False)
96
+
markdown = assemble_markdown(
97
+
frames, entity_names="", video_path=None, include_entity_context=False
98
+
)
60
99
61
100
# Should default to 00:00:00 base time
62
101
assert "00:00:00" in markdown
···
84
123
85
124
jsonl_path = Path("20240101/120000/screen.jsonl")
86
125
87
-
markdown = assemble_markdown(frames, entity_names="", video_path=jsonl_path, include_entity_context=False)
126
+
markdown = assemble_markdown(
127
+
frames, entity_names="", video_path=jsonl_path, include_entity_context=False
128
+
)
88
129
89
130
# Should include monitor info when multiple monitors present
90
131
assert "Monitor 0 - left" in markdown
···
96
137
def test_assemble_markdown_includes_entity_context():
97
138
"""Test that entity context is included when requested."""
98
139
frames = [
99
-
{"timestamp": 0, "monitor": "0", "analysis": {"visible": "code", "visual_description": "Code"}},
140
+
{
141
+
"timestamp": 0,
142
+
"monitor": "0",
143
+
"analysis": {"visible": "code", "visual_description": "Code"},
144
+
},
100
145
]
101
146
102
147
jsonl_path = Path("20240101/120000/screen.jsonl")
103
148
entity_names = "Alice, Bob, ProjectX"
104
149
105
150
markdown = assemble_markdown(
106
-
frames, entity_names=entity_names, video_path=jsonl_path, include_entity_context=True
151
+
frames,
152
+
entity_names=entity_names,
153
+
video_path=jsonl_path,
154
+
include_entity_context=True,
107
155
)
108
156
109
157
# Should include entity context header
···
117
165
{
118
166
"timestamp": 0,
119
167
"monitor": "0",
120
-
"analysis": {"visible": "terminal", "visual_description": "Terminal window"},
168
+
"analysis": {
169
+
"visible": "terminal",
170
+
"visual_description": "Terminal window",
171
+
},
121
172
"extracted_text": "$ python test.py\nAll tests passed",
122
173
},
123
174
]
124
175
125
176
jsonl_path = Path("20240101/120000/screen.jsonl")
126
177
127
-
markdown = assemble_markdown(frames, entity_names="", video_path=jsonl_path, include_entity_context=False)
178
+
markdown = assemble_markdown(
179
+
frames, entity_names="", video_path=jsonl_path, include_entity_context=False
180
+
)
128
181
129
182
# Should include extracted text in code block
130
183
assert "**Extracted Text:**" in markdown
131
184
assert "$ python test.py" in markdown
132
185
assert "All tests passed" in markdown
186
+
187
+
188
+
def test_main_constructs_path_from_day_and_period(tmp_path, monkeypatch):
189
+
"""Test that main() constructs correct JSONL path from --day and --period args."""
190
+
# Create mock journal structure
191
+
journal_path = tmp_path / "journal"
192
+
day_dir = journal_path / "20251109"
193
+
period_dir = day_dir / "222502_303"
194
+
period_dir.mkdir(parents=True)
195
+
196
+
# Create mock screen.jsonl with minimal valid data
197
+
screen_jsonl = period_dir / "screen.jsonl"
198
+
frames = [
199
+
{
200
+
"timestamp": 0,
201
+
"monitor": "0",
202
+
"analysis": {"visible": "code", "visual_description": "Test frame"},
203
+
}
204
+
]
205
+
with open(screen_jsonl, "w") as f:
206
+
for frame in frames:
207
+
f.write(json.dumps(frame) + "\n")
208
+
209
+
# Create mock reduce.txt prompt
210
+
reduce_prompt = tmp_path / "reduce.txt"
211
+
reduce_prompt.write_text("Test prompt")
212
+
213
+
# Set JOURNAL_PATH env var
214
+
monkeypatch.setenv("JOURNAL_PATH", str(journal_path))
215
+
216
+
# Mock the prompt file location
217
+
with patch("observe.reduce.Path") as mock_path_class:
218
+
# Make Path() work normally for most calls
219
+
mock_path_class.side_effect = lambda *args: Path(*args)
220
+
# But intercept the prompt path lookup
221
+
mock_reduce_file = MagicMock()
222
+
mock_reduce_file.parent = reduce_prompt.parent
223
+
mock_path_class.__file__ = str(mock_reduce_file)
224
+
225
+
# Mock gemini_generate to avoid actual API call
226
+
with patch("observe.reduce.gemini_generate") as mock_gemini:
227
+
mock_gemini.return_value = "# Test Summary\n\nGenerated markdown"
228
+
229
+
# Mock prompt file reading
230
+
with patch("observe.reduce.Path.read_text") as mock_read:
231
+
mock_read.return_value = "Test prompt"
232
+
233
+
# Call reduce_analysis with the constructed path
234
+
exit_code = reduce_analysis(screen_jsonl)
235
+
236
+
# Should succeed
237
+
assert exit_code == 0
238
+
239
+
# Verify markdown was written
240
+
output_md = period_dir / "screen.md"
241
+
assert output_md.exists()
242
+
assert "Test Summary" in output_md.read_text()
+1
-1
tests/test_sense.py
+1
-1
tests/test_sense.py