+17

apps/todos/call.py

reviewed

··· 115 115 "-n", 116 116 help="Nudge time: HH:MM, now, tomorrow HH:MM, or YYYYMMDDTHH:MM.", 117 117 ), 118 118 + force: bool = typer.Option( 119 119 + False, "--force", help="Skip duplicate check and add anyway." 120 120 + ), 118 121 ) -> None: 119 122 """Add a new todo item.""" 120 123 from datetime import datetime ··· 139 142 except ValueError as exc: 140 143 typer.echo(f"Error: {exc}", err=True) 141 144 raise typer.Exit(1) from None 145 145 + 146 146 + # Cross-facet duplicate check 147 147 + if not force: 148 148 + matches = todo.find_cross_facet_matches(text, day, exclude_facet=facet) 149 149 + if matches: 150 150 + typer.echo(f"Duplicate detected for: {text}", err=True) 151 151 + for match in matches: 152 152 + typer.echo( 153 153 + f" [{match['score']:.0f}%] {match['facet']}/{match['day']} " 154 154 + f"line {match['line']}: {match['text']}", 155 155 + err=True, 156 156 + ) 157 157 + typer.echo("Use --force to add anyway.", err=True) 158 158 + raise typer.Exit(1) 142 159 143 160 try: 144 161

+3 -1

apps/todos/muse/daily.md

reviewed

··· 29 29 SOL_DAY and SOL_FACET are set in your environment. Commands default to the current day and facet — only pass explicit values to override (e.g., checking yesterday's list). 30 30 31 31 - `sol call todos list` – inspect the current numbered checklist 32 32 - - `sol call todos add TEXT` – append a new unchecked line (line number is auto-calculated) 32 32 + - `sol call todos add TEXT [--force]` – append a new unchecked line (line number is auto-calculated; --force skips cross-facet duplicate check) 33 33 - `sol call todos cancel LINE_NUMBER` – cancel a todo (soft delete); the entry remains but is hidden from view 34 34 - `sol call todos done LINE_NUMBER` – mark an entry complete 35 35 - `sol call todos upcoming -l LIMIT` – view upcoming todos ··· 56 56 4. Check facet news for announced commitments: `sol call journal search "" -a news -d $day_YYYYMMDD -f FACET -n 5` 57 57 5. Cancel duplicates or stale items via `sol call todos cancel` 58 58 6. Add any high-value items missed by activity detection (e.g., cross-activity themes, carried commitments from follow-ups) 59 59 + 7. If `sol call todos add` rejects an item as a cross-facet duplicate, review the match — skip if it's genuine, retry with `--force` only if the items are truly distinct 59 60 60 61 Each candidate must be: 61 62 - **Actionable** – specific action with a clear outcome ··· 94 95 - Exceed 10 active items without explicit justification 95 96 - Invent work without journal evidence or historical context 96 97 - Re-add items that activity agents already captured 98 98 + - Use `--force` to bypass duplicate detection without verifying the match is a false positive 97 99 98 100 ## Interaction Protocol 99 101

+9 -1

apps/todos/muse/todo.md

reviewed

··· 33 33 34 34 ### Todo Commands (SOL_DAY and SOL_FACET are set in your environment) 35 35 - `sol call todos list` – inspect the current numbered checklist 36 36 - - `sol call todos add TEXT` – append a new unchecked line 36 36 + - `sol call todos add TEXT [--force]` – append a new unchecked line (--force skips cross-facet duplicate check) 37 37 - `sol call todos done LINE_NUMBER` – mark an entry complete 38 38 - `sol call todos upcoming` – view upcoming todos to avoid duplicates 39 39 ··· 89 89 - Pure speculation or hypothetical scenarios without concrete commitment 90 90 - Items that were both raised and resolved within this activity 91 91 - Duplicates of items already on the checklist or in upcoming todos 92 92 + 93 93 + ### Cross-Facet Dedup 94 94 + 95 95 + The `sol call todos add` command automatically rejects items that fuzzy-match (≥70% similarity) an open todo in another facet within a ±1 day window. If the CLI rejects an add: 96 96 + 97 97 + 1. Check the reported match — if the existing item covers the same work, skip the add entirely 98 98 + 2. If the new item is genuinely different despite the similarity, retry with `--force` 99 99 + 3. Never use `--force` to create true duplicates across facets — one task, one facet 92 100 93 101 ## Quality Guidelines 94 102

+2 -1

apps/todos/muse/todos/SKILL.md

reviewed

··· 48 48 ## add 49 49 50 50 ```bash 51 51 - sol call todos add TEXT [-d DAY] [-f FACET] 51 51 + sol call todos add TEXT [-d DAY] [-f FACET] [--force] 52 52 ``` 53 53 54 54 Add a new todo item. ··· 62 62 - Line number is auto-calculated by the CLI; do not provide one. 63 63 - You can include time in the text as `(HH:MM)` suffix. 64 64 - Before adding a future todo, check `upcoming` first to avoid duplicates already scheduled on other days. 65 65 + - The command checks for fuzzy duplicates (≥70% similarity) across other facets within ±1 day. If a match is found, the add is rejected with a match report. Use `--force` to override. 65 66 66 67 Examples: 67 68

+57

apps/todos/tests/test_call.py

reviewed

··· 385 385 result = runner.invoke(call_app, ["todos", "done", "1"]) 386 386 assert result.exit_code == 0 387 387 assert "[x]" in result.output 388 388 + 389 389 + 390 390 + class TestTodosAddDedup: 391 391 + """Tests for cross-facet duplicate detection in 'sol call todos add'.""" 392 392 + 393 393 + def test_add_rejects_duplicate_in_other_facet(self, move_env): 394 394 + """Adding a duplicate todo in another facet is rejected with exit code 1.""" 395 395 + _, src_facet, dst_facet = move_env([{"text": "Draft Q1 plan"}], day="20240102") 396 396 + result = runner.invoke( 397 397 + call_app, 398 398 + ["todos", "add", "Draft Q1 plan", "--day", "20240102", "--facet", dst_facet], 399 399 + ) 400 400 + assert result.exit_code == 1 401 401 + assert "Duplicate detected" in result.output 402 402 + 403 403 + def test_add_force_bypasses_dedup(self, move_env): 404 404 + """--force flag allows adding despite duplicate detection.""" 405 405 + _, src_facet, dst_facet = move_env([{"text": "Draft Q1 plan"}], day="20240102") 406 406 + result = runner.invoke( 407 407 + call_app, 408 408 + [ 409 409 + "todos", 410 410 + "add", 411 411 + "Draft Q1 plan", 412 412 + "--day", 413 413 + "20240102", 414 414 + "--facet", 415 415 + dst_facet, 416 416 + "--force", 417 417 + ], 418 418 + ) 419 419 + assert result.exit_code == 0 420 420 + assert "Draft Q1 plan" in result.output 421 421 + 422 422 + def test_add_succeeds_when_no_matches(self, move_env): 423 423 + """Adding a unique todo succeeds normally.""" 424 424 + _, src_facet, dst_facet = move_env([{"text": "Buy groceries"}], day="20240102") 425 425 + result = runner.invoke( 426 426 + call_app, 427 427 + ["todos", "add", "Draft Q1 plan", "--day", "20240102", "--facet", dst_facet], 428 428 + ) 429 429 + assert result.exit_code == 0 430 430 + assert "Draft Q1 plan" in result.output 431 431 + 432 432 + def test_add_dedup_stderr_format(self, move_env): 433 433 + """Rejection message includes score, facet, day, line, and text.""" 434 434 + _, src_facet, dst_facet = move_env([{"text": "Draft Q1 plan"}], day="20240102") 435 435 + result = runner.invoke( 436 436 + call_app, 437 437 + ["todos", "add", "Draft Q1 plan", "--day", "20240102", "--facet", dst_facet], 438 438 + ) 439 439 + assert result.exit_code == 1 440 440 + assert "100%" in result.output 441 441 + assert src_facet in result.output 442 442 + assert "20240102" in result.output 443 443 + assert "line 1" in result.output 444 444 + assert "--force" in result.output

+81

apps/todos/tests/test_todo.py

reviewed

··· 13 13 from apps.todos.todo import ( 14 14 TodoChecklist, 15 15 TodoItem, 16 16 + find_cross_facet_matches, 16 17 get_facets_with_todos, 17 18 get_todos, 18 19 upcoming, ··· 709 710 assert item.created_at == original_created 710 711 # updated_at is current time 711 712 assert before <= item.updated_at <= after 713 713 + 714 714 + 715 715 + class TestFindCrossFacetMatches: 716 716 + """Tests for find_cross_facet_matches() cross-facet duplicate detection.""" 717 717 + 718 718 + def test_detects_duplicate_in_other_facet(self, monkeypatch, journal_root): 719 719 + """Exact duplicate in another facet is detected.""" 720 720 + monkeypatch.setenv("_SOLSTONE_JOURNAL_OVERRIDE", str(journal_root)) 721 721 + _write_todos(journal_root, "work", "20240102", [{"text": "Draft Q1 plan"}]) 722 722 + matches = find_cross_facet_matches("Draft Q1 plan", "20240102", "personal") 723 723 + assert len(matches) == 1 724 724 + assert matches[0]["score"] == 100.0 725 725 + assert matches[0]["facet"] == "work" 726 726 + assert matches[0]["day"] == "20240102" 727 727 + assert matches[0]["line"] == 1 728 728 + 729 729 + def test_detects_fuzzy_match(self, monkeypatch, journal_root): 730 730 + """Fuzzy match above threshold is detected.""" 731 731 + monkeypatch.setenv("_SOLSTONE_JOURNAL_OVERRIDE", str(journal_root)) 732 732 + _write_todos( 733 733 + journal_root, 734 734 + "work", 735 735 + "20240102", 736 736 + [{"text": "Draft Q1 plan doc"}], 737 737 + ) 738 738 + matches = find_cross_facet_matches("Draft Q1 plan", "20240102", "personal") 739 739 + assert len(matches) >= 1 740 740 + assert matches[0]["score"] >= 70.0 741 741 + 742 742 + def test_no_false_positives(self, monkeypatch, journal_root): 743 743 + """Unrelated todos in other facets are not flagged.""" 744 744 + monkeypatch.setenv("_SOLSTONE_JOURNAL_OVERRIDE", str(journal_root)) 745 745 + _write_todos(journal_root, "work", "20240102", [{"text": "Buy groceries"}]) 746 746 + matches = find_cross_facet_matches("Draft Q1 plan", "20240102", "personal") 747 747 + assert len(matches) == 0 748 748 + 749 749 + def test_excludes_own_facet(self, monkeypatch, journal_root): 750 750 + """Todos in the requesting facet are excluded.""" 751 751 + monkeypatch.setenv("_SOLSTONE_JOURNAL_OVERRIDE", str(journal_root)) 752 752 + _write_todos(journal_root, "personal", "20240102", [{"text": "Draft Q1 plan"}]) 753 753 + matches = find_cross_facet_matches("Draft Q1 plan", "20240102", "personal") 754 754 + assert len(matches) == 0 755 755 + 756 756 + def test_excludes_cancelled(self, monkeypatch, journal_root): 757 757 + """Cancelled todos are not matched.""" 758 758 + monkeypatch.setenv("_SOLSTONE_JOURNAL_OVERRIDE", str(journal_root)) 759 759 + _write_todos( 760 760 + journal_root, 761 761 + "work", 762 762 + "20240102", 763 763 + [{"text": "Draft Q1 plan", "cancelled": True}], 764 764 + ) 765 765 + matches = find_cross_facet_matches("Draft Q1 plan", "20240102", "personal") 766 766 + assert len(matches) == 0 767 767 + 768 768 + def test_excludes_completed(self, monkeypatch, journal_root): 769 769 + """Completed todos are not matched.""" 770 770 + monkeypatch.setenv("_SOLSTONE_JOURNAL_OVERRIDE", str(journal_root)) 771 771 + _write_todos( 772 772 + journal_root, 773 773 + "work", 774 774 + "20240102", 775 775 + [{"text": "Draft Q1 plan", "completed": True}], 776 776 + ) 777 777 + matches = find_cross_facet_matches("Draft Q1 plan", "20240102", "personal") 778 778 + assert len(matches) == 0 779 779 + 780 780 + def test_day_range_covers_adjacent_days(self, monkeypatch, journal_root): 781 781 + """Matches within ±1 day window are detected.""" 782 782 + monkeypatch.setenv("_SOLSTONE_JOURNAL_OVERRIDE", str(journal_root)) 783 783 + _write_todos(journal_root, "work", "20240101", [{"text": "Draft Q1 plan"}]) 784 784 + _write_todos(journal_root, "work", "20240103", [{"text": "Draft Q1 plan"}]) 785 785 + matches = find_cross_facet_matches("Draft Q1 plan", "20240102", "personal") 786 786 + assert len(matches) == 2 787 787 + 788 788 + def test_empty_journal_returns_empty(self, monkeypatch, journal_root): 789 789 + """No facets returns empty list.""" 790 790 + monkeypatch.setenv("_SOLSTONE_JOURNAL_OVERRIDE", str(journal_root)) 791 791 + matches = find_cross_facet_matches("Draft Q1 plan", "20240102", "personal") 792 792 + assert matches == []

+64

apps/todos/todo.py

reviewed

··· 28 28 "TodoItem", 29 29 "TodoError", 30 30 "TodoEmptyTextError", 31 31 + "find_cross_facet_matches", 31 32 "parse_nudge", 32 33 "format_nudge", 33 34 "get_todos", ··· 718 719 return [] 719 720 720 721 return sorted(days) 722 722 + 723 723 + 724 724 + def find_cross_facet_matches( 725 725 + text: str, 726 726 + day: str, 727 727 + exclude_facet: str, 728 728 + *, 729 729 + threshold: float = 70.0, 730 730 + ) -> list[dict]: 731 731 + """Find fuzzy matches for ``text`` across other facets within a ±1 day window. 732 732 + 733 733 + Args: 734 734 + text: The candidate todo text to check for duplicates. 735 735 + day: Target day in ``YYYYMMDD`` format. Scanning covers day-1, day, day+1. 736 736 + exclude_facet: Facet to skip (the facet being added to). 737 737 + threshold: Minimum ``token_sort_ratio`` score to consider a match (0–100). 738 738 + 739 739 + Returns: 740 740 + List of match dicts sorted by score descending. 741 741 + Each dict: ``{"score": float, "facet": str, "day": str, "text": str, "line": int}``. 742 742 + """ 743 743 + from rapidfuzz import fuzz 744 744 + 745 745 + target = datetime.strptime(day, "%Y%m%d") 746 746 + days = [(target + timedelta(days=d)).strftime("%Y%m%d") for d in (-1, 0, 1)] 747 747 + 748 748 + facets_dir = Path(get_journal()) / "facets" 749 749 + if not facets_dir.is_dir(): 750 750 + return [] 751 751 + 752 752 + matches: list[dict] = [] 753 753 + try: 754 754 + for facet_dir in facets_dir.iterdir(): 755 755 + if not facet_dir.is_dir(): 756 756 + continue 757 757 + facet_name = facet_dir.name 758 758 + if facet_name == exclude_facet: 759 759 + continue 760 760 + 761 761 + for candidate_day in days: 762 762 + todo_path = facet_dir / "todos" / f"{candidate_day}.jsonl" 763 763 + if not todo_path.is_file(): 764 764 + continue 765 765 + checklist = TodoChecklist.load(candidate_day, facet_name) 766 766 + for item in checklist.items: 767 767 + if item.cancelled or item.completed: 768 768 + continue 769 769 + score = fuzz.token_sort_ratio(text, item.text) 770 770 + if score >= threshold: 771 771 + matches.append( 772 772 + { 773 773 + "score": score, 774 774 + "facet": facet_name, 775 775 + "day": candidate_day, 776 776 + "text": item.text, 777 777 + "line": item.index, 778 778 + } 779 779 + ) 780 780 + except OSError: # pragma: no cover - filesystem failure 781 781 + return [] 782 782 + 783 783 + matches.sort(key=lambda match: match["score"], reverse=True) 784 784 + return matches 721 785 722 786 723 787 def format_todos(