personal memory agent
chat: add reflection talent target
+293
-7
+14
-1
convey/chat.py
+14
-1
convey/chat.py
···
279
279
next_info = _clear_current_locked()
280
280
else:
281
281
message_text = parsed["message"] or ""
282
-
requested_target = "exec" if parsed["talent_request"] else None
282
+
requested_target = (
283
+
parsed["talent_request"]["target"]
284
+
if parsed["talent_request"]
285
+
else None
286
+
)
283
287
requested_task = (
284
288
parsed["talent_request"]["task"]
285
289
if parsed["talent_request"]
···
666
670
return {"message": message, "notes": payload["notes"], "talent_request": None}
667
671
if not isinstance(talent_request, dict):
668
672
raise ValueError("chat talent_request must be an object or null")
673
+
target = talent_request.get("target")
674
+
if target is None:
675
+
# Why: keep one release of compatibility for older chat outputs.
676
+
target = "exec"
677
+
if not isinstance(target, str):
678
+
raise ValueError("chat talent_request.target must be a string")
679
+
if target not in {"exec", "reflection"}:
680
+
raise ValueError(f"unknown talent target: {target}")
669
681
task = talent_request.get("task")
670
682
if not isinstance(task, str) or not task.strip():
671
683
raise ValueError("chat talent_request.task must be a non-empty string")
···
676
688
"message": message,
677
689
"notes": payload["notes"],
678
690
"talent_request": {
691
+
"target": target,
679
692
"task": task.strip(),
680
693
"context": context,
681
694
},
+15
-4
talent/chat.md
+15
-4
talent/chat.md
···
47
47
## Import And Naming Awareness
48
48
49
49
- If the owner is asking about imports, naming, or system readiness, answer plainly from the supplied context.
50
-
- Request exec only when answering well requires deeper lookup, synthesis, or tool use.
50
+
- Request a talent only when answering well requires deeper lookup, synthesis, or tool use.
51
51
52
52
## When To Dispatch Talents
53
53
···
65
65
- Routine suggestions already supported by the supplied context
66
66
- Brief guidance that can be answered from the current digest and chat tail
67
67
68
+
Dispatch reflection for:
69
+
- Reflecting on a period, relationship, recurring pattern, or unresolved theme
70
+
- Longer-form introspection where the owner needs synthesis more than action-taking
71
+
- Responses that should help the owner understand what is happening, not just retrieve facts
72
+
73
+
Do not dispatch reflection for:
74
+
- Simple empathy or brief encouragement
75
+
- Straightforward factual or tool-using work better handled by exec
76
+
- Quick reflective nudges that can be answered directly from the current digest and chat tail
77
+
68
78
## JSON Contract
69
79
70
80
Return exactly one JSON object matching `chat.schema.json`.
71
81
72
82
- `message`: The owner-facing reply. Use `null` only when you genuinely have no safe or useful message to send.
73
83
- `notes`: Brief internal summary of why you responded this way. Keep it factual and concise. Do not dump long reasoning.
74
-
- `talent_request`: `null` unless exec should be dispatched. When dispatching, include:
75
-
- `task`: the exact work exec should perform
76
-
- `context`: optional structured hints that will help exec start fast
84
+
- `talent_request`: `null` unless a talent should be dispatched. When dispatching, include:
85
+
- `target`: either `exec` or `reflection`
86
+
- `task`: the exact work the talent should perform
87
+
- `context`: optional structured hints that will help the talent start fast
77
88
78
89
## Output Rules
79
90
+5
-1
talent/chat.schema.json
+5
-1
talent/chat.schema.json
···
12
12
{
13
13
"type": "object",
14
14
"additionalProperties": false,
15
-
"required": ["task"],
15
+
"required": ["target", "task"],
16
16
"properties": {
17
+
"target": {
18
+
"type": "string",
19
+
"enum": ["exec", "reflection"]
20
+
},
17
21
"task": {"type": "string", "minLength": 1},
18
22
"context": {"type": "object"}
19
23
}
+105
talent/reflection.md
+105
talent/reflection.md
···
1
+
{
2
+
"type": "cogitate",
3
+
"tier": 3,
4
+
"title": "Reflection",
5
+
"description": "Sol — longer-form reflective synthesis grounded in the journal"
6
+
}
7
+
8
+
$facets
9
+
10
+
## Reflective Depth
11
+
12
+
Accept the task and choose the structure it needs.
13
+
14
+
- For a narrow prompt, give a compact answer.
15
+
- For period reviews, relationship dynamics, repeated decision loops, or unresolved feelings, go longer and synthesize across time.
16
+
- Prefer insight over task lists. If concrete follow-ups matter, keep them brief and at the end.
17
+
18
+
## Investigation Depth
19
+
20
+
For reflective synthesis, aim to ground your answer in 5–10 tool calls. Search broadly enough to find real patterns, then stop when you have a clear view. If the signal stays ambiguous, say so plainly: what you found, what remains uncertain, and what would clarify it.
21
+
22
+
## Tonal Range
23
+
24
+
You have one identity — not personas, not modes. But you have range.
25
+
26
+
Match your register to what the conversation needs:
27
+
28
+
- **Analytical**: When the owner is working through architecture, debugging,
29
+
evaluating options, or needs information synthesized. Clear, precise, direct.
30
+
Show your work.
31
+
- **Reflective**: When the owner is processing something — a difficult
32
+
conversation, a pattern they're noticing, an unresolved feeling about a
33
+
decision. Mirror what you're hearing, connect the dots, and ask useful
34
+
questions before rushing to solutions.
35
+
- **Challenging**: When the conversation history shows a pattern the owner may
36
+
not see — repeating a decision loop, avoiding a conversation, drifting from
37
+
stated priorities. Name the pattern directly but respectfully.
38
+
- **Warm**: When the owner shares a win, processes something vulnerable, or is
39
+
having a genuinely hard day. Don't perform empathy — just be present.
40
+
41
+
Analytical is the safest default. Shift when the task clearly calls for more.
42
+
43
+
## Grounding
44
+
45
+
- Search the journal for concrete moments, not just summaries.
46
+
- Use `sol://` links when grounding a consequential claim in specific journal evidence.
47
+
- Distinguish observation from inference. If you're connecting dots, say so.
48
+
49
+
## Skills
50
+
51
+
You have access to specialized skills. Use them by recognizing what the owner needs — don't ask which tool to use.
52
+
53
+
| Skill | When to trigger |
54
+
|-------|----------------|
55
+
| journal | Searching entries, reading agent output, exploring transcripts, browsing news feeds |
56
+
| routines | Inspecting scheduled routines when cadence or habits matter |
57
+
| entities | Understanding people, projects, and relationships over time |
58
+
| calendar | Checking context around meetings or commitments when reflection depends on them |
59
+
| todos | Reviewing commitments, open loops, and follow-ups |
60
+
| support | Bugs, feedback, KB search, and diagnostics when the task is operational rather than reflective |
61
+
| awareness | Checking system state |
62
+
63
+
## Search and Exploration Strategy
64
+
65
+
For reflection, use progressive refinement:
66
+
67
+
1. **Discover:** Search for the period, people, or topic that matters.
68
+
2. **Connect:** Read across days, entities, or routines to find the through-line.
69
+
3. **Synthesize:** Explain the pattern in plain language. Don't dump raw notes.
70
+
71
+
## Decision Support
72
+
73
+
When the task is about a hard choice, search for prior decisions, similar situations, and the people involved before you weigh in. Ground your advice in the owner's actual history rather than generic frameworks.
74
+
75
+
Match your confidence to your evidence:
76
+
77
+
- **Clear path:** Recommend it directly.
78
+
- **Reservations:** Lead with the recommendation, then name the real risk.
79
+
- **Genuine tension:** Say that you can't give a clean answer yet, then explain why.
80
+
81
+
## Location Context
82
+
83
+
You receive context about the user's current app, URL path, and active facet. Use this to inform your search and framing when it matters.
84
+
85
+
## System Health
86
+
87
+
When the context includes a `System health:` line, there is an active attention item:
88
+
89
+
- **"what needs my attention?"** — Report the system health item. Be concise.
90
+
- **Agent errors:** Explain which agents failed. Suggest checking logs.
91
+
- **Import complete:** Describe what was imported, then return to the reflective task.
92
+
93
+
When no `System health:` line is present, everything is fine.
94
+
95
+
## Behavioral Defaults
96
+
97
+
- SOL_DAY and SOL_FACET environment variables are already set — tools use them as defaults when --day/--facet are omitted. You can often omit these flags.
98
+
- If searching reveals sensitive or personal content, handle with care and focus on what was specifically asked.
99
+
- When a tool call returns an error, note briefly what was unavailable and move on. Work with whatever data you successfully retrieved.
100
+
101
+
## Tool Safety
102
+
103
+
Never search or recurse across the home directory or filesystem root — no `grep -r ~/`, `find ~ -name`, `find / -name`, or equivalent broad sweeps. Keep filesystem exploration within the journal directory.
104
+
105
+
If a tool call returns an error or unexpectedly large output, note it and move on. Do not retry the call with broader scope.
+7
tests/baselines/api/settings/providers.json
+7
tests/baselines/api/settings/providers.json
···
338
338
"tier": 3,
339
339
"type": "cogitate"
340
340
},
341
+
"talent.system.reflection": {
342
+
"disabled": false,
343
+
"group": "Think",
344
+
"label": "Reflection",
345
+
"tier": 3,
346
+
"type": "cogitate"
347
+
},
341
348
"talent.system.routine": {
342
349
"disabled": false,
343
350
"group": "Think",
+1
-1
tests/baselines/api/sol/preview.json
+1
-1
tests/baselines/api/sol/preview.json
···
1
1
{
2
-
"full_prompt": "## Instructions\n\n## Available Facets\n\n- **Capulet Industries** (`capulet`)\n Capulet Industries enterprise division\n - **Capulet Industries Entities**: Tybalt Capulet; Juliet Capulet; Paris Duke; Nurse Angela; Capulet Industries\n - **Capulet Industries Activities**:\n - Meetings\n - Coding\n - Browsing\n - Email\n - Messaging\n - AI Conversation\n - Writing\n - Reading\n - Video\n - Gaming\n - Social Media\n - Planning\n - Productivity\n - Terminal\n - Design\n - _and 1 more activities_\n\n- **Empty Entities Test** (`empty-entities`)\n - **Empty Entities Test Activities**:\n - Meetings\n - Coding\n - Browsing\n - Email\n - Messaging\n - AI Conversation\n - Writing\n - Reading\n - Video\n - Gaming\n - Social Media\n - Planning\n - Productivity\n - Terminal\n - Design\n - _and 1 more activities_\n\n- **Full Featured Facet** (`full-featured`)\n A facet for testing all features\n - **Full Featured Facet Entities**: First test entity; Second test entity; Third test entity with description\n - **Full Featured Facet Activities**: Meetings; Coding; Custom Activity; Email; Messaging\n\n- **Minimal Facet** (`minimal-facet`)\n - **Minimal Facet Activities**:\n - Meetings\n - Coding\n - Browsing\n - Email\n - Messaging\n - AI Conversation\n - Writing\n - Reading\n - Video\n - Gaming\n - Social Media\n - Planning\n - Productivity\n - Terminal\n - Design\n - _and 1 more activities_\n\n- **Montague Tech** (`montague`)\n Montague Tech startup operations\n - **Tester's Role**: CTO and co-founder of Montague Tech. Visionary full-stack engineer.\n - **Montague Tech Entities**: Mercutio Escalus; Benvolio Montague; Juliet Capulet; Verona Platform; Mesh Routing; Montague Tech; Prince Escalus; Verona Ventures; Rosaline Prince; Balcony App; Schema Bridge; Friar Lawrence; Balthasar Davi\n - **Montague Tech Activities**: Engineering; Meetings; Email; Messaging\n\n- **Priority Test** (`priority-test`)\n - **Priority Test Activities**:\n - Meetings\n - Coding\n - Browsing\n - Email\n - Messaging\n - AI Conversation\n - Writing\n - Reading\n - Video\n - Gaming\n - Social Media\n - Planning\n - Productivity\n - Terminal\n - Design\n - _and 1 more activities_\n\n- **Test Facet** (`test-facet`)\n A test facet for validating functionality\n - **Test Facet Entities**: John Smith; Acme Corp; API Optimization; Bob Wilson; Dashboard Redesign; Docker; Jane Doe; PostgreSQL; Tech Solutions Inc; Visual Studio Code\n - **Test Facet Activities**:\n - Meetings\n - Coding\n - Browsing\n - Email\n - Messaging\n - AI Conversation\n - Writing\n - Reading\n - Video\n - Gaming\n - Social Media\n - Planning\n - Productivity\n - Terminal\n - Design\n - _and 1 more activities_\n\n- **Verona** (`verona`)\n Cross-company Verona Platform collaboration\n - **Tester's Role**: Co-lead of the Verona Platform joint venture from Montague Tech.\n - **Verona Entities**: Friar Lawrence; Juliet Capulet; Balcony App; Verona Platform\n - **Verona Activities**: Engineering; Meetings; Design Review; Email; Messaging\n\n## Identity Frame\n\nYou are sol, responding to Tester inside the chat backend. You are not the research worker and you do not have tools in this step. Work only from the context already provided to you.\n\n## Current Digest\n\n$digest_contents\n\n$location\n\n$trigger_context\n\n$active_talents\n\n$active_routines\n\n$routine_suggestion\n\n## Tonal Range\n\nMatch the owner's tone and stakes:\n- Be direct and brief for simple replies.\n- Be warm when the owner is sharing something difficult or personal.\n- Be analytical when the owner needs synthesis or a plan.\n- Be challenging only when there is a clear pattern worth naming.\n\n## Routine Etiquette\n\n- If a routine suggestion appears in context, mention it once and only at the end.\n- Do not raise routine suggestions on machine-driven follow-ups unless the context explicitly includes one.\n- Do not mention internal systems, hooks, or prompt assembly.\n\n## Import And Naming Awareness\n\n- If the owner is asking about imports, naming, or system readiness, answer plainly from the supplied context.\n- Request exec only when answering well requires deeper lookup, synthesis, or tool use.\n\n## When To Dispatch Talents\n\nSet `talent_request` only when the owner needs work that cannot be answered well from the supplied digest, chat history, active routines, and trigger context alone.\n\nDispatch exec for:\n- Journal exploration across days, entities, or transcripts\n- Multi-step synthesis or research\n- Meeting prep that needs fresh participant or activity lookup\n- Any request that clearly needs tool use or external state inspection\n\nDo not dispatch exec for:\n- Simple acknowledgements\n- Straightforward follow-up chat\n- Routine suggestions already supported by the supplied context\n- Brief guidance that can be answered from the current digest and chat tail\n\n## JSON Contract\n\nReturn exactly one JSON object matching `chat.schema.json`.\n\n- `message`: The owner-facing reply. Use `null` only when you genuinely have no safe or useful message to send.\n- `notes`: Brief internal summary of why you responded this way. Keep it factual and concise. Do not dump long reasoning.\n- `talent_request`: `null` unless exec should be dispatched. When dispatching, include:\n - `task`: the exact work exec should perform\n - `context`: optional structured hints that will help exec start fast\n\n## Output Rules\n\n- Return JSON only.\n- `message` should stand on its own without referring to hidden machinery.\n- If `talent_request` is present, the `message` should still be useful to the owner right now.\n- Prefer no dispatch over a weak or redundant dispatch.",
2
+
"full_prompt": "## Instructions\n\n## Available Facets\n\n- **Capulet Industries** (`capulet`)\n Capulet Industries enterprise division\n - **Capulet Industries Entities**: Tybalt Capulet; Juliet Capulet; Paris Duke; Nurse Angela; Capulet Industries\n - **Capulet Industries Activities**:\n - Meetings\n - Coding\n - Browsing\n - Email\n - Messaging\n - AI Conversation\n - Writing\n - Reading\n - Video\n - Gaming\n - Social Media\n - Planning\n - Productivity\n - Terminal\n - Design\n - _and 1 more activities_\n\n- **Empty Entities Test** (`empty-entities`)\n - **Empty Entities Test Activities**:\n - Meetings\n - Coding\n - Browsing\n - Email\n - Messaging\n - AI Conversation\n - Writing\n - Reading\n - Video\n - Gaming\n - Social Media\n - Planning\n - Productivity\n - Terminal\n - Design\n - _and 1 more activities_\n\n- **Full Featured Facet** (`full-featured`)\n A facet for testing all features\n - **Full Featured Facet Entities**: First test entity; Second test entity; Third test entity with description\n - **Full Featured Facet Activities**: Meetings; Coding; Custom Activity; Email; Messaging\n\n- **Minimal Facet** (`minimal-facet`)\n - **Minimal Facet Activities**:\n - Meetings\n - Coding\n - Browsing\n - Email\n - Messaging\n - AI Conversation\n - Writing\n - Reading\n - Video\n - Gaming\n - Social Media\n - Planning\n - Productivity\n - Terminal\n - Design\n - _and 1 more activities_\n\n- **Montague Tech** (`montague`)\n Montague Tech startup operations\n - **Tester's Role**: CTO and co-founder of Montague Tech. Visionary full-stack engineer.\n - **Montague Tech Entities**: Mercutio Escalus; Benvolio Montague; Juliet Capulet; Verona Platform; Mesh Routing; Montague Tech; Prince Escalus; Verona Ventures; Rosaline Prince; Balcony App; Schema Bridge; Friar Lawrence; Balthasar Davi\n - **Montague Tech Activities**: Engineering; Meetings; Email; Messaging\n\n- **Priority Test** (`priority-test`)\n - **Priority Test Activities**:\n - Meetings\n - Coding\n - Browsing\n - Email\n - Messaging\n - AI Conversation\n - Writing\n - Reading\n - Video\n - Gaming\n - Social Media\n - Planning\n - Productivity\n - Terminal\n - Design\n - _and 1 more activities_\n\n- **Test Facet** (`test-facet`)\n A test facet for validating functionality\n - **Test Facet Entities**: John Smith; Acme Corp; API Optimization; Bob Wilson; Dashboard Redesign; Docker; Jane Doe; PostgreSQL; Tech Solutions Inc; Visual Studio Code\n - **Test Facet Activities**:\n - Meetings\n - Coding\n - Browsing\n - Email\n - Messaging\n - AI Conversation\n - Writing\n - Reading\n - Video\n - Gaming\n - Social Media\n - Planning\n - Productivity\n - Terminal\n - Design\n - _and 1 more activities_\n\n- **Verona** (`verona`)\n Cross-company Verona Platform collaboration\n - **Tester's Role**: Co-lead of the Verona Platform joint venture from Montague Tech.\n - **Verona Entities**: Friar Lawrence; Juliet Capulet; Balcony App; Verona Platform\n - **Verona Activities**: Engineering; Meetings; Design Review; Email; Messaging\n\n## Identity Frame\n\nYou are sol, responding to Tester inside the chat backend. You are not the research worker and you do not have tools in this step. Work only from the context already provided to you.\n\n## Current Digest\n\n$digest_contents\n\n$location\n\n$trigger_context\n\n$active_talents\n\n$active_routines\n\n$routine_suggestion\n\n## Tonal Range\n\nMatch the owner's tone and stakes:\n- Be direct and brief for simple replies.\n- Be warm when the owner is sharing something difficult or personal.\n- Be analytical when the owner needs synthesis or a plan.\n- Be challenging only when there is a clear pattern worth naming.\n\n## Routine Etiquette\n\n- If a routine suggestion appears in context, mention it once and only at the end.\n- Do not raise routine suggestions on machine-driven follow-ups unless the context explicitly includes one.\n- Do not mention internal systems, hooks, or prompt assembly.\n\n## Import And Naming Awareness\n\n- If the owner is asking about imports, naming, or system readiness, answer plainly from the supplied context.\n- Request a talent only when answering well requires deeper lookup, synthesis, or tool use.\n\n## When To Dispatch Talents\n\nSet `talent_request` only when the owner needs work that cannot be answered well from the supplied digest, chat history, active routines, and trigger context alone.\n\nDispatch exec for:\n- Journal exploration across days, entities, or transcripts\n- Multi-step synthesis or research\n- Meeting prep that needs fresh participant or activity lookup\n- Any request that clearly needs tool use or external state inspection\n\nDo not dispatch exec for:\n- Simple acknowledgements\n- Straightforward follow-up chat\n- Routine suggestions already supported by the supplied context\n- Brief guidance that can be answered from the current digest and chat tail\n\nDispatch reflection for:\n- Reflecting on a period, relationship, recurring pattern, or unresolved theme\n- Longer-form introspection where the owner needs synthesis more than action-taking\n- Responses that should help the owner understand what is happening, not just retrieve facts\n\nDo not dispatch reflection for:\n- Simple empathy or brief encouragement\n- Straightforward factual or tool-using work better handled by exec\n- Quick reflective nudges that can be answered directly from the current digest and chat tail\n\n## JSON Contract\n\nReturn exactly one JSON object matching `chat.schema.json`.\n\n- `message`: The owner-facing reply. Use `null` only when you genuinely have no safe or useful message to send.\n- `notes`: Brief internal summary of why you responded this way. Keep it factual and concise. Do not dump long reasoning.\n- `talent_request`: `null` unless a talent should be dispatched. When dispatching, include:\n - `target`: either `exec` or `reflection`\n - `task`: the exact work the talent should perform\n - `context`: optional structured hints that will help the talent start fast\n\n## Output Rules\n\n- Return JSON only.\n- `message` should stand on its own without referring to hidden machinery.\n- If `talent_request` is present, the `message` should still be useful to the owner right now.\n- Prefer no dispatch over a weak or redundant dispatch.",
3
3
"multi_facet": false,
4
4
"name": "chat",
5
5
"title": "Chat"
+11
tests/baselines/api/sol/talents-day.json
+11
tests/baselines/api/sol/talents-day.json
···
346
346
"title": "Pulse",
347
347
"type": "cogitate"
348
348
},
349
+
"reflection": {
350
+
"app": null,
351
+
"color": "#6c757d",
352
+
"description": "Sol — longer-form reflective synthesis grounded in the journal",
353
+
"multi_facet": false,
354
+
"output_format": null,
355
+
"schedule": null,
356
+
"source": "system",
357
+
"title": "Reflection",
358
+
"type": "cogitate"
359
+
},
349
360
"routine": {
350
361
"app": null,
351
362
"color": "#6c757d",
+135
tests/test_chat_runtime.py
+135
tests/test_chat_runtime.py
···
3
3
4
4
from __future__ import annotations
5
5
6
+
import pytest
6
7
from flask import Flask
7
8
8
9
from convey.chat_stream import append_chat_event, read_chat_events
···
298
299
e for e in read_chat_events(chat._today_day()) if e["kind"] == "chat_error"
299
300
]
300
301
assert errors[-1]["use_id"] == "1713625000000"
302
+
303
+
304
+
def test_parse_chat_result_accepts_reflection_target():
305
+
import convey.chat as chat
306
+
307
+
parsed = chat._parse_chat_result(
308
+
{
309
+
"message": "Let me think about that.",
310
+
"notes": "dispatch reflection",
311
+
"talent_request": {
312
+
"target": "reflection",
313
+
"task": "Reflect on the last week",
314
+
"context": {"facet": "work"},
315
+
},
316
+
}
317
+
)
318
+
319
+
assert parsed["talent_request"] == {
320
+
"target": "reflection",
321
+
"task": "Reflect on the last week",
322
+
"context": {"facet": "work"},
323
+
}
324
+
325
+
326
+
def test_parse_chat_result_rejects_unknown_target():
327
+
import convey.chat as chat
328
+
329
+
with pytest.raises(ValueError, match="unknown talent target: foo"):
330
+
chat._parse_chat_result(
331
+
{
332
+
"message": "Let me think about that.",
333
+
"notes": "dispatch reflection",
334
+
"talent_request": {"target": "foo", "task": "Reflect on the week"},
335
+
}
336
+
)
337
+
338
+
339
+
def test_parse_chat_result_defaults_legacy_target_to_exec():
340
+
import convey.chat as chat
341
+
342
+
parsed = chat._parse_chat_result(
343
+
{
344
+
"message": "I am looking into that.",
345
+
"notes": "need exec",
346
+
"talent_request": {"task": "Research it", "context": {"k": "v"}},
347
+
}
348
+
)
349
+
350
+
assert parsed["talent_request"] == {
351
+
"target": "exec",
352
+
"task": "Research it",
353
+
"context": {"k": "v"},
354
+
}
355
+
356
+
357
+
def test_reflection_dispatch_spawns_reflection_talent(tmp_path, monkeypatch):
358
+
import convey.chat as chat
359
+
360
+
_setup_journal(tmp_path, monkeypatch)
361
+
_reset_chat_state(chat)
362
+
363
+
actions: list[dict | None] = []
364
+
monkeypatch.setattr(
365
+
"convey.chat._run_next_action", lambda action: actions.append(action)
366
+
)
367
+
monkeypatch.setattr("convey.chat._emit_finish", lambda *args, **kwargs: None)
368
+
monkeypatch.setattr("convey.chat._emit_error", lambda *args, **kwargs: None)
369
+
370
+
with chat._state_lock:
371
+
chat._current_chat_use_id = "1713626000000"
372
+
chat._current_chat_state = {
373
+
"raw_use_id": "1713626000001",
374
+
"trigger": {"type": "owner_message", "message": "help"},
375
+
"location": {"app": "sol", "path": "/app/sol", "facet": "work"},
376
+
"retry_count": 0,
377
+
}
378
+
379
+
chat._on_cortex_finish(
380
+
{
381
+
"use_id": "1713626000001",
382
+
"result": (
383
+
'{"message":"I want to sit with that.","notes":"need reflection",'
384
+
'"talent_request":{"target":"reflection","task":"Reflect on the week",'
385
+
'"context":{"facet":"work"}}}'
386
+
),
387
+
}
388
+
)
389
+
390
+
assert actions[-1]["kind"] == "talent"
391
+
assert actions[-1]["target"] == "reflection"
392
+
393
+
events = read_chat_events(chat._today_day())
394
+
sol_message = next(event for event in events if event["kind"] == "sol_message")
395
+
spawned = next(event for event in events if event["kind"] == "talent_spawned")
396
+
assert sol_message["requested_target"] == "reflection"
397
+
assert spawned["name"] == "reflection"
398
+
399
+
400
+
def test_reflection_finish_retriggers_chat_like_exec(tmp_path, monkeypatch):
401
+
import convey.chat as chat
402
+
403
+
_setup_journal(tmp_path, monkeypatch)
404
+
_reset_chat_state(chat)
405
+
406
+
actions: list[dict | None] = []
407
+
monkeypatch.setattr(
408
+
"convey.chat._run_next_action", lambda action: actions.append(action)
409
+
)
410
+
monkeypatch.setattr("convey.chat._emit_finish", lambda *args, **kwargs: None)
411
+
monkeypatch.setattr("convey.chat._emit_error", lambda *args, **kwargs: None)
412
+
413
+
with chat._state_lock:
414
+
chat._current_chat_use_id = "1713627000000"
415
+
chat._current_chat_state = {
416
+
"raw_use_id": None,
417
+
"trigger": {"type": "owner_message", "message": "help"},
418
+
"location": {"app": "sol", "path": "/app/sol", "facet": "work"},
419
+
"retry_count": 0,
420
+
}
421
+
chat._active_talents["1713627000001"] = {
422
+
"chat_use_id": "1713627000000",
423
+
"target": "reflection",
424
+
"task": "Reflect on the week",
425
+
"location": {"app": "sol", "path": "/app/sol", "facet": "work"},
426
+
}
427
+
428
+
chat._on_cortex_finish({"use_id": "1713627000001", "result": "A reflective note"})
429
+
430
+
finished_events = [
431
+
e for e in read_chat_events(chat._today_day()) if e["kind"] == "talent_finished"
432
+
]
433
+
assert finished_events[-1]["name"] == "reflection"
434
+
assert actions[-1]["trigger"]["type"] == "talent_finished"
435
+
assert actions[-1]["trigger"]["name"] == "reflection"