this repo has no description
test(handler): add source field tests for API handlers
Add comprehensive tests for multi-source support in API
handlers: source-scoped duplicate detection, source query
param filtering, omitempty JSON serialization for null
source fields, and source field passthrough to store layer.
+471
-9
+471
-9
internal/handler/api_v1_links_test.go
+471
-9
internal/handler/api_v1_links_test.go
···
18
18
// methods we need for testing.
19
19
type mockAPIStore struct {
20
20
data.Store
21
-
links []data.IRCLink
22
-
linkByID *data.IRCLink
23
-
linkByIDFn func(id int) (*data.IRCLink, error)
24
-
linksByURL []data.IRCLink
25
-
linksByURLFn func(url string) ([]data.IRCLink, error)
26
-
insertedLinkID int
27
-
insertLinkFn func(link *data.IRCLink) (int, error)
28
-
deleteLinkFn func(id int) error
29
-
err error
21
+
links []data.IRCLink
22
+
linkByID *data.IRCLink
23
+
linkByIDFn func(id int) (*data.IRCLink, error)
24
+
linksByURL []data.IRCLink
25
+
linksByURLFn func(url string) ([]data.IRCLink, error)
26
+
linksByURLFilterFn func(url string, filter data.SourceFilter) ([]data.IRCLink, error)
27
+
recentLinksFn func(filter data.SourceFilter) ([]data.IRCLink, error)
28
+
insertedLinkID int
29
+
insertLinkFn func(link *data.IRCLink) (int, error)
30
+
lastInsertedLink *data.IRCLink
31
+
deleteLinkFn func(id int) error
32
+
err error
30
33
}
31
34
32
35
func (m *mockAPIStore) GetRecentIRCLinks(ctx context.Context, days int, offsetDays int, filter data.SourceFilter) ([]data.IRCLink, error) {
36
+
if m.recentLinksFn != nil {
37
+
return m.recentLinksFn(filter)
38
+
}
33
39
if m.err != nil {
34
40
return nil, m.err
35
41
}
···
47
53
}
48
54
49
55
func (m *mockAPIStore) GetIRCLinksByURL(ctx context.Context, url string, filter data.SourceFilter) ([]data.IRCLink, error) {
56
+
if m.linksByURLFilterFn != nil {
57
+
return m.linksByURLFilterFn(url, filter)
58
+
}
50
59
if m.linksByURLFn != nil {
51
60
return m.linksByURLFn(url)
52
61
}
···
57
66
}
58
67
59
68
func (m *mockAPIStore) InsertIRCLink(ctx context.Context, link *data.IRCLink) (int, error) {
69
+
m.lastInsertedLink = link
60
70
if m.insertLinkFn != nil {
61
71
return m.insertLinkFn(link)
62
72
}
···
1101
1111
})
1102
1112
}
1103
1113
}
1114
+
1115
+
func TestAPIv1_CreateLink_SourceDuplicates(t *testing.T) {
1116
+
now := time.Now()
1117
+
irc := "irc"
1118
+
freenode := "freenode"
1119
+
channel := "#general"
1120
+
userID := "U12345"
1121
+
userName := "alice"
1122
+
1123
+
t.Run("same URL different source is not duplicate", func(t *testing.T) {
1124
+
store := &mockAPIStore{
1125
+
insertedLinkID: 42,
1126
+
linksByURLFilterFn: func(url string, filter data.SourceFilter) ([]data.IRCLink, error) {
1127
+
// When filtering by slack source, no existing links found
1128
+
if filter.SourceType != nil && *filter.SourceType == "slack" {
1129
+
return []data.IRCLink{}, nil
1130
+
}
1131
+
// For other filters, return existing IRC link
1132
+
return []data.IRCLink{
1133
+
{ID: 10, Timestamp: now, User: "bob", Title: "Old", URL: url},
1134
+
}, nil
1135
+
},
1136
+
}
1137
+
handler := &Handler{
1138
+
Store: store,
1139
+
Config: &config.Config{},
1140
+
}
1141
+
1142
+
body := `{"url":"https://example.com/article","user":"alice","source_type":"slack","source_network":"workspace1","source_channel":"#general"}`
1143
+
req := httptest.NewRequest(http.MethodPost, "/api/v1/links", strings.NewReader(body))
1144
+
req.RemoteAddr = "127.0.0.1:12345"
1145
+
req.Header.Set("Content-Type", "application/json")
1146
+
w := httptest.NewRecorder()
1147
+
1148
+
handler.APIv1LinksHandler(w, req)
1149
+
1150
+
if w.Code != http.StatusCreated {
1151
+
t.Fatalf("expected status 201, got %d. Body: %s", w.Code, w.Body.String())
1152
+
}
1153
+
1154
+
var resp APILinkCreateResponse
1155
+
if err := json.Unmarshal(w.Body.Bytes(), &resp); err != nil {
1156
+
t.Fatalf("failed to unmarshal response: %v", err)
1157
+
}
1158
+
if resp.IsDuplicate {
1159
+
t.Error("expected is_duplicate=false for different source, got true")
1160
+
}
1161
+
if resp.SourceType == nil || *resp.SourceType != "slack" {
1162
+
t.Error("expected source_type=slack in response")
1163
+
}
1164
+
})
1165
+
1166
+
t.Run("same URL same source is duplicate", func(t *testing.T) {
1167
+
store := &mockAPIStore{
1168
+
insertedLinkID: 43,
1169
+
linksByURLFilterFn: func(url string, filter data.SourceFilter) ([]data.IRCLink, error) {
1170
+
// Same source type filter matches existing link
1171
+
if filter.SourceType != nil && *filter.SourceType == "irc" {
1172
+
return []data.IRCLink{
1173
+
{ID: 10, Timestamp: now, User: "bob", Title: "Old", URL: url},
1174
+
}, nil
1175
+
}
1176
+
return []data.IRCLink{}, nil
1177
+
},
1178
+
}
1179
+
handler := &Handler{
1180
+
Store: store,
1181
+
Config: &config.Config{},
1182
+
}
1183
+
1184
+
body := `{"url":"https://example.com/article","user":"alice","source_type":"irc","source_network":"freenode","source_channel":"#general"}`
1185
+
req := httptest.NewRequest(http.MethodPost, "/api/v1/links", strings.NewReader(body))
1186
+
req.RemoteAddr = "127.0.0.1:12345"
1187
+
req.Header.Set("Content-Type", "application/json")
1188
+
w := httptest.NewRecorder()
1189
+
1190
+
handler.APIv1LinksHandler(w, req)
1191
+
1192
+
if w.Code != http.StatusCreated {
1193
+
t.Fatalf("expected status 201, got %d. Body: %s", w.Code, w.Body.String())
1194
+
}
1195
+
1196
+
var resp APILinkCreateResponse
1197
+
if err := json.Unmarshal(w.Body.Bytes(), &resp); err != nil {
1198
+
t.Fatalf("failed to unmarshal response: %v", err)
1199
+
}
1200
+
if !resp.IsDuplicate {
1201
+
t.Error("expected is_duplicate=true for same source, got false")
1202
+
}
1203
+
if len(resp.PreviousSubmissions) != 1 {
1204
+
t.Fatalf("expected 1 previous submission, got %d", len(resp.PreviousSubmissions))
1205
+
}
1206
+
})
1207
+
1208
+
t.Run("no source fields uses global fallback", func(t *testing.T) {
1209
+
store := &mockAPIStore{
1210
+
insertedLinkID: 44,
1211
+
linksByURL: []data.IRCLink{
1212
+
{ID: 10, Timestamp: now, User: "bob", Title: "Old", URL: "https://example.com/article"},
1213
+
},
1214
+
}
1215
+
handler := &Handler{
1216
+
Store: store,
1217
+
Config: &config.Config{},
1218
+
}
1219
+
1220
+
body := `{"url":"https://example.com/article","user":"alice"}`
1221
+
req := httptest.NewRequest(http.MethodPost, "/api/v1/links", strings.NewReader(body))
1222
+
req.RemoteAddr = "127.0.0.1:12345"
1223
+
req.Header.Set("Content-Type", "application/json")
1224
+
w := httptest.NewRecorder()
1225
+
1226
+
handler.APIv1LinksHandler(w, req)
1227
+
1228
+
if w.Code != http.StatusCreated {
1229
+
t.Fatalf("expected status 201, got %d. Body: %s", w.Code, w.Body.String())
1230
+
}
1231
+
1232
+
var resp APILinkCreateResponse
1233
+
if err := json.Unmarshal(w.Body.Bytes(), &resp); err != nil {
1234
+
t.Fatalf("failed to unmarshal response: %v", err)
1235
+
}
1236
+
if !resp.IsDuplicate {
1237
+
t.Error("expected is_duplicate=true for global fallback, got false")
1238
+
}
1239
+
})
1240
+
1241
+
t.Run("source fields passed through to InsertIRCLink", func(t *testing.T) {
1242
+
store := &mockAPIStore{
1243
+
insertedLinkID: 45,
1244
+
linksByURL: []data.IRCLink{},
1245
+
}
1246
+
handler := &Handler{
1247
+
Store: store,
1248
+
Config: &config.Config{},
1249
+
}
1250
+
1251
+
body := `{"url":"https://example.com/new","user":"alice","source_type":"irc","source_network":"freenode","source_channel":"#general","source_user_id":"U12345","source_user_name":"alice"}`
1252
+
req := httptest.NewRequest(http.MethodPost, "/api/v1/links", strings.NewReader(body))
1253
+
req.RemoteAddr = "127.0.0.1:12345"
1254
+
req.Header.Set("Content-Type", "application/json")
1255
+
w := httptest.NewRecorder()
1256
+
1257
+
handler.APIv1LinksHandler(w, req)
1258
+
1259
+
if w.Code != http.StatusCreated {
1260
+
t.Fatalf("expected status 201, got %d. Body: %s", w.Code, w.Body.String())
1261
+
}
1262
+
1263
+
// Verify source fields were passed to InsertIRCLink
1264
+
inserted := store.lastInsertedLink
1265
+
if inserted == nil {
1266
+
t.Fatal("expected InsertIRCLink to be called")
1267
+
}
1268
+
if inserted.SourceType == nil || *inserted.SourceType != irc {
1269
+
t.Errorf("expected source_type=%q, got %v", irc, inserted.SourceType)
1270
+
}
1271
+
if inserted.SourceNetwork == nil || *inserted.SourceNetwork != freenode {
1272
+
t.Errorf("expected source_network=%q, got %v", freenode, inserted.SourceNetwork)
1273
+
}
1274
+
if inserted.SourceChannel == nil || *inserted.SourceChannel != channel {
1275
+
t.Errorf("expected source_channel=%q, got %v", channel, inserted.SourceChannel)
1276
+
}
1277
+
if inserted.SourceUserID == nil || *inserted.SourceUserID != userID {
1278
+
t.Errorf("expected source_user_id=%q, got %v", userID, inserted.SourceUserID)
1279
+
}
1280
+
if inserted.SourceUserName == nil || *inserted.SourceUserName != userName {
1281
+
t.Errorf("expected source_user_name=%q, got %v", userName, inserted.SourceUserName)
1282
+
}
1283
+
1284
+
// Also verify response contains source fields
1285
+
var resp APILinkCreateResponse
1286
+
if err := json.Unmarshal(w.Body.Bytes(), &resp); err != nil {
1287
+
t.Fatalf("failed to unmarshal response: %v", err)
1288
+
}
1289
+
if resp.SourceType == nil || *resp.SourceType != irc {
1290
+
t.Errorf("expected source_type=%q in response, got %v", irc, resp.SourceType)
1291
+
}
1292
+
if resp.SourceNetwork == nil || *resp.SourceNetwork != freenode {
1293
+
t.Errorf("expected source_network=%q in response, got %v", freenode, resp.SourceNetwork)
1294
+
}
1295
+
if resp.SourceChannel == nil || *resp.SourceChannel != channel {
1296
+
t.Errorf("expected source_channel=%q in response, got %v", channel, resp.SourceChannel)
1297
+
}
1298
+
if resp.SourceUserID == nil || *resp.SourceUserID != userID {
1299
+
t.Errorf("expected source_user_id=%q in response, got %v", userID, resp.SourceUserID)
1300
+
}
1301
+
if resp.SourceUserName == nil || *resp.SourceUserName != userName {
1302
+
t.Errorf("expected source_user_name=%q in response, got %v", userName, resp.SourceUserName)
1303
+
}
1304
+
})
1305
+
}
1306
+
1307
+
func TestAPIv1_ListLinks_SourceFiltering(t *testing.T) {
1308
+
now := time.Now()
1309
+
irc := "irc"
1310
+
slack := "slack"
1311
+
freenode := "freenode"
1312
+
workspace := "myworkspace"
1313
+
chanGeneral := "#general"
1314
+
chanRandom := "#random"
1315
+
1316
+
allLinks := []data.IRCLink{
1317
+
{ID: 1, Timestamp: now, User: "alice", Title: "IRC Link", URL: "https://example.com/1",
1318
+
SourceType: &irc, SourceNetwork: &freenode, SourceChannel: &chanGeneral},
1319
+
{ID: 2, Timestamp: now, User: "bob", Title: "Slack Link", URL: "https://example.com/2",
1320
+
SourceType: &slack, SourceNetwork: &workspace, SourceChannel: &chanRandom},
1321
+
{ID: 3, Timestamp: now, User: "charlie", Title: "No Source Link", URL: "https://example.com/3"},
1322
+
}
1323
+
1324
+
t.Run("no filter returns all links", func(t *testing.T) {
1325
+
store := &mockAPIStore{links: allLinks}
1326
+
handler := &Handler{
1327
+
Store: store,
1328
+
Config: &config.Config{},
1329
+
}
1330
+
1331
+
req := httptest.NewRequest(http.MethodGet, "/api/v1/links", nil)
1332
+
req.RemoteAddr = "127.0.0.1:12345"
1333
+
w := httptest.NewRecorder()
1334
+
1335
+
handler.APIv1LinksHandler(w, req)
1336
+
1337
+
if w.Code != http.StatusOK {
1338
+
t.Fatalf("expected status 200, got %d", w.Code)
1339
+
}
1340
+
1341
+
var resp APILinksResponse
1342
+
if err := json.Unmarshal(w.Body.Bytes(), &resp); err != nil {
1343
+
t.Fatalf("failed to unmarshal response: %v", err)
1344
+
}
1345
+
if len(resp.Data) != 3 {
1346
+
t.Errorf("expected 3 links, got %d", len(resp.Data))
1347
+
}
1348
+
})
1349
+
1350
+
t.Run("filter by source_type returns subset", func(t *testing.T) {
1351
+
ircOnly := []data.IRCLink{allLinks[0]}
1352
+
store := &mockAPIStore{
1353
+
recentLinksFn: func(filter data.SourceFilter) ([]data.IRCLink, error) {
1354
+
if filter.SourceType != nil && *filter.SourceType == "irc" {
1355
+
return ircOnly, nil
1356
+
}
1357
+
return allLinks, nil
1358
+
},
1359
+
}
1360
+
handler := &Handler{
1361
+
Store: store,
1362
+
Config: &config.Config{},
1363
+
}
1364
+
1365
+
req := httptest.NewRequest(http.MethodGet, "/api/v1/links?source_type=irc", nil)
1366
+
req.RemoteAddr = "127.0.0.1:12345"
1367
+
w := httptest.NewRecorder()
1368
+
1369
+
handler.APIv1LinksHandler(w, req)
1370
+
1371
+
if w.Code != http.StatusOK {
1372
+
t.Fatalf("expected status 200, got %d", w.Code)
1373
+
}
1374
+
1375
+
var resp APILinksResponse
1376
+
if err := json.Unmarshal(w.Body.Bytes(), &resp); err != nil {
1377
+
t.Fatalf("failed to unmarshal response: %v", err)
1378
+
}
1379
+
if len(resp.Data) != 1 {
1380
+
t.Fatalf("expected 1 link, got %d", len(resp.Data))
1381
+
}
1382
+
if resp.Data[0].ID != 1 {
1383
+
t.Errorf("expected link ID 1, got %d", resp.Data[0].ID)
1384
+
}
1385
+
if resp.Data[0].SourceType == nil || *resp.Data[0].SourceType != "irc" {
1386
+
t.Errorf("expected source_type=irc, got %v", resp.Data[0].SourceType)
1387
+
}
1388
+
})
1389
+
1390
+
t.Run("source fields included in list response", func(t *testing.T) {
1391
+
store := &mockAPIStore{links: allLinks}
1392
+
handler := &Handler{
1393
+
Store: store,
1394
+
Config: &config.Config{},
1395
+
}
1396
+
1397
+
req := httptest.NewRequest(http.MethodGet, "/api/v1/links", nil)
1398
+
req.RemoteAddr = "127.0.0.1:12345"
1399
+
w := httptest.NewRecorder()
1400
+
1401
+
handler.APIv1LinksHandler(w, req)
1402
+
1403
+
if w.Code != http.StatusOK {
1404
+
t.Fatalf("expected status 200, got %d", w.Code)
1405
+
}
1406
+
1407
+
var resp APILinksResponse
1408
+
if err := json.Unmarshal(w.Body.Bytes(), &resp); err != nil {
1409
+
t.Fatalf("failed to unmarshal response: %v", err)
1410
+
}
1411
+
1412
+
// First link should have IRC source fields
1413
+
link1 := resp.Data[0]
1414
+
if link1.SourceType == nil || *link1.SourceType != "irc" {
1415
+
t.Errorf("expected link 1 source_type=irc, got %v", link1.SourceType)
1416
+
}
1417
+
if link1.SourceNetwork == nil || *link1.SourceNetwork != "freenode" {
1418
+
t.Errorf("expected link 1 source_network=freenode, got %v", link1.SourceNetwork)
1419
+
}
1420
+
if link1.SourceChannel == nil || *link1.SourceChannel != "#general" {
1421
+
t.Errorf("expected link 1 source_channel=#general, got %v", link1.SourceChannel)
1422
+
}
1423
+
1424
+
// Second link should have Slack source fields
1425
+
link2 := resp.Data[1]
1426
+
if link2.SourceType == nil || *link2.SourceType != "slack" {
1427
+
t.Errorf("expected link 2 source_type=slack, got %v", link2.SourceType)
1428
+
}
1429
+
1430
+
// Third link should have nil source fields
1431
+
link3 := resp.Data[2]
1432
+
if link3.SourceType != nil {
1433
+
t.Errorf("expected link 3 source_type=nil, got %v", link3.SourceType)
1434
+
}
1435
+
})
1436
+
}
1437
+
1438
+
func TestAPIv1_LinkResponse_SourceOmitEmpty(t *testing.T) {
1439
+
t.Run("null source fields omitted from JSON", func(t *testing.T) {
1440
+
now := time.Now()
1441
+
store := &mockAPIStore{
1442
+
linkByID: &data.IRCLink{
1443
+
ID: 1,
1444
+
Timestamp: now,
1445
+
User: "testuser",
1446
+
Title: "Test Link",
1447
+
URL: "https://example.com",
1448
+
Clicks: 10,
1449
+
// All source fields are nil
1450
+
},
1451
+
}
1452
+
handler := &Handler{
1453
+
Store: store,
1454
+
Config: &config.Config{},
1455
+
}
1456
+
1457
+
req := httptest.NewRequest(http.MethodGet, "/api/v1/links/1", nil)
1458
+
req.RemoteAddr = "127.0.0.1:12345"
1459
+
w := httptest.NewRecorder()
1460
+
1461
+
handler.APIv1LinksHandler(w, req)
1462
+
1463
+
if w.Code != http.StatusOK {
1464
+
t.Fatalf("expected status 200, got %d", w.Code)
1465
+
}
1466
+
1467
+
body := w.Body.String()
1468
+
1469
+
// Source fields should NOT appear in JSON when nil
1470
+
if strings.Contains(body, "source_type") {
1471
+
t.Error("expected source_type to be omitted from JSON when nil")
1472
+
}
1473
+
if strings.Contains(body, "source_network") {
1474
+
t.Error("expected source_network to be omitted from JSON when nil")
1475
+
}
1476
+
if strings.Contains(body, "source_channel") {
1477
+
t.Error("expected source_channel to be omitted from JSON when nil")
1478
+
}
1479
+
if strings.Contains(body, "source_user_id") {
1480
+
t.Error("expected source_user_id to be omitted from JSON when nil")
1481
+
}
1482
+
if strings.Contains(body, "source_user_name") {
1483
+
t.Error("expected source_user_name to be omitted from JSON when nil")
1484
+
}
1485
+
})
1486
+
1487
+
t.Run("set source fields present in JSON", func(t *testing.T) {
1488
+
now := time.Now()
1489
+
irc := "irc"
1490
+
freenode := "freenode"
1491
+
channel := "#test"
1492
+
userID := "U999"
1493
+
userName := "bob"
1494
+
1495
+
store := &mockAPIStore{
1496
+
linkByID: &data.IRCLink{
1497
+
ID: 2,
1498
+
Timestamp: now,
1499
+
User: "testuser",
1500
+
Title: "Test Link",
1501
+
URL: "https://example.com",
1502
+
Clicks: 5,
1503
+
SourceType: &irc,
1504
+
SourceNetwork: &freenode,
1505
+
SourceChannel: &channel,
1506
+
SourceUserID: &userID,
1507
+
SourceUserName: &userName,
1508
+
},
1509
+
}
1510
+
handler := &Handler{
1511
+
Store: store,
1512
+
Config: &config.Config{},
1513
+
}
1514
+
1515
+
req := httptest.NewRequest(http.MethodGet, "/api/v1/links/2", nil)
1516
+
req.RemoteAddr = "127.0.0.1:12345"
1517
+
w := httptest.NewRecorder()
1518
+
1519
+
handler.APIv1LinksHandler(w, req)
1520
+
1521
+
if w.Code != http.StatusOK {
1522
+
t.Fatalf("expected status 200, got %d", w.Code)
1523
+
}
1524
+
1525
+
var resp APILinkResponse
1526
+
if err := json.Unmarshal(w.Body.Bytes(), &resp); err != nil {
1527
+
t.Fatalf("failed to unmarshal response: %v", err)
1528
+
}
1529
+
1530
+
// Source fields should be present and correct
1531
+
if resp.SourceType == nil || *resp.SourceType != "irc" {
1532
+
t.Errorf("expected source_type=irc, got %v", resp.SourceType)
1533
+
}
1534
+
if resp.SourceNetwork == nil || *resp.SourceNetwork != "freenode" {
1535
+
t.Errorf("expected source_network=freenode, got %v", resp.SourceNetwork)
1536
+
}
1537
+
if resp.SourceChannel == nil || *resp.SourceChannel != "#test" {
1538
+
t.Errorf("expected source_channel=#test, got %v", resp.SourceChannel)
1539
+
}
1540
+
if resp.SourceUserID == nil || *resp.SourceUserID != "U999" {
1541
+
t.Errorf("expected source_user_id=U999, got %v", resp.SourceUserID)
1542
+
}
1543
+
if resp.SourceUserName == nil || *resp.SourceUserName != "bob" {
1544
+
t.Errorf("expected source_user_name=bob, got %v", resp.SourceUserName)
1545
+
}
1546
+
1547
+
// Also verify the raw JSON contains the fields
1548
+
body := w.Body.String()
1549
+
if !strings.Contains(body, `"source_type":"irc"`) {
1550
+
t.Error("expected source_type in JSON response body")
1551
+
}
1552
+
if !strings.Contains(body, `"source_network":"freenode"`) {
1553
+
t.Error("expected source_network in JSON response body")
1554
+
}
1555
+
if !strings.Contains(body, `"source_channel":"#test"`) {
1556
+
t.Error("expected source_channel in JSON response body")
1557
+
}
1558
+
if !strings.Contains(body, `"source_user_id":"U999"`) {
1559
+
t.Error("expected source_user_id in JSON response body")
1560
+
}
1561
+
if !strings.Contains(body, `"source_user_name":"bob"`) {
1562
+
t.Error("expected source_user_name in JSON response body")
1563
+
}
1564
+
})
1565
+
}