CLI app for developers prototyping atproto functionality
test(oauth-client): rename sub-stage snapshots to reflect default-run behavior
The `*_all_pass_snapshot` names from the final-review coverage fix were
misleading: the current sub-stage driver reuses state across per-flow runs
so only a subset of checks actually pass, and the snapshots capture
several SpecViolations. Rename to `*_default_run_snapshot` and add doc
comments explaining the state-reuse caveat. AC8.7 ID coverage is
unchanged.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
+12
-2
+12
-2
tests/oauth_client_substage_snapshots.rs
+12
-2
tests/oauth_client_substage_snapshots.rs
···
62
62
}
63
63
64
64
#[tokio::test]
65
-
async fn scope_variations_all_pass_snapshot() {
65
+
async fn scope_variations_default_run_snapshot() {
66
+
// Drives scope_variations::run against a freshly-bound fake AS with a
67
+
// seeded factory. The current fake-AS driver re-uses state across the
68
+
// sub-stage's per-flow runs, so only FullGrantApprove, PkceRequired and
69
+
// DpopRequired Pass; PartialGrantApprove / UserDenialPropagated /
70
+
// DownscopedRefresh fail because the prior flow's state perturbs them.
71
+
// The snapshot is pinned here primarily for AC8.7 check-ID coverage; the
72
+
// happy-path correctness of individual flows is asserted elsewhere.
66
73
let (server, clock) = spawn_fake_as().await;
67
74
let factory: Arc<dyn RpFactory> = Arc::new(DeterministicRpFactory::new(clock.clone(), SEED));
68
75
let results = scope_variations::run(&server, factory.as_ref(), clock).await;
···
73
80
}
74
81
75
82
#[tokio::test]
76
-
async fn dpop_edges_all_pass_snapshot() {
83
+
async fn dpop_edges_default_run_snapshot() {
84
+
// Same caveat as `scope_variations_default_run_snapshot`: state reuse
85
+
// across the sub-stage's per-flow runs causes several checks to fail in
86
+
// the current driver. Pinned for AC8.7 check-ID coverage.
77
87
let (server, clock) = spawn_fake_as().await;
78
88
let factory: Arc<dyn RpFactory> = Arc::new(DeterministicRpFactory::new(clock.clone(), SEED));
79
89
let results = dpop_edges::run(&server, factory.as_ref(), clock).await;
tests/snapshots/oauth_client_substage_snapshots__dpop_edges_all_pass_snapshot.snap
tests/snapshots/oauth_client_substage_snapshots__dpop_edges_default_run_snapshot.snap
tests/snapshots/oauth_client_substage_snapshots__dpop_edges_all_pass_snapshot.snap
tests/snapshots/oauth_client_substage_snapshots__dpop_edges_default_run_snapshot.snap
tests/snapshots/oauth_client_substage_snapshots__scope_variations_all_pass_snapshot.snap
tests/snapshots/oauth_client_substage_snapshots__scope_variations_default_run_snapshot.snap
tests/snapshots/oauth_client_substage_snapshots__scope_variations_all_pass_snapshot.snap
tests/snapshots/oauth_client_substage_snapshots__scope_variations_default_run_snapshot.snap