tangled.org / core
Monorepo for Tangled tangled.org
771
fork

Configure Feed

Select the types of activity you want to include in your feed.

appview/indexer: propagate SearchInContext error instead of nil, nil

Search was returning nil,nil on error, silently bypassing every
caller's error guard and causing a nil pointer dereference on the
result. Return nil,err instead.

Signed-off-by: Matías Insaurralde <matias@insaurral.de>

authored by

Matías Insaurralde and committed by tangled.org 362c2b25 5492af83

+3 -3
+1 -1
appview/indexer/issues/indexer.go
··· 309 309 searchReq := bleve.NewSearchRequestOptions(indexerQuery, opts.Page.Limit, opts.Page.Offset, false) 310 310 res, err := ix.indexer.SearchInContext(ctx, searchReq) 311 311 if err != nil { 312 - return nil, nil 312 + return nil, err 313 313 } 314 314 ret := &SearchResult{ 315 315 Total: res.Total,
+1 -1
appview/indexer/pulls/indexer.go
··· 310 310 searchReq := bleve.NewSearchRequestOptions(indexerQuery, limit, opts.Page.Offset, false) 311 311 res, err := ix.indexer.SearchInContext(ctx, searchReq) 312 312 if err != nil { 313 - return nil, nil 313 + return nil, err 314 314 } 315 315 ret := &searchResult{ 316 316 Total: res.Total,
+1 -1
appview/indexer/repos/indexer.go
··· 495 495 496 496 res, err := ix.indexer.SearchInContext(ctx, searchReq) 497 497 if err != nil { 498 - return nil, nil 498 + return nil, err 499 499 } 500 500 ret := &SearchResult{ 501 501 Total: res.Total,