tangled.org / core

826

Monorepo for Tangled tangled.org

826

knotserver: close reader in FileContentsN #286

open opened by

oppi.li 3 days ago targeting master from op/ozrwlpyqxkmn

not the biggest driver of mem issues, but better to close than wait for gc pressure i guess.

Signed-off-by: oppiliappan me@oppi.li

STACK 3

#286 knotserver: close reader in FileContentsN

#285 knotserver/git: fix double allocation of stdout

#284 knotserver/git: fix double allocation of patch string

Labels

None yet.

assignee

None yet.

Participants 1

AT URI

at://did:plc:qfpnj4og54vl56wngdriaxug/sh.tangled.repo.pull/3mks6srzybm22

+1

1 changed file

Diff round #0

expand all

knotserver

git

git.go

+1

knotserver/git/git.go

··· 165 165 if err != nil { 166 166 return nil, err 167 167 } 168 + defer reader.Close() 168 169 169 170 buf := new(bytes.Buffer) 170 171 if _, err = buf.ReadFrom(io.LimitReader(reader, cap)); err != nil {

History

1 round 0 comments

sign up or login to add to the discussion

oppi.li submitted #0 3d

1 commit

expand

4e3a1ef8

knotserver: close reader in FileContentsN

merge conflicts detected

expand

knotserver/git/diff.go:108

expand 0 comments