tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

scsi: storvsc: Limit max_sectors for virtual Fibre Channel devices

The Hyper-V host is queried to get the max transfer size that it supports,
and this value is used to set max_sectors for the synthetic SCSI
controller. However, this max transfer size may be too large for virtual
Fibre Channel devices, which are limited to 512 Kbytes. If a larger
transfer size is used with a vFC device, Hyper-V always returns an error,
and storvsc logs a message like this where the SRB status and SCSI status
are both zero:

hv_storvsc <GUID>: tag#197 cmd 0x8a status: scsi 0x0 srb 0x0 hv 0xc0000001

Add logic to limit the max transfer size to 512 Kbytes for vFC devices.

Fixes: 1d3e0980782f ("scsi: storvsc: Correct reporting of Hyper-V I/O size limits")
Cc: stable@vger.kernel.org
Signed-off-by: Michael Kelley <mikelley@microsoft.com>
Link: https://lore.kernel.org/r/1689887102-32806-1-git-send-email-mikelley@microsoft.com
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

authored by

Michael Kelley and committed by
Martin K. Petersen 010c1e1c 80b60510

+4
+4
drivers/scsi/storvsc_drv.c
··· 366 366 #define STORVSC_FC_MAX_LUNS_PER_TARGET 255 367 367 #define STORVSC_FC_MAX_TARGETS 128 368 368 #define STORVSC_FC_MAX_CHANNELS 8 369 + #define STORVSC_FC_MAX_XFER_SIZE ((u32)(512 * 1024)) 369 370 370 371 #define STORVSC_IDE_MAX_LUNS_PER_TARGET 64 371 372 #define STORVSC_IDE_MAX_TARGETS 1 ··· 2007 2006 * protecting it from any weird value. 2008 2007 */ 2009 2008 max_xfer_bytes = round_down(stor_device->max_transfer_bytes, HV_HYP_PAGE_SIZE); 2009 + if (is_fc) 2010 + max_xfer_bytes = min(max_xfer_bytes, STORVSC_FC_MAX_XFER_SIZE); 2011 + 2010 2012 /* max_hw_sectors_kb */ 2011 2013 host->max_sectors = max_xfer_bytes >> 9; 2012 2014 /*