tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

net: mana: Add MAC address to vPort logs and clarify error messages

Add MAC address to vPort configuration success message and update error
message to be more specific about HWC message errors in
mana_send_request.

Signed-off-by: Erni Sri Satya Vennela <ernis@linux.microsoft.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20260302174204.234837-1-ernis@linux.microsoft.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>

authored by

Erni Sri Satya Vennela and committed by
Paolo Abeni 0172f8d8 6d32a196

+11 -9
+7 -5
drivers/net/ethernet/microsoft/mana/hw_channel.c
··· 853 853 struct hwc_caller_ctx *ctx; 854 854 u32 dest_vrcq = 0; 855 855 u32 dest_vrq = 0; 856 + u32 command; 856 857 u16 msg_id; 857 858 int err; 858 859 ··· 879 878 req_msg->req.hwc_msg_id = msg_id; 880 879 881 880 tx_wr->msg_size = req_len; 881 + command = req_msg->req.msg_type; 882 882 883 883 if (gc->is_pf) { 884 884 dest_vrq = hwc->pf_dest_vrq_id; ··· 895 893 if (!wait_for_completion_timeout(&ctx->comp_event, 896 894 (msecs_to_jiffies(hwc->hwc_timeout)))) { 897 895 if (hwc->hwc_timeout != 0) 898 - dev_err(hwc->dev, "HWC: Request timed out: %u ms\n", 899 - hwc->hwc_timeout); 896 + dev_err(hwc->dev, "Command 0x%x timed out: %u ms\n", 897 + command, hwc->hwc_timeout); 900 898 901 899 /* Reduce further waiting if HWC no response */ 902 900 if (hwc->hwc_timeout > 1) ··· 916 914 err = -EOPNOTSUPP; 917 915 goto out; 918 916 } 919 - if (req_msg->req.msg_type != MANA_QUERY_PHY_STAT) 920 - dev_err(hwc->dev, "HWC: Failed hw_channel req: 0x%x\n", 921 - ctx->status_code); 917 + if (command != MANA_QUERY_PHY_STAT) 918 + dev_err(hwc->dev, "Command 0x%x failed with status: 0x%x\n", 919 + command, ctx->status_code); 922 920 err = -EPROTO; 923 921 goto out; 924 922 }
+4 -4
drivers/net/ethernet/microsoft/mana/mana_en.c
··· 1021 1021 1022 1022 if (req->req.msg_type != MANA_QUERY_PHY_STAT && 1023 1023 mana_need_log(gc, err)) 1024 - dev_err(dev, "Failed to send mana message: %d, 0x%x\n", 1025 - err, resp->status); 1024 + dev_err(dev, "Command 0x%x failed with status: 0x%x, err: %d\n", 1025 + req->req.msg_type, resp->status, err); 1026 1026 return err ? err : -EPROTO; 1027 1027 } 1028 1028 ··· 1335 1335 apc->tx_shortform_allowed = resp.short_form_allowed; 1336 1336 apc->tx_vp_offset = resp.tx_vport_offset; 1337 1337 1338 - netdev_info(apc->ndev, "Configured vPort %llu PD %u DB %u\n", 1339 - apc->port_handle, protection_dom_id, doorbell_pg_id); 1338 + netdev_info(apc->ndev, "Enabled vPort %llu PD %u DB %u MAC %pM\n", 1339 + apc->port_handle, protection_dom_id, doorbell_pg_id, apc->mac_addr); 1340 1340 out: 1341 1341 if (err) 1342 1342 mana_uncfg_vport(apc);