Linux kernel mirror (for testing)
git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel
os
linux
staging: rtl8723bs: rename u1bTmp to val
Rename the variable u1bTmp to val to remove Hungarian notation. This
improves readability and aligns the code with kernel naming standards.
Signed-off-by: Luka Gejak <lukagejak5@gmail.com>
Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://patch.msgid.link/20260130185658.207785-3-lukagejak5@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
authored by
Luka Gejak
and committed by
Greg Kroah-Hartman
01e28097
7de30d5d
+22
-22
+6
-6
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
+6
-6
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
···
259
259
void rtl8723b_FirmwareSelfReset(struct adapter *padapter)
260
260
{
261
261
struct hal_com_data *pHalData = GET_HAL_DATA(padapter);
262
-
u8 u1bTmp;
262
+
u8 val;
263
263
u8 Delay = 100;
264
264
265
265
if (
···
268
268
/* 0x1cf = 0x20. Inform 8051 to reset. 2009.12.25. tynli_test */
269
269
rtw_write8(padapter, REG_HMETFR+3, 0x20);
270
270
271
-
u1bTmp = rtw_read8(padapter, REG_SYS_FUNC_EN+1);
272
-
while (u1bTmp & BIT2) {
271
+
val = rtw_read8(padapter, REG_SYS_FUNC_EN+1);
272
+
while (val & BIT2) {
273
273
Delay--;
274
274
if (Delay == 0)
275
275
break;
276
276
udelay(50);
277
-
u1bTmp = rtw_read8(padapter, REG_SYS_FUNC_EN+1);
277
+
val = rtw_read8(padapter, REG_SYS_FUNC_EN+1);
278
278
}
279
279
280
280
if (Delay == 0) {
281
281
/* force firmware reset */
282
-
u1bTmp = rtw_read8(padapter, REG_SYS_FUNC_EN+1);
283
-
rtw_write8(padapter, REG_SYS_FUNC_EN+1, u1bTmp&(~BIT2));
282
+
val = rtw_read8(padapter, REG_SYS_FUNC_EN+1);
283
+
rtw_write8(padapter, REG_SYS_FUNC_EN+1, val&(~BIT2));
284
284
}
285
285
}
286
286
}
+16
-16
drivers/staging/rtl8723bs/hal/sdio_halinit.c
+16
-16
drivers/staging/rtl8723bs/hal/sdio_halinit.c
···
589
589
struct hal_com_data *pHalData;
590
590
struct pwrctrl_priv *pwrctrlpriv;
591
591
u32 NavUpper = WiFiNavUpperUs;
592
-
u8 u1bTmp;
592
+
u8 val;
593
593
594
594
pHalData = GET_HAL_DATA(padapter);
595
595
pwrctrlpriv = adapter_to_pwrctl(padapter);
···
780
780
pHalData->SdioTxOQTMaxFreeSpace = pHalData->SdioTxOQTFreeSpace;
781
781
782
782
/* Enable MACTXEN/MACRXEN block */
783
-
u1bTmp = rtw_read8(padapter, REG_CR);
784
-
u1bTmp |= (MACTXEN | MACRXEN);
785
-
rtw_write8(padapter, REG_CR, u1bTmp);
783
+
val = rtw_read8(padapter, REG_CR);
784
+
val |= (MACTXEN | MACRXEN);
785
+
rtw_write8(padapter, REG_CR, val);
786
786
787
787
rtw_hal_set_hwreg(padapter, HW_VAR_NAV_UPPER, (u8 *)&NavUpper);
788
788
···
848
848
/* */
849
849
static void CardDisableRTL8723BSdio(struct adapter *padapter)
850
850
{
851
-
u8 u1bTmp;
851
+
u8 val;
852
852
u8 bMacPwrCtrlOn;
853
853
854
854
/* Run LPS WL RFOFF flow */
···
856
856
857
857
/* ==== Reset digital sequence ====== */
858
858
859
-
u1bTmp = rtw_read8(padapter, REG_MCUFWDL);
860
-
if ((u1bTmp & RAM_DL_SEL) && padapter->bFWReady) /* 8051 RAM code */
859
+
val = rtw_read8(padapter, REG_MCUFWDL);
860
+
if ((val & RAM_DL_SEL) && padapter->bFWReady) /* 8051 RAM code */
861
861
rtl8723b_FirmwareSelfReset(padapter);
862
862
863
863
/* Reset MCU 0x2[10]= 0. Suggested by Filen. 2011.01.26. by tynli. */
864
-
u1bTmp = rtw_read8(padapter, REG_SYS_FUNC_EN + 1);
865
-
u1bTmp &= ~BIT(2); /* 0x2[10], FEN_CPUEN */
866
-
rtw_write8(padapter, REG_SYS_FUNC_EN + 1, u1bTmp);
864
+
val = rtw_read8(padapter, REG_SYS_FUNC_EN + 1);
865
+
val &= ~BIT(2); /* 0x2[10], FEN_CPUEN */
866
+
rtw_write8(padapter, REG_SYS_FUNC_EN + 1, val);
867
867
868
868
/* MCUFWDL 0x80[1:0]= 0 */
869
869
/* reset MCU ready status */
870
870
rtw_write8(padapter, REG_MCUFWDL, 0);
871
871
872
872
/* Reset MCU IO Wrapper, added by Roger, 2011.08.30 */
873
-
u1bTmp = rtw_read8(padapter, REG_RSV_CTRL + 1);
874
-
u1bTmp &= ~BIT(0);
875
-
rtw_write8(padapter, REG_RSV_CTRL + 1, u1bTmp);
876
-
u1bTmp = rtw_read8(padapter, REG_RSV_CTRL + 1);
877
-
u1bTmp |= BIT(0);
878
-
rtw_write8(padapter, REG_RSV_CTRL+1, u1bTmp);
873
+
val = rtw_read8(padapter, REG_RSV_CTRL + 1);
874
+
val &= ~BIT(0);
875
+
rtw_write8(padapter, REG_RSV_CTRL + 1, val);
876
+
val = rtw_read8(padapter, REG_RSV_CTRL + 1);
877
+
val |= BIT(0);
878
+
rtw_write8(padapter, REG_RSV_CTRL+1, val);
879
879
880
880
/* ==== Reset digital sequence end ====== */
881
881