tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

rtc: rs5c372: Remove use of i2c_match_id()

The function i2c_match_id() is used to fetch the matching ID from
the i2c_device_id table. This is often used to then retrieve the
matching driver_data. This can be done in one step with the helper
i2c_get_match_data().

This helper has a couple other benefits:
* It doesn't need the i2c_device_id passed in so we do not need
to have that forward declared, allowing us to remove those or
move the i2c_device_id table down to its more natural spot
with the other module info.
* It also checks for device match data, which allows for OF and
ACPI based probing. That means we do not have to manually check
those first and can remove those checks.

Signed-off-by: Andrew Davis <afd@ti.com>
Link: https://patch.msgid.link/20260305193545.796294-5-afd@ti.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>

authored by

Andrew Davis and committed by
Alexandre Belloni 022bfe69 c85ac0b4

+1 -6
+1 -6
drivers/rtc/rtc-rs5c372.c
··· 825 825 826 826 rs5c372->client = client; 827 827 i2c_set_clientdata(client, rs5c372); 828 - if (client->dev.of_node) { 829 - rs5c372->type = (uintptr_t)of_device_get_match_data(&client->dev); 830 - } else { 831 - const struct i2c_device_id *id = i2c_match_id(rs5c372_id, client); 832 - rs5c372->type = id->driver_data; 833 - } 828 + rs5c372->type = (uintptr_t)i2c_get_match_data(client); 834 829 835 830 /* we read registers 0x0f then 0x00-0x0f; skip the first one */ 836 831 rs5c372->regs = &rs5c372->buf[1];