tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

net: usb: sr9700: stop lying about skb->truesize

Some usb drivers set small skb->truesize and break
core networking stacks.

In this patch, I removed one of the skb->truesize override.

I also replaced one skb_clone() by an allocation of a fresh
and small skb, to get minimally sized skbs, like we did
in commit 1e2c61172342 ("net: cdc_ncm: reduce skb truesize
in rx path") and 4ce62d5b2f7a ("net: usb: ax88179_178a:
stop lying about skb->truesize")

Fixes: c9b37458e956 ("USB2NET : SR9700 : One chip USB 1.1 USB2NET SR9700Device Driver Support")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Link: https://lore.kernel.org/r/20240506143939.3673865-1-edumazet@google.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

authored by

Eric Dumazet and committed by
Jakub Kicinski 05417aa9 1b3b2d9e

+3 -7
+3 -7
drivers/net/usb/sr9700.c
··· 421 421 skb_pull(skb, 3); 422 422 skb->len = len; 423 423 skb_set_tail_pointer(skb, len); 424 - skb->truesize = len + sizeof(struct sk_buff); 425 424 return 2; 426 425 } 427 426 428 - /* skb_clone is used for address align */ 429 - sr_skb = skb_clone(skb, GFP_ATOMIC); 427 + sr_skb = netdev_alloc_skb_ip_align(dev->net, len); 430 428 if (!sr_skb) 431 429 return 0; 432 430 433 - sr_skb->len = len; 434 - sr_skb->data = skb->data + 3; 435 - skb_set_tail_pointer(sr_skb, len); 436 - sr_skb->truesize = len + sizeof(struct sk_buff); 431 + skb_put(sr_skb, len); 432 + memcpy(sr_skb->data, skb->data + 3, len); 437 433 usbnet_skb_return(dev, sr_skb); 438 434 439 435 skb_pull(skb, len + SR_RX_OVERHEAD);