soc: qcom: pmic_glink_altmode: add retimer-switch support

Some boards have a retimer/redriver between the SuperSpeed
PHY and the USB-C connector to compensates signal integrity
losses mainly due to PCB & transmission cables.

Add support for an optional retimer-switch in the USB-C
connector graph.

Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
Link: https://lore.kernel.org/r/20230601-topic-sm8550-upstream-type-c-v5-2-9221cd300903@linaro.org
Signed-off-by: Bjorn Andersson <andersson@kernel.org>

authored by

Neil Armstrong and committed by

Bjorn Andersson 2 years ago 0549bc38 1beecfe6

+43

1 changed file

expand all

drivers

soc

qcom

pmic_glink_altmode.c

+43

drivers/soc/qcom/pmic_glink_altmode.c

··· 16 16 #include <linux/usb/typec_altmode.h> 17 17 #include <linux/usb/typec_dp.h> 18 18 #include <linux/usb/typec_mux.h> 19 + #include <linux/usb/typec_retimer.h> 19 20 20 21 #include <linux/soc/qcom/pmic_glink.h> 21 22 ··· 70 69 struct typec_switch *typec_switch; 71 70 struct typec_mux *typec_mux; 72 71 struct typec_mux_state state; 72 + struct typec_retimer *typec_retimer; 73 + struct typec_retimer_state retimer_state; 73 74 struct typec_altmode dp_alt; 74 75 75 76 struct work_struct work; ··· 161 158 ret = typec_mux_set(port->typec_mux, &port->state); 162 159 if (ret) 163 160 dev_err(altmode->dev, "failed to switch mux to DP\n"); 161 + 162 + port->retimer_state.alt = &port->dp_alt; 163 + port->retimer_state.data = &dp_data; 164 + port->retimer_state.mode = TYPEC_MODAL_STATE(mode); 165 + 166 + ret = typec_retimer_set(port->typec_retimer, &port->retimer_state); 167 + if (ret) 168 + dev_err(altmode->dev, "failed to setup retimer to DP\n"); 164 169 } 165 170 166 171 static void pmic_glink_altmode_enable_usb(struct pmic_glink_altmode *altmode, ··· 183 172 ret = typec_mux_set(port->typec_mux, &port->state); 184 173 if (ret) 185 174 dev_err(altmode->dev, "failed to switch mux to USB\n"); 175 + 176 + port->retimer_state.alt = NULL; 177 + port->retimer_state.data = NULL; 178 + port->retimer_state.mode = TYPEC_STATE_USB; 179 + 180 + ret = typec_retimer_set(port->typec_retimer, &port->retimer_state); 181 + if (ret) 182 + dev_err(altmode->dev, "failed to setup retimer to USB\n"); 186 183 } 187 184 188 185 static void pmic_glink_altmode_safe(struct pmic_glink_altmode *altmode, ··· 205 186 ret = typec_mux_set(port->typec_mux, &port->state); 206 187 if (ret) 207 188 dev_err(altmode->dev, "failed to switch mux to safe mode\n"); 189 + 190 + port->retimer_state.alt = NULL; 191 + port->retimer_state.data = NULL; 192 + port->retimer_state.mode = TYPEC_STATE_SAFE; 193 + 194 + ret = typec_retimer_set(port->typec_retimer, &port->retimer_state); 195 + if (ret) 196 + dev_err(altmode->dev, "failed to setup retimer to USB\n"); 208 197 } 209 198 210 199 static void pmic_glink_altmode_worker(struct work_struct *work) ··· 375 348 .attach = pmic_glink_altmode_attach, 376 349 }; 377 350 351 + static void pmic_glink_altmode_put_retimer(void *data) 352 + { 353 + typec_retimer_put(data); 354 + } 355 + 378 356 static void pmic_glink_altmode_put_mux(void *data) 379 357 { 380 358 typec_mux_put(data); ··· 483 451 484 452 ret = devm_add_action_or_reset(dev, pmic_glink_altmode_put_mux, 485 453 alt_port->typec_mux); 454 + if (ret) 455 + return ret; 456 + 457 + alt_port->typec_retimer = fwnode_typec_retimer_get(fwnode); 458 + if (IS_ERR(alt_port->typec_retimer)) 459 + return dev_err_probe(dev, PTR_ERR(alt_port->typec_retimer), 460 + "failed to acquire retimer-switch for port: %d\n", 461 + port); 462 + 463 + ret = devm_add_action_or_reset(dev, pmic_glink_altmode_put_retimer, 464 + alt_port->typec_retimer); 486 465 if (ret) 487 466 return ret; 488 467

Configure Feed

Configure Feed