tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

drm/panic: allow verbose version check

Clippy warns about a reimplementation of `RangeInclusive::contains`:

error: manual `!RangeInclusive::contains` implementation
--> drivers/gpu/drm/drm_panic_qr.rs:986:8
|
986 | if version < 1 || version > 40 {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `!(1..=40).contains(&version)`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains
= note: `-D clippy::manual-range-contains` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::manual_range_contains)]`

Ignore this and keep the current implementation as that makes it easier
to read.

Fixes: cb5164ac43d0 ("drm/panic: Add a QR code panic screen")
Reported-by: Miguel Ojeda <ojeda@kernel.org>
Link: https://github.com/Rust-for-Linux/linux/issues/1123
Signed-off-by: Thomas Böhler <witcher@wiredspace.de>
Reviewed-by: Jocelyn Falempe <jfalempe@redhat.com>
Link: https://lore.kernel.org/r/20241019084048.22336-8-witcher@wiredspace.de
Signed-off-by: Miguel Ojeda <ojeda@kernel.org>

authored by

Thomas Böhler and committed by
Miguel Ojeda 06b919e3 27aef8a5

+1
+1
drivers/gpu/drm/drm_panic_qr.rs
··· 983 983 /// * If `url_len` = 0, only removes 3 bytes for 1 binary segment. 984 984 #[no_mangle] 985 985 pub extern "C" fn drm_panic_qr_max_data_size(version: u8, url_len: usize) -> usize { 986 + #[expect(clippy::manual_range_contains)] 986 987 if version < 1 || version > 40 { 987 988 return 0; 988 989 }