tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

USB: apple-mfi-fastcharge: drop redundant device reference

Driver core holds a reference to the USB device while it is bound to a
driver and there is no need to take additional references unless the
structure is needed after disconnect.

Drop the redundant device reference to reduce cargo culting, make it
easier to spot drivers where an extra reference is needed, and reduce
the risk of memory leaks when drivers fail to release it.

Signed-off-by: Johan Hovold <johan@kernel.org>
Reviewed-by: Bastien Nocera <hadess@hadess.net>
Link: https://patch.msgid.link/20260305133851.2952-2-johan@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

authored by

Johan Hovold and committed by
Greg Kroah-Hartman 0888c337 de6c925d

+1 -2
+1 -2
drivers/usb/misc/apple-mfi-fastcharge.c
··· 210 210 goto err_free_name; 211 211 } 212 212 213 - mfi->udev = usb_get_dev(udev); 213 + mfi->udev = udev; 214 214 dev_set_drvdata(&udev->dev, mfi); 215 215 216 216 return 0; ··· 231 231 power_supply_unregister(mfi->battery); 232 232 kfree(mfi->battery_desc.name); 233 233 dev_set_drvdata(&udev->dev, NULL); 234 - usb_put_dev(mfi->udev); 235 234 kfree(mfi); 236 235 } 237 236