tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

r8152: replace dev_info with dev_dbg for loading firmware

Someone complains the message appears continuously. This occurs
because the device is woken from UPS mode, and the driver re-loads
the firmware.

When the device enters runtime suspend and cable is unplugged, the
device would enter UPS mode. If the runtime resume occurs, and the
device is woken from UPS mode, the driver has to re-load the firmware
and causes the message. If someone wakes the device continuously, the
message would be shown continuously, too. Use dev_dbg to avoid it.

Note that, the function could be called before register_netdev(), so I
don't use netif_info() or netif_dbg().

Signed-off-by: Hayes Wang <hayeswang@realtek.com>
Link: https://lore.kernel.org/r/20240424084532.159649-1-hayeswang@realtek.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

authored by

Hayes Wang and committed by
Jakub Kicinski 092d2141 3837639e

+1 -1
+1 -1
drivers/net/usb/r8152.c
··· 5274 5274 5275 5275 rtl_reset_ocp_base(tp); 5276 5276 strscpy(rtl_fw->version, fw_hdr->version, RTL_VER_SIZE); 5277 - dev_info(&tp->intf->dev, "load %s successfully\n", rtl_fw->version); 5277 + dev_dbg(&tp->intf->dev, "load %s successfully\n", rtl_fw->version); 5278 5278 } 5279 5279 5280 5280 static void rtl8152_release_firmware(struct r8152 *tp)