Linux kernel mirror (for testing)
git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel
os
linux
media: i2c: imx290: Move registers with fixed value to init array
Registers 0x3012, 0x3013 and 0x3480 are not documented and are set in
the per-mode register arrays with values indentical for all modes. Move
them to the common array.
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Acked-by: Alexander Stein <alexander.stein@ew.tq-group.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
authored by
Laurent Pinchart
and committed by
Sakari Ailus
0b274ef2
4c9c93cf
+2
-6
+2
-6
drivers/media/i2c/imx290.c
+2
-6
drivers/media/i2c/imx290.c
···
192
192
{ IMX290_REG_8BIT(0x300f), 0x00 },
193
193
{ IMX290_REG_8BIT(0x3010), 0x21 },
194
194
{ IMX290_REG_8BIT(0x3012), 0x64 },
195
+
{ IMX290_REG_8BIT(0x3013), 0x00 },
195
196
{ IMX290_REG_8BIT(0x3016), 0x09 },
196
197
{ IMX290_REG_8BIT(0x3070), 0x02 },
197
198
{ IMX290_REG_8BIT(0x3071), 0x11 },
···
231
230
{ IMX290_REG_8BIT(0x33b0), 0x50 },
232
231
{ IMX290_REG_8BIT(0x33b2), 0x1a },
233
232
{ IMX290_REG_8BIT(0x33b3), 0x04 },
233
+
{ IMX290_REG_8BIT(0x3480), 0x49 },
234
234
};
235
235
236
236
static const struct imx290_regval imx290_1080p_settings[] = {
···
241
239
{ IMX290_OPB_SIZE_V, 10 },
242
240
{ IMX290_X_OUT_SIZE, 1920 },
243
241
{ IMX290_Y_OUT_SIZE, 1080 },
244
-
{ IMX290_REG_8BIT(0x3012), 0x64 },
245
-
{ IMX290_REG_8BIT(0x3013), 0x00 },
246
242
{ IMX290_INCKSEL1, 0x18 },
247
243
{ IMX290_INCKSEL2, 0x03 },
248
244
{ IMX290_INCKSEL3, 0x20 },
249
245
{ IMX290_INCKSEL4, 0x01 },
250
246
{ IMX290_INCKSEL5, 0x1a },
251
247
{ IMX290_INCKSEL6, 0x1a },
252
-
{ IMX290_REG_8BIT(0x3480), 0x49 },
253
248
/* data rate settings */
254
249
{ IMX290_REPETITION, 0x10 },
255
250
{ IMX290_TCLKPOST, 87 },
···
266
267
{ IMX290_OPB_SIZE_V, 4 },
267
268
{ IMX290_X_OUT_SIZE, 1280 },
268
269
{ IMX290_Y_OUT_SIZE, 720 },
269
-
{ IMX290_REG_8BIT(0x3012), 0x64 },
270
-
{ IMX290_REG_8BIT(0x3013), 0x00 },
271
270
{ IMX290_INCKSEL1, 0x20 },
272
271
{ IMX290_INCKSEL2, 0x00 },
273
272
{ IMX290_INCKSEL3, 0x20 },
274
273
{ IMX290_INCKSEL4, 0x01 },
275
274
{ IMX290_INCKSEL5, 0x1a },
276
275
{ IMX290_INCKSEL6, 0x1a },
277
-
{ IMX290_REG_8BIT(0x3480), 0x49 },
278
276
/* data rate settings */
279
277
{ IMX290_REPETITION, 0x10 },
280
278
{ IMX290_TCLKPOST, 79 },