tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

platform/x86/amd/pmf: Use devm_mutex_init() for mutex initialization

Replace mutex_init() with the devm_mutex_init(), to ensure proper mutex
cleanup during probe failure and driver removal.

Signed-off-by: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
Link: https://patch.msgid.link/20251119085813.546813-2-Shyam-sundar.S-k@amd.com
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>

authored by

Shyam Sundar S K and committed by
Ilpo Järvinen 0b39ce8f 2bd038de

+11 -6
+11 -6
drivers/platform/x86/amd/pmf/core.c
··· 465 465 if (!dev->regbase) 466 466 return -ENOMEM; 467 467 468 - mutex_init(&dev->lock); 469 - mutex_init(&dev->update_mutex); 470 - mutex_init(&dev->cb_mutex); 468 + err = devm_mutex_init(dev->dev, &dev->lock); 469 + if (err) 470 + return err; 471 + 472 + err = devm_mutex_init(dev->dev, &dev->update_mutex); 473 + if (err) 474 + return err; 475 + 476 + err = devm_mutex_init(dev->dev, &dev->cb_mutex); 477 + if (err) 478 + return err; 471 479 472 480 apmf_acpi_init(dev); 473 481 platform_set_drvdata(pdev, dev); ··· 499 491 amd_pmf_notify_sbios_heartbeat_event_v2(dev, ON_UNLOAD); 500 492 apmf_acpi_deinit(dev); 501 493 amd_pmf_dbgfs_unregister(dev); 502 - mutex_destroy(&dev->lock); 503 - mutex_destroy(&dev->update_mutex); 504 - mutex_destroy(&dev->cb_mutex); 505 494 } 506 495 507 496 static const struct attribute_group *amd_pmf_driver_groups[] = {