tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

media: qcom: camss: csid-340: Fix unused variables

The CSID driver has some unused variables and function parameters
that are no longer needed (due to refactoring). Clean up those
unused elements:

- Remove the `vc` parameter from `__csid_configure_rx()`.
- Drop the unused `lane_cnt` variable.
- Adjust call to `__csid_configure_rx()` accordingly.

Signed-off-by: Loic Poulain <loic.poulain@oss.qualcomm.com>
Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Reviewed-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
Signed-off-by: Bryan O'Donoghue <bod@kernel.org>
Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>

authored by

Loic Poulain and committed by
Hans Verkuil 0b61ce8d a89e490b

+3 -7
+3 -7
drivers/media/platform/qcom/camss/camss-csid-340.c
··· 55 55 #define CSID_RDI_CTRL_HALT_AT_FRAME_BOUNDARY 0 56 56 #define CSID_RDI_CTRL_RESUME_AT_FRAME_BOUNDARY 1 57 57 58 - static void __csid_configure_rx(struct csid_device *csid, 59 - struct csid_phy_config *phy, int vc) 58 + static void __csid_configure_rx(struct csid_device *csid, struct csid_phy_config *phy) 60 59 { 61 60 u32 val; 62 61 ··· 80 81 const struct csid_format_info *format = csid_get_fmt_entry(csid->res->formats->formats, 81 82 csid->res->formats->nformats, 82 83 input_format->code); 83 - u8 lane_cnt = csid->phy.lane_cnt; 84 84 u8 dt_id; 85 85 u32 val; 86 - 87 - if (!lane_cnt) 88 - lane_cnt = 4; 89 86 90 87 /* 91 88 * DT_ID is a two bit bitfield that is concatenated with ··· 115 120 { 116 121 int i; 117 122 123 + __csid_configure_rx(csid, &csid->phy); 124 + 118 125 for (i = 0; i < MSM_CSID_MAX_SRC_STREAMS; i++) { 119 126 if (csid->phy.en_vc & BIT(i)) { 120 127 __csid_configure_rdi_stream(csid, enable, i); 121 - __csid_configure_rx(csid, &csid->phy, i); 122 128 __csid_ctrl_rdi(csid, enable, i); 123 129 } 124 130 }