tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

drm/panfrost: Use GPU_MMU_FEATURES_VA_BITS/PA_BITS macros

As done in panthor, define and use these GPU_MMU_FEATURES_* macros,
which makes code easier to read and reuse.

Signed-off-by: Ariel D'Alessandro <ariel.dalessandro@collabora.com>
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
Reviewed-by: Steven Price <steven.price@arm.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Reviewed-by: Adrián Larumbe <adrian.larumbe@collabora.com>
Signed-off-by: Steven Price <steven.price@arm.com>
Link: https://lore.kernel.org/r/20250324185801.168664-3-ariel.dalessandro@collabora.com

authored by

Ariel D'Alessandro and committed by
Steven Price 0b9bcf9a f91e534f

+6 -2
+4 -2
drivers/gpu/drm/panfrost/panfrost_mmu.c
··· 615 615 616 616 struct panfrost_mmu *panfrost_mmu_ctx_create(struct panfrost_device *pfdev) 617 617 { 618 + u32 va_bits = GPU_MMU_FEATURES_VA_BITS(pfdev->features.mmu_features); 619 + u32 pa_bits = GPU_MMU_FEATURES_PA_BITS(pfdev->features.mmu_features); 618 620 struct panfrost_mmu *mmu; 619 621 620 622 mmu = kzalloc(sizeof(*mmu), GFP_KERNEL); ··· 635 633 636 634 mmu->pgtbl_cfg = (struct io_pgtable_cfg) { 637 635 .pgsize_bitmap = SZ_4K | SZ_2M, 638 - .ias = FIELD_GET(0xff, pfdev->features.mmu_features), 639 - .oas = FIELD_GET(0xff00, pfdev->features.mmu_features), 636 + .ias = va_bits, 637 + .oas = pa_bits, 640 638 .coherent_walk = pfdev->coherent, 641 639 .tlb = &mmu_tlb_ops, 642 640 .iommu_dev = pfdev->dev,
+2
drivers/gpu/drm/panfrost/panfrost_regs.h
··· 16 16 #define GROUPS_L2_COHERENT BIT(0) /* Cores groups are l2 coherent */ 17 17 18 18 #define GPU_MMU_FEATURES 0x014 /* (RO) MMU features */ 19 + #define GPU_MMU_FEATURES_VA_BITS(x) ((x) & GENMASK(7, 0)) 20 + #define GPU_MMU_FEATURES_PA_BITS(x) (((x) >> 8) & GENMASK(7, 0)) 19 21 #define GPU_AS_PRESENT 0x018 /* (RO) Address space slots present */ 20 22 #define GPU_JS_PRESENT 0x01C /* (RO) Job slots present */ 21 23